[GitHub] brooklyn-server pull request #953: Defers reading of config in SshCommandSen...

2018-04-20 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/953#discussion_r183000496 --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/ssh/SshCommandSensor.java --- @@ -105,6 +97,7 @@ public void apply(final EntityLocal

[GitHub] brooklyn-server pull request #953: Defers reading of config in SshCommandSen...

2018-04-20 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/953#discussion_r182982642 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/SshCommandSensorYamlTest.java --- @@ -110,7 +110,46 @@ public void

[GitHub] brooklyn-server pull request #953: Defers reading of config in SshCommandSen...

2018-04-20 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/953#discussion_r182982839 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/SshCommandSensorYamlTest.java --- @@ -110,7 +110,46 @@ public void

[GitHub] brooklyn-server pull request #953: Defers reading of config in SshCommandSen...

2018-04-20 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/953#discussion_r182983127 --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/ssh/SshCommandSensor.java --- @@ -105,6 +97,7 @@ public void apply(final EntityLocal

[GitHub] brooklyn-server pull request #953: Defers reading of config in SshCommandSen...

2018-04-16 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/953#discussion_r181700868 --- Diff: core/src/main/java/org/apache/brooklyn/core/sensor/ssh/SshCommandSensor.java --- @@ -136,7 +128,7 @@ public String get() {

[GitHub] brooklyn-server pull request #953: Defers reading of config in SshCommandSen...

2018-04-11 Thread nakomis
GitHub user nakomis opened a pull request: https://github.com/apache/brooklyn-server/pull/953 Defers reading of config in SshCommandSensor This allows DSL to be used in the command, env and execution dir as a management context will then be available You can merge this pull