[GitHub] brooklyn-ui issue #97: Generalise usage of $templateCache for blueprint comp...

2018-11-08 Thread ahgittin
Github user ahgittin commented on the issue:

https://github.com/apache/brooklyn-ui/pull/97
  
good addition, merging


---


[GitHub] brooklyn-ui issue #97: Generalise usage of $templateCache for blueprint comp...

2018-11-08 Thread aledsage
Github user aledsage commented on the issue:

https://github.com/apache/brooklyn-ui/pull/97
  
Description sounds sensible to me, and scanning through the code I didn't 
see anything obviously wrong!

I've tested it in `npm run start` mode, and all the relevant 
blueprint-composer features seem to still work, so I think the 
restructuring/wiring has been done correctly.

Happy for this to be merged, but if anyone else is reviewing the code more 
thoroughly then even happier to wait for them!


---