Github user tbouron commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206866563
> My point is that with loggerEnabled=false the Array prototype will not be
patched with contains, so no need to delete it.
My bad, I get what you are
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206858032
Also I am sure there are bugs in any library we use (as a general
principle) :). The question is how long it takes before bumping into them.
---
If your project is
Github user tbouron commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206855774
> The code causing the problem is called only when loggerEnabled is true.
Suggest disabling logging instead.
Even though, not removing the `contains` is
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206848116
Was just about to reply to the email thread :).
The code causing the problem is called only when `loggerEnabled` is true.
Suggest disabling logging instead.
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-ui/pull/25
Hotfix: Removing contains method from the Array prototype
This avoids breaking other parts of the UI
You can merge this pull request into a Git repository by running:
$ git pull
