[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206456324 We will probably have to cheat as the textarea is hidden by CodeMirror. AFAIK, we can still bound to those events but from the CodeMirror container rather than the

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206451829 My thinking was binding to the dragenter / dragover / dragleave events from the textarea assuming the codemirror code propagates said events. Then

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206447871 The drag & drop feature is provided by CodeMirror. I'm not sure it can be customised, I'll need to check that. That being said, the content of the file is

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206444894 LGTM **MINOR** * Might be worth adding styling for dragover * Might be worth verifying the type of the dropped file --- If your project is set

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/24 Update editor placeholder The text now makes it clear that users can use drag & drop to add text files' content into the editor ![brooklyn js rest