[GitHub] incubator-brooklyn pull request: Restore old HttpTool / Response f...

2015-11-13 Thread geomacy
Github user geomacy commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-156574267 Will do that, thanks Aled. G On Fri, 13 Nov 2015 22:11 Aled Sage wrote: > Thanks @geomacy - I'd als

[GitHub] incubator-brooklyn pull request: Restore old HttpTool / Response f...

2015-11-13 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-156573077 Thanks @geomacy - I'd also include a comment at the top of each of those classes to explain why the code is still there (rather than the "extends" mechani

[jira] [Commented] (BROOKLYN-193) Rebind failure: Cannot coerce or set value

2015-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004793#comment-15004793 ] ASF GitHub Bot commented on BROOKLYN-193: - Github user aledsage commented on the

[GitHub] incubator-brooklyn pull request: BROOKLYN-193: Add configuration f...

2015-11-13 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1033#issuecomment-156572688 Looks good. Can we get a unit test? Should the default be `addConfigFailureMode = RebindManager.RebindFailureMode.FAIL_AT_END`? If so, we need to

[jira] [Commented] (BROOKLYN-193) Rebind failure: Cannot coerce or set value

2015-11-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004782#comment-15004782 ] ASF GitHub Bot commented on BROOKLYN-193: - GitHub user bostko opened a pull requ

[GitHub] incubator-brooklyn pull request: BROOKLYN-193: Add configuration f...

2015-11-13 Thread bostko
GitHub user bostko opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1033 BROOKLYN-193: Add configuration for skipping invalid config Add configuration option for skipping invalid config values You can merge this pull request into a Git repository by running:

Re: Child Entities

2015-11-13 Thread Aled Sage
Hi, Svet's right: it's always been that way (since January 2014 when the functionality was added - c8fb5aac5b0c7f60ff98d6a9530d3aafb7e68edc). See SoftwareProcessDriverLifecycleEffectorTasks.startProcessesAtMachine, which calls StartableMethods.startingChildren(entity(), machineS.get()) - i.e

[GitHub] incubator-brooklyn pull request: Restore old HttpTool / Response f...

2015-11-13 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-156557447 Did some more testing, unfortunately this doesn't fully solve the problem. Will hold off merging so we can further discuss it. The changes here are perfectl

[GitHub] incubator-brooklyn pull request: Restore old HttpTool / Response f...

2015-11-13 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1032#issuecomment-156550709 Thanks @geomacy, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] incubator-brooklyn pull request: Add EntityAsserts and HttpUtils.

2015-11-13 Thread geomacy
Github user geomacy commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-156502758 Have added the changes in https://github.com/apache/incubator-brooklyn/pull/1032 --- If your project is set up for it, you can reply to this email and have

[GitHub] incubator-brooklyn pull request: Restore old HttpTool / Response f...

2015-11-13 Thread geomacy
GitHub user geomacy opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1032 Restore old HttpTool / Response for backward compatibility PR follow-up to comment https://github.com/apache/incubator-brooklyn/pull/994#discussion_r44706399 You can merge this pull r

Re: [jira] [Commented] (BROOKLYN-193) Rebind failure: Cannot coerce or set value

2015-11-13 Thread Geoff Macartney
My 0.2¢ on the last question - > Should we change the rebind code to be more similar (e.g. so it doesn't try > to coerce), or should we change the provisioning code so that it fails-fast > if the YAML is invalid like this? I’d vote certainly for the latter; but you could do both together - the

[jira] [Commented] (BROOKLYN-193) Rebind failure: Cannot coerce or set value

2015-11-13 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004368#comment-15004368 ] Aled Sage commented on BROOKLYN-193: We need to fix our rebind code so that it won't

[GitHub] incubator-brooklyn pull request: Improve performance tests

2015-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-brooklyn/pull/1027 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] incubator-brooklyn pull request: Improve performance tests

2015-11-13 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1027#issuecomment-156490614 Incorporated comments (except left the `PerformanceMeasurer` class name). Merging now. --- If your project is set up for it, you can reply to this email

[GitHub] incubator-brooklyn pull request: yaml testing docs

2015-11-13 Thread johnmccabe
GitHub user johnmccabe opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1031 yaml testing docs Added details of the Test Entities to the YAML Blueprints guide. Have explicitly *not* added a reference to the Java Blueprints section at this point, shou

Re: Child Entities

2015-11-13 Thread Svetoslav Neykov
Hi Martin, I believe this has always been the case, at least not changed recently. Spinning on the same machine is more of a side effect from entities inheriting their parent's locations than explicitly supporting this scenario. As a workaround you can configure the ports on the parent entity, it

Re: Child Entities

2015-11-13 Thread Martin Harris
P.S. for the SameServerEntity (which is used where you want multiple entities installed on the same VM), the ports of the child entities *are* added to the required ports[2] [2]: https://github.com/apache/incubator-brooklyn/blob/master/software/base/src/main/java/org/apache/brooklyn/entity/softwar

Child Entities

2015-11-13 Thread Martin Harris
Hi All, I'm deploying an app where a SoftwareProcess (TomcatServer) is the child of a VanillaSoftwareProcess, but when I deploy it, both the TomcatServer and the VanillaSoftwareProcess are installed on the same VM. Is this new behaviour or has it changed? I thought it provisioned a new VM for the

[GitHub] incubator-brooklyn pull request: Add EntityAsserts and HttpUtils.

2015-11-13 Thread geomacy
Github user geomacy commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/994#issuecomment-156472799 hi @neykov, sorry I had indeed missed this comment. Will make changes as you say. --- If your project is set up for it, you can reply to this email and hav

[GitHub] incubator-brooklyn pull request: SimpleCommand addition to brookly...

2015-11-13 Thread geomacy
GitHub user geomacy opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1030 SimpleCommand addition to brooklyn-test-framework ### Description An additional feature for the brooklyn-test-framework. Supports a test that runs a simple command (exp

[GitHub] incubator-brooklyn pull request: ParallelTestCase change and docum...

2015-11-13 Thread burkechris
GitHub user burkechris opened a pull request: https://github.com/apache/incubator-brooklyn/pull/1029 ParallelTestCase change and documentation updates Addressed review comments. * Changed how ParallelTestCase task is submitted and waited upon. Functionally no change. *

[GitHub] incubator-brooklyn pull request: Add TOSCA metadata support for ca...

2015-11-13 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1020#issuecomment-156433483 @ahgittin I addressed comments, I've also added capabilities and requirements. Tests are still missing but I will resolve that soon. --- If your project i

Re: talk about Apache Brooklyn at DevOps DC january

2015-11-13 Thread Alexandru Zbarcea
Hi Brooklyners, Hadrian and I were thinking about organizing a Brooklyn meetup in the DC area. There are a few big companies in the area and there is a very strong devops movement. We thought it would be best to first gauge the interest in the local community. In this context I discussed with the

[GitHub] incubator-brooklyn pull request: Fix mime-type typo

2015-11-13 Thread iyovcheva
Github user iyovcheva commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1024#issuecomment-156379840 Congrats @CMoH ! You were not the only one trying to open #1024 :) --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Updated] (BROOKLYN-193) Rebind failure: Cannot coerce or set value

2015-11-13 Thread Valentin Aitken (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Valentin Aitken updated BROOKLYN-193: - Description: *Use case* If you submit a blueprint with a value of invalid type it is acc

[jira] [Updated] (BROOKLYN-193) Rebind failure: Cannot coerce or set value

2015-11-13 Thread Valentin Aitken (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Valentin Aitken updated BROOKLYN-193: - Description: *Use case* If you submit a blueprint with a value of invalid type it is acc

[jira] [Created] (BROOKLYN-193) Rebind failure: Cannot coerce or set value

2015-11-13 Thread Valentin Aitken (JIRA)
Valentin Aitken created BROOKLYN-193: Summary: Rebind failure: Cannot coerce or set value Key: BROOKLYN-193 URL: https://issues.apache.org/jira/browse/BROOKLYN-193 Project: Brooklyn Issue

[GitHub] incubator-brooklyn pull request: Improve performance tests

2015-11-13 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1027#discussion_r44764144 --- Diff: usage/test-support/src/main/java/org/apache/brooklyn/test/performance/PerformanceMeasurer.java --- @@ -0,0 +1,154 @@ +/* + *

[GitHub] incubator-brooklyn pull request: Adding missing ASF license header...

2015-11-13 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1028#issuecomment-156371764 Thanks @m4rkmckenna - that was an extremely quick response! --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] incubator-brooklyn pull request: Add TOSCA metadata support for ca...

2015-11-13 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/1020#issuecomment-156368715 > i'm not sure we want to bake TOSCA (or any standard) in to the api project -- brooklyn thus far has been entirely neutral. (all things camp-specific are

[GitHub] incubator-brooklyn pull request: Add TOSCA metadata support for ca...

2015-11-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1020#discussion_r44760684 --- Diff: usage/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogEntitySummary.java --- @@ -46,6 +56,7 @@ public CatalogEntitySumma

[GitHub] incubator-brooklyn pull request: Add TOSCA metadata support for ca...

2015-11-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1020#discussion_r44760536 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogItemBuilder.java --- @@ -121,6 +121,11 @@ public CatalogItemBuilde

[GitHub] incubator-brooklyn pull request: Add TOSCA metadata support for ca...

2015-11-13 Thread tbouron
Github user tbouron commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/1020#discussion_r44760482 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BrooklynToscaTags.java --- @@ -0,0 +1,57 @@ +/* + * Licensed to t