koujian commented on issue #700: grpc迁移brpc问题
URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476073459
不使用grpc自带的插件无法支持service语义，请问是要下载哪个插件来支持service语义
This is an automated message from the Apache Git Se
zyearn commented on issue #700: grpc迁移brpc问题
URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476072707
需要把grpc自带的插件删掉
This is an automated message from the Apache Git Service.
To respond to the message, p
koujian commented on issue #700: grpc迁移brpc问题
URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476068122
这样做编不过的，类型都不一致。现在用proto.exe生成了helloworld.grpc.pb.h,helloworld.grpc.pb.cc;helloworld.pb.h、helloworld.pb.cc；helloworld.grpc.pb.h中service类派生自grpc::service而不是google::pro
zyearn commented on issue #700: grpc迁移brpc问题
URL: https://github.com/apache/incubator-brpc/issues/700#issuecomment-476043492
ClientContext在brpc里面对应是Controller，把本来要赋给ClientContext值在Controller里面找到对应项。
```
ClientContext context;
Status status = stub_->SayHello(&context, request, &reply
gydong commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268479078
##
File path: src/brpc/socket.cpp
##
@@ -979,6 +995,89 @@ void HealthCheckTask::OnDestroyingTask() {
delete this;
}
zyearn commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268477608
##
File path: src/brpc/socket.cpp
##
@@ -979,6 +995,89 @@ void HealthCheckTask::OnDestroyingTask() {
delete this;
}
gydong commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268469441
##
File path: src/brpc/socket.cpp
##
@@ -746,6 +758,11 @@ int Socket::WaitAndReset(int32_t expected_nref) {
gydong commented on a change in pull request #694: Health check by rpc call
URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268469307
##
File path: src/brpc/socket.cpp
##
@@ -979,6 +995,89 @@ void HealthCheckTask::OnDestroyingTask() {
delete this;
}
koujian opened a new issue #700: grpc迁移brpc问题
URL: https://github.com/apache/incubator-brpc/issues/700
grpc中根据pb文件转化的函数调用例子如下，第一个参数的类型是ClientContext*。但是brpc示例中SayHello的第一个参数是RpcController*类型，是因为protoc.exe版本的原因吗？？
ClientContext context;
// The actual RPC.
Status status = stub_->S
