wwbmmm commented on PR #2008:
URL: https://github.com/apache/incubator-brpc/pull/2008#issuecomment-1323020485
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Tuvie commented on code in PR #2005:
URL: https://github.com/apache/incubator-brpc/pull/2005#discussion_r1028788588
##
src/butil/iobuf.cpp:
##
@@ -1219,11 +1227,23 @@ int IOBuf::append_user_data(void* data, size_t size,
void (*deleter)(void*)) {
deleter = ::free;
Tuvie commented on code in PR #2005:
URL: https://github.com/apache/incubator-brpc/pull/2005#discussion_r1028788462
##
test/brpc_rdma_unittest.cpp:
##
@@ -80,6 +80,7 @@ extern bool g_skip_rdma_init;
}
}
+static const size_t MAX_USER_MRS = 16;
Review Comment:
should
vinllen closed issue #1997: 程序内部core但是core栈不完整
URL: https://github.com/apache/incubator-brpc/issues/1997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
guodongxiaren commented on PR #2008:
URL: https://github.com/apache/incubator-brpc/pull/2008#issuecomment-1322427935
测试过程中commit比较多，合并的时候可以选择 squash and merge @zyearn @wwbmmm
unittest在Linux上也有失败。后面单独提一个PR来让大家确认问题。
bazel编译，以及gcc clang分别编译，本周再提几次。
--
This is an
guodongxiaren commented on issue #1963:
URL:
https://github.com/apache/incubator-brpc/issues/1963#issuecomment-1322414866
sorry, I missed this message last week. I have submitted one pull request
for two compile task.
@zyearn
--
This is an automated message from the Apache Git
guodongxiaren opened a new pull request, #2008:
URL: https://github.com/apache/incubator-brpc/pull/2008
### What problem does this PR solve?
Issue Number:
Problem Summary:
### What is changed and the side effects?
Changed:
Side effects:
- Performance
ok, it looks go well
On 2022/11/21 07:55:45 Weibing Wang wrote:
> Hi
>
> After RDMA support merged, we have received some feedback, and some
> PRs with RDMA improvement have been merge:
>
> * https://github.com/apache/incubator-brpc/pull/1967
> *
