[GitHub] [incubator-brpc] wwbmmm commented on issue #2012: 为什么brpc_metrics接口不返回服务的平均latency?

2022-11-27 Thread GitBox
wwbmmm commented on issue #2012: URL: https://github.com/apache/incubator-brpc/issues/2012#issuecomment-1328621078 @xiaohei520321 可以试试PR #2024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [incubator-brpc] Huixxi commented on pull request #2024: add avg latency for prometheus metrics

2022-11-27 Thread GitBox
Huixxi commented on PR #2024: URL: https://github.com/apache/incubator-brpc/pull/2024#issuecomment-1328616643 Fix #2012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [incubator-brpc] Huixxi opened a new pull request, #2024: add avg latency for prometheus metrics

2022-11-27 Thread GitBox
Huixxi opened a new pull request, #2024: URL: https://github.com/apache/incubator-brpc/pull/2024 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影

[incubator-brpc] branch master updated: Update oncall.md

2022-11-27 Thread serverglen
This is an automated email from the ASF dual-hosted git repository. serverglen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new ed0ff2da Update oncall.md ed0ff2da i

[GitHub] [incubator-brpc] wwbmmm commented on pull request #2019: ssl错误码问题

2022-11-27 Thread GitBox
wwbmmm commented on PR #2019: URL: https://github.com/apache/incubator-brpc/pull/2019#issuecomment-1328444529 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #2009: Early return when size == 0

2022-11-27 Thread GitBox
wwbmmm commented on code in PR #2009: URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1033064042 ## src/butil/iobuf.cpp: ## @@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void (*deleter)(void*)) { LOG(FATAL) << "data_size

[incubator-brpc] branch master updated: Fix MacOS warning: bool literal returned from 'main' [-Wmain] (#2020)

2022-11-27 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 6faa88d2 Fix MacOS warning: bool literal

[GitHub] [incubator-brpc] wwbmmm merged pull request #2020: Fix MacOS warning: bool literal returned from 'main' [-Wmain]

2022-11-27 Thread GitBox
wwbmmm merged PR #2020: URL: https://github.com/apache/incubator-brpc/pull/2020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[GitHub] [incubator-brpc] 372046933 commented on a diff in pull request #2009: Early return when size == 0

2022-11-27 Thread GitBox
372046933 commented on code in PR #2009: URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1033061895 ## src/butil/iobuf.cpp: ## @@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void (*deleter)(void*)) { LOG(FATAL) << "data_s

[GitHub] [incubator-brpc] guodongxiaren opened a new pull request, #2023: Add Action Badge and Remove Travis file

2022-11-27 Thread GitBox
guodongxiaren opened a new pull request, #2023: URL: https://github.com/apache/incubator-brpc/pull/2023 ### What problem does this PR solve? Issue Number: #1963 #2018 Problem Summary: ### What is changed and the side effects? Changed: - 增加GitHub Action的Badge

[GitHub] [incubator-brpc] serverglen commented on pull request #2020: Fix MacOS warning: bool literal returned from 'main' [-Wmain]

2022-11-27 Thread GitBox
serverglen commented on PR #2020: URL: https://github.com/apache/incubator-brpc/pull/2020#issuecomment-1328413233 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #2009: Early return when size == 0

2022-11-27 Thread GitBox
zyearn commented on code in PR #2009: URL: https://github.com/apache/incubator-brpc/pull/2009#discussion_r1033001219 ## src/butil/iobuf.cpp: ## @@ -1211,6 +1211,9 @@ int IOBuf::append_user_data(void* data, size_t size, void (*deleter)(void*)) { LOG(FATAL) << "data_size

[GitHub] [incubator-brpc] zyearn opened a new issue, #2022: Fix clang compile warning for bazel

2022-11-27 Thread GitBox
zyearn opened a new issue, #2022: URL: https://github.com/apache/incubator-brpc/issues/2022 Detail: * https://github.com/apache/incubator-brpc/actions/runs/3557931214/jobs/5976258953 * https://github.com/apache/incubator-brpc/actions/runs/3557931214/jobs/5976259297 -- This is an au

[GitHub] [incubator-brpc] zyearn opened a new issue, #2021: Fix compile error for gcc-compile-with-bazel

2022-11-27 Thread GitBox
zyearn opened a new issue, #2021: URL: https://github.com/apache/incubator-brpc/issues/2021 Detail: https://github.com/apache/incubator-brpc/actions/runs/3557931214/jobs/5976259135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-brpc] zyearn opened a new pull request, #2020: Fix MacOS warning: bool literal returned from 'main' [-Wmain]

2022-11-27 Thread GitBox
zyearn opened a new pull request, #2020: URL: https://github.com/apache/incubator-brpc/pull/2020 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影

Oncall report from Nov 21st to Nov 27th

2022-11-27 Thread Jiashun Zhu
Hi, During the past week, there are 3 merged PRs: * Support all compile options and unittest for Linux workflow #2018 * remove unnecessary semicolon #2004 * Fix format issue of doc/cn/getting_

[GitHub] [incubator-brpc] zyearn commented on pull request #2018: Support all compile options and unittest for Linux workflow

2022-11-27 Thread GitBox
zyearn commented on PR #2018: URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328318544 以及github主页上的build link应该要改成指向Actions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-brpc] zyearn commented on pull request #2016: Support Unittest for Linux workflow

2022-11-27 Thread GitBox
zyearn commented on PR #2016: URL: https://github.com/apache/incubator-brpc/pull/2016#issuecomment-1328318321 这个PR还需要吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[incubator-brpc] branch master updated: Support all compile options and unittest for Linux workflow (#2018)

2022-11-27 Thread jiashunzhu
This is an automated email from the ASF dual-hosted git repository. jiashunzhu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 1936db9c Support all compile options

[GitHub] [incubator-brpc] zyearn merged pull request #2018: Support all compile options and unittest for Linux workflow

2022-11-27 Thread GitBox
zyearn merged PR #2018: URL: https://github.com/apache/incubator-brpc/pull/2018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[GitHub] [incubator-brpc] zyearn commented on pull request #2018: Support all compile options and unittest for Linux workflow

2022-11-27 Thread GitBox
zyearn commented on PR #2018: URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328318092 赞,之后提个PR把老的travis删掉应该就好了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #2018: Support all compile options and unittest for Linux workflow

2022-11-27 Thread GitBox
guodongxiaren commented on PR #2018: URL: https://github.com/apache/incubator-brpc/pull/2018#issuecomment-1328227202 @zyearn 修改了,有空看下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-brpc] ZeroLiu2018 closed pull request #1806: support channel option: health_check_path

2022-11-27 Thread GitBox
ZeroLiu2018 closed pull request #1806: support channel option: health_check_path URL: https://github.com/apache/incubator-brpc/pull/1806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c