[GitHub] [incubator-brpc] Tuvie commented on a diff in pull request #2005: allow IOBuf::append_user_data_with_meta to specify the lkey of rdma memory region

Tuvie commented on code in PR #2005: URL: https://github.com/apache/incubator-brpc/pull/2005#discussion_r1029985331 ## src/butil/iobuf.cpp: ## @@ -1206,7 +1211,14 @@ int IOBuf::appendv(const const_iovec* vec, size_t n) { return 0; } -int IOBuf::append_user_data(void*

[GitHub] [incubator-brpc] Tuvie commented on a diff in pull request #2005: allow IOBuf::append_user_data_with_meta to specify the lkey of rdma memory region

Tuvie commented on code in PR #2005: URL: https://github.com/apache/incubator-brpc/pull/2005#discussion_r1028788588 ## src/butil/iobuf.cpp: ## @@ -1219,11 +1227,23 @@ int IOBuf::append_user_data(void* data, size_t size, void (*deleter)(void*)) { deleter = ::free;

[GitHub] [incubator-brpc] Tuvie commented on a diff in pull request #2005: allow IOBuf::append_user_data_with_meta to specify the lkey of rdma memory region

Tuvie commented on code in PR #2005: URL: https://github.com/apache/incubator-brpc/pull/2005#discussion_r1028788462 ## test/brpc_rdma_unittest.cpp: ## @@ -80,6 +80,7 @@ extern bool g_skip_rdma_init; } } +static const size_t MAX_USER_MRS = 16; Review Comment: should