[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-11 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r274728305 ## File path: src/brpc/load_balancer.h ## @@ -24,6 +24,8 @@ #include "brpc/shared_object.h"

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-10 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273807484 ## File path: src/brpc/load_balancer.h ## @@ -179,6 +184,16 @@ inline Extension*

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-10 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273807198 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,119 @@

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-09 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273790313 ## File path: src/brpc/policy/consistent_hashing_load_balancer.h ## @@ -56,14 +54,28 @@ class

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-09 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273760132 ## File path: src/brpc/policy/consistent_hashing_load_balancer.h ## @@ -56,14 +54,28 @@ class

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-08 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272966493 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,111 @@

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272431987 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,111 @@

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272430577 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272430603 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public