yanglimingcn merged PR #2737:
URL: https://github.com/apache/brpc/pull/2737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.
chenBright commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2367124060
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
yanglimingcn commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2367097259
这个PR还有别的问题吗 @chenBright
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1744808688
##
src/brpc/builtin/memory_service.cpp:
##
@@ -58,6 +59,15 @@ static void get_tcmalloc_memory_info(butil::IOBuf& out) {
os.move_to(out);
}
+static void get_jema
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1744808688
##
src/brpc/builtin/memory_service.cpp:
##
@@ -58,6 +59,15 @@ static void get_tcmalloc_memory_info(butil::IOBuf& out) {
os.move_to(out);
}
+static void get_jema
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1744760692
##
src/brpc/builtin/memory_service.cpp:
##
@@ -58,6 +59,15 @@ static void get_tcmalloc_memory_info(butil::IOBuf& out) {
os.move_to(out);
}
+static void get_jema
GreateCode commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2323803247
>
在[MemoryService](https://github.com/apache/brpc/blob/master/src/brpc/builtin/memory_service.cpp#L61-L78)也支持一下jemalloc
stats？
done
--
This is an automated message from the Apac
chenBright commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2323662220
在[MemoryService](https://github.com/apache/brpc/blob/master/src/brpc/builtin/memory_service.cpp#L61-L78)也支持一下jemalloc
stats？
--
This is an automated message from the Apache Git Service
GreateCode commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2322865921
@wwbmmm @yanglimingcn @chenBright 接口新增了jemalloc stats信息，帮助查看memory细节如
各arena，metadata等，麻烦看下还有问题吗？谢谢~
https://github.com/user-attachments/assets/f1d76f97-5820-48d9-ac2f-45f04886e7d4";>
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1739699067
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736655448
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736642295
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736642295
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736507246
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736527722
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736507246
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736471882
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736471882
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736362684
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736348931
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736339795
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736075671
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1736068717
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2317430500
> > 可以集成到内置服务heap页面吗？
>
> 尝试了，放弃了。。 你帮忙改下？
那后面再看看怎么支持吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
GreateCode commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2311767165
> 可以集成到内置服务heap页面吗？
尝试了，放弃了。。
你帮忙改下？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1732289243
##
docs/cn/heap_profiler.md:
##
@@ -107,3 +107,34 @@ brpc还提供一个类似的growth profiler分析内存的分配去向（不考
1. 安装[standalone
pprof](https://github.com/google/pprof)，并把下载的pprof二进制文
GreateCode commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1732285273
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1732220875
##
docs/cn/heap_profiler.md:
##
@@ -107,3 +107,34 @@ brpc还提供一个类似的growth profiler分析内存的分配去向（不考
1. 安装[standalone
pprof](https://github.com/google/pprof)，并把下载的pprof二进制文
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1718535889
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on code in PR #2737:
URL: https://github.com/apache/brpc/pull/2737#discussion_r1718535889
##
src/brpc/details/jemalloc_profiler.cpp:
##
@@ -0,0 +1,289 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
chenBright commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2311672748
可以集成到内置服务heap页面吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wwbmmm commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2309180938
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
GreateCode commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2303563862
补充下，用静态方式链接jemalloc，进程加载其他so库比如dlopen("/xxx/libjvm.so",
xx)申请的内存，可能不会被profiler采样到。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yanglimingcn commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2303551884
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
GreateCode commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2303538640
> bazel编译，也是动态链接libjemalloc.so库吗
不强制，和编译方式无关，只需profiler时能找到mallctl即可。
所以静态链接jemalloc时，不用LD_PRELOAD=/xxx/lib/libjemalloc.so，直接MALLOC_CONF="prof:true"
bin/xxx。
--
This is an au
yanglimingcn commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2303519050
bazel编译，也是动态链接libjemalloc.so库吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
GreateCode commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2300412120
> 感谢贡献！ 能否顺便更新一下使用文档？
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
GreateCode commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2297824620
好的，我近期更新下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
wwbmmm commented on PR #2737:
URL: https://github.com/apache/brpc/pull/2737#issuecomment-2296183777
感谢贡献！
能否顺便更新一下使用文档？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
39 matches
Mail list logo
