[GitHub] [incubator-brpc] zyearn commented on issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
zyearn commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-479346126 这个你要看grpc的文档了 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] yjhjstz commented on issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
yjhjstz commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-479340643 server端是 grpc 服务,怎么改动windowsize? This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-brpc] zyearn commented on issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
zyearn commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-479333074 原因:目前brpc client的h2setting是和req一起发过去的,这时用的是默认大小,如果超过这个值,就发不出去,那么client的h2setting也发不出去,server端的h2setting也不会回复给client,server端的window size就不能传到client workaroun

[GitHub] [incubator-brpc] miniframework opened a new issue #716: Socket::Address 求教

2019-04-02 Thread GitBox
miniframework opened a new issue #716: Socket::Address 求教 URL: https://github.com/apache/incubator-brpc/issues/716 hi 能解释一下Address 里面的version ABA,version +1, version +2, version -1 的场景和为什么,设计原理?,这确实没看懂 尤其 if (nref > 1),if ((ver2 & 1)) if (ver1 == ver2 || ver1 + 1 == ver2) )

[GitHub] [incubator-brpc] yjhjstz commented on issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
yjhjstz commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-479309302 @zyearn This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-brpc] yjhjstz opened a new issue #715: http2 / grpc问题

2019-04-02 Thread GitBox
yjhjstz opened a new issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715 **Describe the bug (描述bug)** [E2004]remote_window_left is not enough, data_size=629370 [R1][E2004]remote_window_left is not enough, data_size=629370 **To Reproduce (复现方法)**

[GitHub] [incubator-brpc] haolujun edited a comment on issue #714: 如何使用channel?

2019-04-02 Thread GitBox
haolujun edited a comment on issue #714: 如何使用channel? URL: https://github.com/apache/incubator-brpc/issues/714#issuecomment-478920017 HI: 大神,我刚刚看了一下以往的issue,发现了这个,https://github.com/apache/incubator-brpc/issues/454 ,我应该是和这里面一样的问题。已经知道怎么解决了,多谢!!! ---

[GitHub] [incubator-brpc] haolujun commented on issue #714: 如何使用channel?

2019-04-02 Thread GitBox
haolujun commented on issue #714: 如何使用channel? URL: https://github.com/apache/incubator-brpc/issues/714#issuecomment-478920017 HI: 大神,我刚刚看了一下以往的issue,发现了这个,https://github.com/apache/incubator-brpc/issues/454,我应该是和这里面一样的问题。已经知道怎么解决了,多谢!!!

[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478917275 BTW: I add another file named Disclaimer, when I update the diff, it is merged automatically. --

[GitHub] [incubator-brpc] jamesge commented on issue #714: 如何使用channel?

2019-04-02 Thread GitBox
jamesge commented on issue #714: 如何使用channel? URL: https://github.com/apache/incubator-brpc/issues/714#issuecomment-478916248 举个例子具体描述一下你提到的"混乱"吧,包括协议、连接方式、版本等重要信息。 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] jamesge commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
jamesge commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478915447 ok,保持一致吧 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478900416 名字叫NOTICE,这是需要的,至于有的叫NOTICE.txt,有的叫NOTICE,都可以。 要不我改成NOTICE? This is a

[GitHub] [incubator-brpc] haolujun opened a new issue #714: 如何使用channel?

2019-04-02 Thread GitBox
haolujun opened a new issue #714: 如何使用channel? URL: https://github.com/apache/incubator-brpc/issues/714 HI : 当我并发请求同一个IP和端口后,结果经常会混乱。我每次请求都是用不同的channel。请问一下大神,我如何才能保证两次请求的结果不混乱呢?需要用connection_group? 那么connection_group需要做一个全局唯一哈希么?现在我侧测试结果是,只要connection_group相同,那么结果就会混乱。求大神给一个解决方案。

[GitHub] [incubator-brpc] jamesge commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
jamesge commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478894079 Thanks for the explanation, however the first question remains: why there's an additional ".txt" extension to "NOTICE"

[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright

2019-04-02 Thread GitBox
tanzhongyibidu commented on issue #710: add NOTICE.txt to address copyright URL: https://github.com/apache/incubator-brpc/pull/710#issuecomment-478887075 Hi, gejun, Let me explain it in more details: 1. The LICENSE file located under the root of repo, should mention its