[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-04 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-480142246 多次的交互如果对用户屏蔽,就需要像权限校验那样,在parseResponse的地方做多次的处理,我觉得这样可行。这样用户操作应该挺简洁的。而且single估计也可以了呢。 但是prepared

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272431987 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,111 @@

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272430577 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272430603 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-04 Thread GitBox
jamesge edited a comment on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-480129822 > @jamesge 最近在考虑prepared statement 和 transaction的实现问题。这两个功能的特点是,需要在一个连接上面进行多次回话,在多次回话过程中连接需要独占。 >

[GitHub] [incubator-brpc] jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-04 Thread GitBox
jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-480129822 > @jamesge 最近在考虑prepared statement 和 transaction的实现问题。这两个功能的特点是,需要在一个连接上面进行多次回话,在多次回话过程中连接需要独占。 >

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272426700 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272427635 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,111 @@

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-04 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-480111084 @jamesge 最近在考虑prepared statement 和 transaction的实现问题。这两个功能的特点是,需要在一个连接上面进行多次回话,在多次回话过程中连接需要独占。

[GitHub] [incubator-brpc] yjhjstz commented on issue #715: http2 / grpc问题

2019-04-04 Thread GitBox
yjhjstz commented on issue #715: http2 / grpc问题 URL: https://github.com/apache/incubator-brpc/issues/715#issuecomment-480106186 有更优雅的方式吗? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
jamesge commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272216066 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,111 @@

[GitHub] [incubator-brpc] cdjingit commented on issue #465: Brpc couchbase

2019-04-04 Thread GitBox
cdjingit commented on issue #465: Brpc couchbase URL: https://github.com/apache/incubator-brpc/pull/465#issuecomment-479864006 这个已经开发完成了 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] Xavier1994 closed issue #704: [grpc-java-client] grpc java client call brpc server get INTERNAL: HTTP/2 error code: FLOW_CONTROL_ERROR

2019-04-04 Thread GitBox
Xavier1994 closed issue #704: [grpc-java-client] grpc java client call brpc server get INTERNAL: HTTP/2 error code: FLOW_CONTROL_ERROR URL: https://github.com/apache/incubator-brpc/issues/704 This is an automated message