[GitHub] [incubator-brpc] jamesge merged pull request #724: fix missing array

2019-04-11 Thread GitBox
jamesge merged pull request #724: fix missing array URL: https://github.com/apache/incubator-brpc/pull/724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[incubator-brpc] branch master updated: fix missing array

2019-04-11 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 67dec96 fix missing array new 796

[GitHub] [incubator-brpc] zyearn opened a new pull request #724: fix missing array

2019-04-11 Thread GitBox
zyearn opened a new pull request #724: fix missing array URL: https://github.com/apache/incubator-brpc/pull/724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] zyearn commented on issue #592: lb configurable && consistency hash lb refactor

2019-04-11 Thread GitBox
zyearn commented on issue #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#issuecomment-482458608 fixed in https://github.com/apache/incubator-brpc/pull/724 This is a

[GitHub] [incubator-brpc] wenweihu86 commented on issue #592: lb configurable && consistency hash lb refactor

2019-04-11 Thread GitBox
wenweihu86 commented on issue #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#issuecomment-482458022 同样编译不过了。 clang version 7.0.1 (tags/RELEASE_701/final) Target: x86_64-apple-darwin17.3.0 Thread model: posix Installed

[GitHub] [incubator-brpc] yanglimingcn commented on issue #592: lb configurable && consistency hash lb refactor

2019-04-11 Thread GitBox
yanglimingcn commented on issue #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#issuecomment-482452012 这个版本在MacOS 10.14.4 (18E226) 版本编译报错 /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/include/libkern/OSAtomicDep

[GitHub] [incubator-brpc] jamesge commented on issue #697: 客户端出现大量timeout

2019-04-11 Thread GitBox
jamesge commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-482433253 建议直接用rpc的接口,半同步方式,不要每个rpc占用一个bthread。 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #723: fix build scripts under mac os env and add building section for README

2019-04-11 Thread GitBox
zyearn commented on a change in pull request #723: fix build scripts under mac os env and add building section for README URL: https://github.com/apache/incubator-brpc/pull/723#discussion_r274756495 ## File path: config_brpc.sh ## @@ -138,7 +138,12 @@ find_dir_of_header_o

[GitHub] [incubator-brpc] jamesge commented on issue #723: fix build scripts under mac os env and add building section for README

2019-04-11 Thread GitBox
jamesge commented on issue #723: fix build scripts under mac os env and add building section for README URL: https://github.com/apache/incubator-brpc/pull/723#issuecomment-482432959 这种差异都是不同版本间的差异,再怎么改都不通用。 This is an automa

[GitHub] [incubator-brpc] zyearn edited a comment on issue #720: 关于volatile关键字

2019-04-11 Thread GitBox
zyearn edited a comment on issue #720: 关于volatile关键字 URL: https://github.com/apache/incubator-brpc/issues/720#issuecomment-482427993 一些补充:如果想知道为什么会被硬件修改RAM,看一下 https://en.wikipedia.org/wiki/Memory-mapped_I/O This is an automat

[GitHub] [incubator-brpc] wenweihu86 commented on a change in pull request #723: fix build scripts under mac os env and add building section for README

2019-04-11 Thread GitBox
wenweihu86 commented on a change in pull request #723: fix build scripts under mac os env and add building section for README URL: https://github.com/apache/incubator-brpc/pull/723#discussion_r274752102 ## File path: config_brpc.sh ## @@ -138,7 +138,12 @@ find_dir_of_head

[GitHub] [incubator-brpc] zyearn commented on issue #720: 关于volatile关键字

2019-04-11 Thread GitBox
zyearn commented on issue #720: 关于volatile关键字 URL: https://github.com/apache/incubator-brpc/issues/720#issuecomment-482427993 一些补充:如果想知道为什么会被硬件修改RAM,看一下 https://en.wikipedia.org/wiki/Memory-mapped_I/O。 This is an automated mes

[GitHub] [incubator-brpc] wenweihu86 commented on a change in pull request #723: fix build scripts under mac os env and add building section for README

2019-04-11 Thread GitBox
wenweihu86 commented on a change in pull request #723: fix build scripts under mac os env and add building section for README URL: https://github.com/apache/incubator-brpc/pull/723#discussion_r274752102 ## File path: config_brpc.sh ## @@ -138,7 +138,12 @@ find_dir_of_head

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #723: fix build scripts under mac os env and add building section for README

2019-04-11 Thread GitBox
zyearn commented on a change in pull request #723: fix build scripts under mac os env and add building section for README URL: https://github.com/apache/incubator-brpc/pull/723#discussion_r274748285 ## File path: config_brpc.sh ## @@ -138,7 +138,12 @@ find_dir_of_header_o

[GitHub] [incubator-brpc] skilxnTL commented on issue #720: 关于volatile关键字

2019-04-11 Thread GitBox
skilxnTL commented on issue #720: 关于volatile关键字 URL: https://github.com/apache/incubator-brpc/issues/720#issuecomment-482418992 基本可以归纳为:只在硬件编程中有用。 一个地址的值可能被程序以外的环境修改的场景下,这个关键词才有用处。 This is an automated message from the Apac

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-11 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r274744617 ## File path: src/brpc/load_balancer.h ## @@ -24,6 +24,8 @@ #include "brpc/shared_object.h"

[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #723: fix build env and add building section for README

2019-04-11 Thread GitBox
tanzhongyibidu commented on issue #723: fix build env and add building section for README URL: https://github.com/apache/incubator-brpc/pull/723#issuecomment-482417387 If the patch is to fix build problem on mac only, you need to clarify it on the commit log, thanks --

[GitHub] [incubator-brpc] wenweihu86 opened a new pull request #723: fix build env and add building section for README

2019-04-11 Thread GitBox
wenweihu86 opened a new pull request #723: fix build env and add building section for README URL: https://github.com/apache/incubator-brpc/pull/723 1. fix build scripts. 2. add "how to build" section to README This is an a

[GitHub] [incubator-brpc] cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-11 Thread GitBox
cdjingit commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r274728305 ## File path: src/brpc/load_balancer.h ## @@ -24,6 +24,8 @@ #include "brpc/shared_object.h"

[GitHub] [incubator-brpc] yanglimingcn edited a comment on issue #722: Mysql transaction

2019-04-11 Thread GitBox
yanglimingcn edited a comment on issue #722: Mysql transaction URL: https://github.com/apache/incubator-brpc/pull/722#issuecomment-482073540 https://github.com/yanglimingcn/brpc/commit/56e76f49e6f73d3eb1785b3494f317bb1d3900d5 @jamesge 麻烦帮我评审一下,这次提交,把pipeline的方式换成correlation_id,是不是更合理些?

[GitHub] [incubator-brpc] yanglimingcn commented on issue #722: Mysql transaction

2019-04-11 Thread GitBox
yanglimingcn commented on issue #722: Mysql transaction URL: https://github.com/apache/incubator-brpc/pull/722#issuecomment-482073540 https://github.com/yanglimingcn/brpc/commit/56e76f49e6f73d3eb1785b3494f317bb1d3900d5 @jamesge 麻烦帮我评审一下,这次提交,把pipeline的方式换成correlation_id,是不是更合理些? 这里是通

[GitHub] [incubator-brpc] yanglimingcn opened a new pull request #722: Mysql transaction

2019-04-11 Thread GitBox
yanglimingcn opened a new pull request #722: Mysql transaction URL: https://github.com/apache/incubator-brpc/pull/722 添加mysql的事务功能。 issue #209 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-brpc] cuisonghui commented on issue #697: 客户端出现大量timeout

2019-04-11 Thread GitBox
cuisonghui commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-482028275 没有设置最大并发度,之前也想设置,但是对应的不知道bthread_worker_count应该设置多少. 因为我们的系统是这样的,此服务需要向后端节点(比如说10个后端节点)发送请求,那么就会从我们自己的线程池中取10个thread并发请求后端节点,整体都是同步等待的过程,根据我的理解,这样的话可能一次请求就需要