[GitHub] [incubator-brpc] jasonszang edited a comment on issue #725: 有没有全面支持c++11的计划

2019-04-15 Thread GitBox
jasonszang edited a comment on issue #725: 有没有全面支持c++11的计划 URL: https://github.com/apache/incubator-brpc/issues/725#issuecomment-483496854 I'm currently working on a PR that would address both your issues but I'm afraid it will take some time. BTW, I do not know whether the brpc maintain

[GitHub] [incubator-brpc] jasonszang edited a comment on issue #725: 有没有全面支持c++11的计划

2019-04-15 Thread GitBox
jasonszang edited a comment on issue #725: 有没有全面支持c++11的计划 URL: https://github.com/apache/incubator-brpc/issues/725#issuecomment-483496854 I'm currently working on a PR that would cover both your issues but I'm afraid it will take some time. BTW, I do not know whether the brpc maintainer

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #717: Revive from all server failed

2019-04-15 Thread GitBox
jamesge commented on a change in pull request #717: Revive from all server failed URL: https://github.com/apache/incubator-brpc/pull/717#discussion_r275634715 ## File path: src/butil/string_splitter.h ## @@ -159,6 +160,82 @@ class StringMultiSplitter { const EmptyFiel

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #717: Revive from all server failed

2019-04-15 Thread GitBox
jamesge commented on a change in pull request #717: Revive from all server failed URL: https://github.com/apache/incubator-brpc/pull/717#discussion_r275634250 ## File path: src/brpc/cluster_recover_policy.h ## @@ -0,0 +1,85 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Li

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #717: Revive from all server failed

2019-04-15 Thread GitBox
jamesge commented on a change in pull request #717: Revive from all server failed URL: https://github.com/apache/incubator-brpc/pull/717#discussion_r275636157 ## File path: src/butil/string_splitter.h ## @@ -159,6 +160,82 @@ class StringMultiSplitter { const EmptyFiel

[GitHub] [incubator-brpc] miniframework opened a new issue #730: bthread_id 和 mutex_id bthread_id.cpp bthread_mutex.cpp

2019-04-15 Thread GitBox
miniframework opened a new issue #730: bthread_id 和 mutex_id bthread_id.cpp bthread_mutex.cpp URL: https://github.com/apache/incubator-brpc/issues/730 感觉实现没啥区别,为啥弄一各bthread_id 出来呢? 唯一区别就是多各join This is an automated

[GitHub] [incubator-brpc] jasonszang commented on issue #725: 有没有全面支持c++11的计划

2019-04-15 Thread GitBox
jasonszang commented on issue #725: 有没有全面支持c++11的计划 URL: https://github.com/apache/incubator-brpc/issues/725#issuecomment-483496854 I'm currently working on a PR that would cover both your issues but I'm afraid it will take some time. I do not know whether the brpc maintainers have other

[GitHub] [incubator-brpc] jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-04-15 Thread GitBox
jamesge commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-483131174 单测都挂掉了。 This is an automated message from t