[GitHub] [incubator-brpc] zyearn opened a new pull request #775: Fix typo in gflags version

2019-05-20 Thread GitBox
zyearn opened a new pull request #775: Fix typo in gflags version URL: https://github.com/apache/incubator-brpc/pull/775 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-brpc] FearedHeart commented on issue #468: brpc的跨域支持怎么设置呢?

2019-05-20 Thread GitBox
FearedHeart commented on issue #468: brpc的跨域支持怎么设置呢? URL: https://github.com/apache/incubator-brpc/issues/468#issuecomment-493966838 在返回请求之前,设置response的header,对于跨域请求主要是下面3个。详细参见:https://developer.mozilla.org/zh-CN/docs/Web/HTTP/Access_control_CORS ```

[GitHub] [incubator-brpc] jasonszang commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jasonszang commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#issuecomment-493939291 @jamesge Hi Ge, thanks a lot for your review. I'll consider and fix these issues except the

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285535562 ## File path: src/bthread/bthread.h ## @@ -26,7 +26,7 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285531728 ## File path: src/bthread/bthreadxx.h ## @@ -0,0 +1,284 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285530381 ## File path: docs/cn/bthread_or_not.md ## @@ -50,6 +50,19

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285531320 ## File path: src/bthread/bthreadxx.h ## @@ -0,0 +1,284 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285529883 ## File path: src/bthread/bthread.h ## @@ -26,7 +26,7 @@

[GitHub] [incubator-brpc] bidai541 removed a comment on issue #774: How to accepted files sent from http post ?

2019-05-20 Thread GitBox
bidai541 removed a comment on issue #774: How to accepted files sent from http post ? URL: https://github.com/apache/incubator-brpc/issues/774#issuecomment-493864108 @jamesge Thank you for answering. But how to convert request attachment into a [key,value] pair similar to the

[GitHub] [incubator-brpc] yanglimingcn commented on issue #760: Mysql Prepared Statement support

2019-05-20 Thread GitBox
yanglimingcn commented on issue #760: Mysql Prepared Statement support URL: https://github.com/apache/incubator-brpc/pull/760#issuecomment-493910525 #722 #692 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] yanglimingcn commented on issue #722: Mysql transaction

2019-05-20 Thread GitBox
yanglimingcn commented on issue #722: Mysql transaction URL: https://github.com/apache/incubator-brpc/pull/722#issuecomment-493910319 #760 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-brpc] yanglimingcn commented on issue #760: Mysql Prepared Statement support

2019-05-20 Thread GitBox
yanglimingcn commented on issue #760: Mysql Prepared Statement support URL: https://github.com/apache/incubator-brpc/pull/760#issuecomment-493889516 添加了mysql的prepared statement协议的支持。 目前遇到两个问题无法解决 1、prepared statement首先是在某个连接上创建一个statement id,后续操作可以根据这个statement

[incubator-brpc] branch master updated: Add recordio_unittest.cpp into test/CMakeLists.txt and test/BUILD

2019-05-20 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 751b369 Add recordio_unittest.cpp

[GitHub] [incubator-brpc] bidai541 commented on issue #774: How to accepted files sent from http post ?

2019-05-20 Thread GitBox
bidai541 commented on issue #774: How to accepted files sent from http post ? URL: https://github.com/apache/incubator-brpc/issues/774#issuecomment-493864108 @jamesge Thank you for answering. But how to convert request attachment into a [key,value] pair similar to the previous one

[incubator-brpc] branch master updated: Add recordio.cc into CMakeLists.txt and BUILD

2019-05-20 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new e06c67c Add recordio.cc into