[incubator-brpc] branch master updated: Fix run_tests.sh

This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 72f3f4d Fix run_tests.sh new 71e2

[incubator-brpc] branch master updated: Fix make issue in mac

This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new cf9f1f8 Fix make issue in mac new

[GitHub] [incubator-brpc] jamesge merged pull request #789: Fix make issue in mac

jamesge merged pull request #789: Fix make issue in mac URL: https://github.com/apache/incubator-brpc/pull/789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-brpc] zyearn opened a new pull request #789: Fix make issue in mac

zyearn opened a new pull request #789: Fix make issue in mac URL: https://github.com/apache/incubator-brpc/pull/789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[incubator-brpc] branch master updated: Fix UT linked with SO

This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new fe11661 Fix UT linked with SO fe11661

[GitHub] [incubator-brpc] loadrunit commented on issue #788: /proc/self/io report :Permission denied

loadrunit commented on issue #788: /proc/self/io report :Permission denied URL: https://github.com/apache/incubator-brpc/issues/788#issuecomment-497190404 我直接将输出警告的那一行注释掉了：） This is an automated message from the Apache Git Ser

[GitHub] [incubator-brpc] jamesge commented on issue #788: /proc/self/io report :Permission denied

jamesge commented on issue #788: /proc/self/io report :Permission denied URL: https://github.com/apache/incubator-brpc/issues/788#issuecomment-497189684 这个看起来可能和你启动程序的方法有关，使得程序的权限不够 This is an automated message from the Apache

[GitHub] [incubator-brpc] jamesge commented on issue #786: 单客户端对单sever发压无法压满qps

jamesge commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-497187803 单连接下，client连一个server只有一个连接，可能达到单个连接的极限了 This is an automated message from the Apache Git Ser

[GitHub] [incubator-brpc] loadrunit opened a new issue #788: /proc/self/io report :Permission denied

loadrunit opened a new issue #788: /proc/self/io report :Permission denied URL: https://github.com/apache/incubator-brpc/issues/788 **Describe the bug (描述bug)** brpc 警告 /brpc-0.9.5/src/bvar/default_variables.cpp:431] Fail to open /proc/self/io: Permission denied 但是cat /proc/self/io

[GitHub] [incubator-brpc] skilxnTL commented on issue #785: 单客户端对单sever发压无法压满qps

skilxnTL commented on issue #785: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/785#issuecomment-497177915 github 卡住导致重复发起的 issue This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-brpc] skilxnTL closed issue #785: 单客户端对单sever发压无法压满qps

skilxnTL closed issue #785: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-497036995 Same error after rebasing, `./run_tests.sh: 22: ./run_tests.sh: [[: not found` Took a look around and

[GitHub] [incubator-brpc] jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496938856 Again travis doesn't look right. The error is about `run_tests.sh` not finding `[[`, which I did

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496938856 Again travis doesn't look right. The error is about `run_tests.sh` not finding `[[`, which I did not tou

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496938288 So I for now give up on these tests that relies on non-test objects built with specific cxxflags and ins

[GitHub] [incubator-brpc] skilxnTL commented on issue #786: 单客户端对单sever发压无法压满qps

skilxnTL commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-496925016 但是增加客户端是可以提升server端qps的 This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-brpc] kevinmgyu commented on issue #779: brpc 是否支持 访问tcp server的tcp client，如何实现兼容到框架中去

kevinmgyu commented on issue #779: brpc 是否支持 访问tcp server的tcp client，如何实现兼容到框架中去 URL: https://github.com/apache/incubator-brpc/issues/779#issuecomment-496918845 up This is an automated message from the Apache Git Service. To r

[GitHub] [incubator-brpc] skilxnTL commented on issue #786: 单客户端对单sever发压无法压满qps

skilxnTL commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-496905386 我试过增加 Client 端线程数，最后上限大概就是 50w qps，再增加线程数 Client 端 CPU 和 Qps 都不会有太大变化了 This is an automated

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

zyearn commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r288509691 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::Circu

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r288506093 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::C

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r288506093 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::C

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

zyearn commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r288497042 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::Circu

[GitHub] [incubator-brpc] xmm1989218 closed issue #780: 啥时候开源关于PROTOCOL_HADOOP_SERVER_RPC这个的实现

xmm1989218 closed issue #780: 啥时候开源关于PROTOCOL_HADOOP_SERVER_RPC这个的实现 URL: https://github.com/apache/incubator-brpc/issues/780 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-brpc] jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496851874 Then you need to make sure this relation of inclusion is always true by writing good codes and te

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496851874 Then you need to make sure this relation of inclusion is always true by writing good tests always. Might

[GitHub] [incubator-brpc] zyearn commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

zyearn commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496844520 The logic in UT and release is not strict different but has a relation of Inclusion. It means that if UT is

[GitHub] [incubator-brpc] scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器

scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-496832828 https://github.com/apache/incubator-brpc/blob/master/src/brpc/socket.cpp#L878 这一行直接调用了SetFailed，内部重新设置fd=-1, 理论上会执行到这一行https://github.com/apache/incubat

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496828743 If creating binaries that have different logic and behave differently for UT cannot be avoided then perh

[GitHub] [incubator-brpc] jamesge commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jamesge commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496821857 UT may turn on additional debugging macros to check consistencies and would like the release build being un

[GitHub] [incubator-brpc] jamesge commented on issue #787: brpc single模式下无法摘掉故障机器

jamesge commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-496820028 可以试验下[熔断](https://github.com/apache/incubator-brpc/blob/master/docs/cn/circuit_breaker.md) ---

[incubator-brpc] branch master updated: Link shared libbrpc in UTs built by the Makefile

This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 255a653 Link shared libbrpc in UTs bui

[GitHub] [incubator-brpc] scottzzq opened a new issue #787: brpc single模式下无法摘掉故障机器

scottzzq opened a new issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787 **Describe the bug (描述bug)** 使用brpc client访问下游服务，如果下游服务某台机器故障(模拟故障可以用iptables命令直接将目标ip数据包过滤掉)，这个时候brpc client仍然向故障机器发送请求，根本原因是brpc针对某个socket上出现的超时请求没有做额外的探测工作。如果是临时的出现的几次

[GitHub] [incubator-brpc] jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496818695 Ah, I see you require that some different cxxflags be used to compile non-test code for your unit

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496818695 Ah, I see you require that some different cxxflags be used to compile non-test code for your unit tests

[GitHub] [incubator-brpc] jamesge commented on issue #786: 单客户端对单sever发压无法压满qps

jamesge commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-496814947 可以尝试增加client端的线程数 This is an automated message from the Apache Git Service. To respond to th