[GitHub] [incubator-brpc] peiyuanzheng commented on issue #765: brpc支持Prometheus收集，没有label维度的信息，类型限定是gauge

peiyuanzheng commented on issue #765: brpc支持Prometheus收集，没有label维度的信息，类型限定是gauge URL: https://github.com/apache/incubator-brpc/issues/765#issuecomment-497916628 我们也遇到同样的问题，解决方法是在自己的应用代码中，把metrics name 和 label 拼接成bvar，然后提供一个给Prometheus查询的服务，解析bvar回metrics name 和label。 --

[GitHub] [incubator-brpc] peiyuanzheng commented on issue #786: 单客户端对单sever发压无法压满qps

peiyuanzheng commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-497914521 我之前遇到类似的情况，后来定位的原因如下： rpc_press代码中PressClient::get_output_message() 会用到DynamicMessageFactory，而DynamicMessageFactory::GetPrototype() 有锁。测试过程观察到client

Podling Report Reminder - June 2019

Dear podling, This email was sent by an automated system on behalf of the Apache Incubator PMC. It is an initial reminder to give you plenty of time to prepare your quarterly board report. The board meeting is scheduled for Wed, 19 June 2019, 10:30 am PDT. The report for your podling will form a

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r289370530 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::C

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r289370530 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::C

[GitHub] [incubator-brpc] scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器

scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-497676321 是的，看代码逻辑的确是这样的，我看注释WaitAndReset(2)的时候不是已经把健康检查持有的句柄算进去了吗？看_hc_count=0，从现象上来看，多出来的引用计数的确是被StartInputEvent里面的Address给占用了。 -

[GitHub] [incubator-brpc] zyearn opened a new issue #793: feature design: make parallel call sent to servers with the same tag

zyearn opened a new issue #793: feature design: make parallel call sent to servers with the same tag URL: https://github.com/apache/incubator-brpc/issues/793 Problem Description: There are some situations that we want to divide a big call into several small calls and send those smal

[GitHub] [incubator-brpc] jamesge commented on issue #787: brpc single模式下无法摘掉故障机器

jamesge commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-497661685 做健康检查也会address的，所以WaitAndReset之后引用超过2也是可能的（不过得通过AddressFailedAsWell） This is an automated

[GitHub] [incubator-brpc] jamesge commented on issue #787: brpc single模式下无法摘掉故障机器

jamesge commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-497661349 StartInputEvent里会先address一次，failed之后是address不到的，直接就退了，走不到L1933那里 This is an automated mess

[GitHub] [incubator-brpc] scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器

scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-497658901 通过上面我发的Socket的信息，发现_versioned_ref 分别是3、4294967299，这个数字和0xul这个做&运算，结果都是3，说明外部对Socket句柄的引用计数是3，这也就是说在WaitAndReset(2)之后，的确有其他线程对Socket做了一次新的引用。@james

[GitHub] [incubator-brpc] scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器

scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-497622466 https://github.com/apache/incubator-brpc/blob/master/src/brpc/socket.cpp#L693 能不能把这行挪到https://github.com/apache/incubator-brpc/blob/master/src/brpc/socke

[GitHub] [incubator-brpc] jamesge merged pull request #792: replace example/partition_echo_c++/server.cpp with that in dynamic_pa…

jamesge merged pull request #792: replace example/partition_echo_c++/server.cpp with that in dynamic_pa… URL: https://github.com/apache/incubator-brpc/pull/792 This is an automated message from the Apache Git Service. To res

[incubator-brpc] branch master updated: replace example/partition_echo_c++/server.cpp with that in dynamic_partition_echo_c++

This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 0bc9eaa replace example/partition_echo

[GitHub] [incubator-brpc] scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器

scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-497620200 我的关闭的策略和master中的熔断功能基本是一样的，都是调用SetFailed方法来做的，理论上如果启用了熔断功能也会有类似的问题的 @jamesge This is an

[GitHub] [incubator-brpc] scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器

scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-497619367 coredump的原因是这个是比较明确的，就是执行到L1933,最终调用了glog打印了FATAL日志导致的，现在看起来原因就是调用了socket的SetFailed方法，之后还能收到这个socket的可读事件，但是在StartInputEvent的时候其实发现fd被设置成-1了，我仔细看过SetFaile

[GitHub] [incubator-brpc] jamesge commented on issue #787: brpc single模式下无法摘掉故障机器

jamesge commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-497613339 我并不知道你提到的”简单粗暴的屏蔽策略“是怎么写的，C++有太多理由coredump，所以还是建议你自己先review下代码，看看是否有内存相关的bug。 This is an a

[GitHub] [incubator-brpc] zyearn opened a new pull request #792: replace example/partition_echo_c++/server.cpp with that in dynamic_pa…

zyearn opened a new pull request #792: replace example/partition_echo_c++/server.cpp with that in dynamic_pa… URL: https://github.com/apache/incubator-brpc/pull/792 …rtition_echo_c++ This is an automated message from the Apac