[GitHub] [incubator-brpc] jamesge commented on issue #796: bvar 中Adder是否存在上限

2019-06-04 Thread GitBox
jamesge commented on issue #796: bvar 中Adder是否存在上限 URL: https://github.com/apache/incubator-brpc/issues/796#issuecomment-498952781 上限有两种:一种是内存放不下了,这是不存在的,因为adder只会存累加后结果;另一种是overflow了,如果类型宽度太小,确实有这个可能,那就换一个更宽的类型。 This is an a

[GitHub] [incubator-brpc] skilxnTL commented on issue #786: 单客户端对单sever发压无法压满qps

2019-06-04 Thread GitBox
skilxnTL commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-498952404 谢谢,后续我有空试一下这个解法,再同步 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-brpc] yanglimingcn commented on issue #779: brpc 是否支持 访问tcp server的tcp client,如何实现兼容到框架中去

2019-06-04 Thread GitBox
yanglimingcn commented on issue #779: brpc 是否支持 访问tcp server的tcp client,如何实现兼容到框架中去 URL: https://github.com/apache/incubator-brpc/issues/779#issuecomment-498925372 我理解tcp的client和server通讯,总归需要定义一种通信的协议,所以如果现有的比较通用的协议都不是你想要的,你可以实现你的私有协议。另外用protobuf定义协议很方便啊 --

[GitHub] [incubator-brpc] chyxyjh opened a new issue #796: bvar 中Adder是否存在上限

2019-06-04 Thread GitBox
chyxyjh opened a new issue #796: bvar 中Adder是否存在上限 URL: https://github.com/apache/incubator-brpc/issues/796 想请教一下,如果用bvar中的Adder类型来监控请求量,我对外输出的是用PerSecond类型封装的每秒请求,但是这个每秒请求也是基于Adder类型的请求累计统计出来的,那么随着请求总量的不断累计,会不会造成Adder存储达到其上限呢?如果存在,我应如何解决,定时清理Adder中的存储值? 感谢支持 ---

[GitHub] [incubator-brpc] zyearn commented on issue #793: feature design: make parallel call sent to servers with the same tag

2019-06-04 Thread GitBox
zyearn commented on issue #793: feature design: make parallel call sent to servers with the same tag URL: https://github.com/apache/incubator-brpc/issues/793#issuecomment-498642766 There is no demand for this feature any more. ---

[GitHub] [incubator-brpc] zyearn closed issue #793: feature design: make parallel call sent to servers with the same tag

2019-06-04 Thread GitBox
zyearn closed issue #793: feature design: make parallel call sent to servers with the same tag URL: https://github.com/apache/incubator-brpc/issues/793 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-brpc] jamesge merged pull request #795: improve the way of running ut in cmake

2019-06-04 Thread GitBox
jamesge merged pull request #795: improve the way of running ut in cmake URL: https://github.com/apache/incubator-brpc/pull/795 This is an automated message from the Apache Git Service. To respond to the message, please log o

[incubator-brpc] branch master updated (54c28a3 -> 71af31e)

2019-06-04 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 54c28a3 Merge pull request #794 from zyearn/separate_cmake_debug_and_release_obj new 2f1595a improve

[GitHub] [incubator-brpc] jamesge commented on issue #787: brpc single模式下无法摘掉故障机器

2019-06-04 Thread GitBox
jamesge commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-498549708 这个不要紧,消息通知出现"假阳性"的后果只是白读了而已。 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-brpc] scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器

2019-06-04 Thread GitBox
scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-498549057 去掉的确不会core掉了,我还在确认下有没有其他副作用,比如能预料到的一个case就是,如果EventDistapch执行有延迟,如果刚好调用了ResetFileDescriptor之后,再调用StartInputEvent,这个时候时候fd就是合法的了,但是如果此时fd上并没有可读事件,仍然会触发一次In