[GitHub] [incubator-brpc] hongbshi commented on issue #905: centos 7.6 静态链接失败

2019-08-26 Thread GitBox
hongbshi commented on issue #905: centos 7.6 静态链接失败
URL: https://github.com/apache/incubator-brpc/issues/905#issuecomment-525142718
 
 
   > 编译自己的链接库加上brpc需要的leveldb gflags等就可以了
   
   编译自己的程序时,我已经加上了leveldb, gflags, protobuf, 不过都是静态库。必须改为动态库嘛?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] hnwyllmm commented on issue #905: centos 7.6 静态链接失败

2019-08-26 Thread GitBox
hnwyllmm commented on issue #905: centos 7.6 静态链接失败
URL: https://github.com/apache/incubator-brpc/issues/905#issuecomment-525141748
 
 
   编译自己的链接库加上brpc需要的leveldb  gflags等就可以了


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] lorinlee commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
lorinlee commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-525136887
 
 
   不过meta信息可能是有意义的,这个可以考虑都列一下


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] lorinlee commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
lorinlee commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-525127091
 
 
   > bthread_list中显示的数目和bthread_num的不一致
   > 
   > ```
   > (gdb) bthread_begin 
   > Active bthreads: 25, will display 25 bthreads
   > Enter bthread debug mode, do not switch thread before exec 'bthread_end' 
!!!
   > (gdb) bthread_list
   > id tid function total:5
   > #0 2675764627290   0x503a60 
   > #1 4294969344  0x511900 
   > #2 4294969345  0x4fa3f0 
   > #3 4294969346  0x4d71b0 
   > #4 2628519987470   0x6cd9d0 
   > (gdb) bthread_num
   > 25
   > ```
   
   
数量不一致也是符合预期的,目前计数依赖的是bvar,但扫bthread的时候对于stack是0x0的跳过了,因为之前认为这些堆栈信息没有意义,所以创建了bthread但是还没被调度执行(没有分配stack)的就不会显示在list里


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] lorinlee commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
lorinlee commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-525125993
 
 
   > ```
   > (gdb) bthread_meta
   > Python Exception  invalid literal for int() with base 
10: '': 
   > Error occurred in Python command: invalid literal for int() with base 10: 
''
   > ```
   
   bthread_meta 需要指定一个bthread id类似bthread_frame,比如bthread_meta 0,我完善一下报错信息


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] lorinlee commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
lorinlee commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-525125331
 
 
   > 目前这个脚本还会时不时报个内部错误,进而把attach的进程杀死,这样加到tools目录下的话万一被其他用户对线上进程使用,风险还是很高。
   
   好我先看看这些已知问题,兼容性的问题确实没想好,自己的环境用着是都没问题的,已经使用了一些时间,但是换个环境确实有些不兼容


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] jamesge commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
jamesge commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-525118852
 
 
   目前这个脚本还会时不时报个内部错误,进而把attach的进程杀死,这样加到tools目录下的话万一被其他用户对线上进程使用,风险还是很高。


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] jamesge commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
jamesge commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-525118553
 
 
   bthread_list中显示的数目和bthread_num的不一致
   ```
   (gdb) bthread_begin 
   Active bthreads: 25, will display 25 bthreads
   Enter bthread debug mode, do not switch thread before exec 'bthread_end' !!!
   (gdb) bthread_list
   id   tid function total:5
   #0   2675764627290   0x503a60 
   #1   4294969344  0x511900 
   #2   4294969345  0x4fa3f0 
   #3   4294969346  0x4d71b0 
   #4   2628519987470   0x6cd9d0 
   (gdb) bthread_num
   25
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] jamesge commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
jamesge commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-525117338
 
 
   ```
   (gdb) bthread_meta
   Python Exception  invalid literal for int() with base 
10: '': 
   Error occurred in Python command: invalid literal for int() with base 10: ''
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] lorinlee commented on issue #900: 如何在bthread_mutex_t死锁问题时查看bthread的堆栈

2019-08-26 Thread GitBox
lorinlee commented on issue #900: 如何在bthread_mutex_t死锁问题时查看bthread的堆栈
URL: https://github.com/apache/incubator-brpc/issues/900#issuecomment-524935696
 
 
   bthread_list的结果发一下我看看


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] lorinlee commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
lorinlee commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-524932096
 
 
   > 就是example/multi_threaded_echo_c++用Makefile编译后运行echo_server并按上述流程操作的结果。os: 
ubuntu 16.04,gcc: 5.4, gdb:7.11.1, python: 2.7.12
   
   感谢review,修复了,取类型的时候新版本的gdb报错了,加了个单引号好了


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] zyearn commented on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译

2019-08-26 Thread GitBox
zyearn commented on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译
URL: https://github.com/apache/incubator-brpc/issues/901#issuecomment-524837338
 
 
   
config_brpc.sh会搜索指定路径下的所有文件,而cmake只会搜索特定前缀,比如/usr/local/lib,要把so放在这下面,再检查下软链接对不对。cmake一般是向后兼容的,如果不是,也会有对应的warning


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] zyearn edited a comment on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译

2019-08-26 Thread GitBox
zyearn edited a comment on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 
方式编译
URL: https://github.com/apache/incubator-brpc/issues/901#issuecomment-524837338
 
 
   
config_brpc.sh会搜索指定路径下的所有文件,而cmake只会搜索特定前缀,比如/usr/local/lib,要把so放在这下面,再检查下软链接对不对。cmake一般是向后兼容的,如果不是,也会有对应的warning


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] chxj19 commented on issue #900: 如何在bthread_mutex_t死锁问题时查看bthread的堆栈

2019-08-26 Thread GitBox
chxj19 commented on issue #900: 如何在bthread_mutex_t死锁问题时查看bthread的堆栈
URL: https://github.com/apache/incubator-brpc/issues/900#issuecomment-524751456
 
 
   非常感谢,刚刚我试了一下,可以看到死锁bthread的堆栈信息了。
   但是有部分的bthread frame出现了如下的报错:
   
   ```
   (gdb) bthread_frame 4
   Python Exception  Cannot access memory at address 
0x8: 
   Error occurred in Python command: Cannot access memory at address 0x8
   (gdb) bt
   #0  0x00922b0b in jump_stack (to=, from=) at /root/incubator-brpc-0.9.5/src/bthread/stack_inl.h:129
   #1  bthread::TaskGroup::sched_to (pg=0x0, next_meta=0x7ffd67ea77f0) at 
/root/incubator-brpc-0.9.5/src/bthread/task_group.cpp:601
   (gdb) bthread_frame 5
   Python Exception  Cannot access memory at address 
0x8: 
   Error occurred in Python command: Cannot access memory at address 0x8
   (gdb) bt
   #0  0x00922b3f in bthread::TaskGroup::sched_to (pg=0x0, 
pg@entry=, 
next_meta=)
   at /root/incubator-brpc-0.9.5/src/bthread/task_group.cpp:626
   Cannot access memory at address 0x8
   ```
   看上去像是计算地址时出现了一点问题?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] NetWilliam commented on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译

2019-08-26 Thread GitBox
NetWilliam commented on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译
URL: https://github.com/apache/incubator-brpc/issues/901#issuecomment-524749767
 
 
   我cmake 的版本还挺新的
   cmake version 3.15.2
   
   不晓得是不是cmake 的脚本在不同系统上有细微区别导致的. 这边是centos


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] NetWilliam commented on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译

2019-08-26 Thread GitBox
NetWilliam commented on issue #901: 链接 libbrpc.so 的时候出现错误, 依赖的静态库需要使用 -fPIC 方式编译
URL: https://github.com/apache/incubator-brpc/issues/901#issuecomment-524748632
 
 
   > libbrpc.so依赖libgflags.so,libleveldb.so,libprotobuf.so,你看看自己系统里有没有
   
   有的, 我调试cmake的时候发现 寻找那个package的时候总是找到的是静态库, 不知道为什么.
   cmake 这种编译方式好像有问题走不通, 用那个 config_brpc.sh 才可以跑通


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] hanxuan123 commented on issue #897: NamingServiceThread::Actions::ResetServers 在设置SSL后失败的问题

2019-08-26 Thread GitBox
hanxuan123 commented on issue #897: NamingServiceThread::Actions::ResetServers 
在设置SSL后失败的问题
URL: https://github.com/apache/incubator-brpc/issues/897#issuecomment-524746257
 
 
   请问是怎么解决的额


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[incubator-brpc] branch master updated: Add instructions to remove CMakeCache.txt before re-running cmakes

2019-08-26 Thread jamesge
This is an automated email from the ASF dual-hosted git repository.

jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git


The following commit(s) were added to refs/heads/master by this push:
 new 7b95deb  Add instructions to remove CMakeCache.txt before re-running 
cmakes
7b95deb is described below

commit 7b95debc36613efdb661ba502556fb7d3cf236c2
Author: jamesge 
AuthorDate: Mon Aug 26 00:12:41 2019 -0700

Add instructions to remove CMakeCache.txt before re-running cmakes
---
 docs/cn/getting_started.md | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/docs/cn/getting_started.md b/docs/cn/getting_started.md
index 6c5410f..0f5a364 100644
--- a/docs/cn/getting_started.md
+++ b/docs/cn/getting_started.md
@@ -77,7 +77,7 @@ mkdir bld && cd bld && cmake .. && make
 ```
 To change compiler to clang, overwrite environment variable CC and CXX to 
clang and clang++.
 
-To not link debugging symbols, use `cmake -DWITH_DEBUG_SYMBOLS=OFF ..` and 
compiled binaries will be much smaller.
+To not link debugging symbols, use `rm -f CMakeCache.txt && cmake 
-DWITH_DEBUG_SYMBOLS=OFF ..` and compiled binaries will be much smaller.
 
 To use brpc with glog, add `-DWITH_GLOG=ON`.
 
@@ -90,7 +90,7 @@ $ mkdir bld && cd bld && cmake .. && make
 $ ./echo_server &
 $ ./echo_client
 ```
-Examples link brpc statically, if you need to link the shared version, use 
`cmake -DLINK_SO=ON ..`
+Examples link brpc statically, if you need to link the shared version, use `rm 
-f CMakeCache.txt && cmake -DLINK_SO=ON ..`
 
 **Run tests**
 ```shell
@@ -166,7 +166,7 @@ mkdir bld && cd bld && cmake .. && make
 ```
 To change compiler to clang, overwrite environment variable CC and CXX to 
clang and clang++.
 
-To not link debugging symbols, use `cmake -DWITH_DEBUG_SYMBOLS=OFF ..` and 
compiled binaries will be much smaller.
+To not link debugging symbols, use `rm -f CMakeCache.txt && cmake 
-DWITH_DEBUG_SYMBOLS=OFF ..` and compiled binaries will be much smaller.
 
 To use brpc with glog, add `-DWITH_GLOG=ON`.
 
@@ -180,7 +180,7 @@ $ mkdir bld && cd bld && cmake .. && make
 $ ./echo_server &
 $ ./echo_client
 ```
-Examples link brpc statically, if you need to link the shared version, use 
`cmake -DLINK_SO=ON ..`
+Examples link brpc statically, if you need to link the shared version, use `rm 
-f CMakeCache.txt && cmake -DLINK_SO=ON ..`
 
 **Run tests**
 ```shell
@@ -238,7 +238,7 @@ mkdir bld && cd bld && cmake 
-DCMAKE_INCLUDE_PATH="/path/to/dep1/include;/path/t
 
 To change compiler to clang, overwrite environment variable CC and CXX to 
clang and clang++.
 
-To not link debugging symbols, use `cmake -DWITH_DEBUG_SYMBOLS=OFF ..` and 
compiled binaries will be much smaller.
+To not link debugging symbols, use `rm -f CMakeCache.txt && cmake 
-DWITH_DEBUG_SYMBOLS=OFF ..` and compiled binaries will be much smaller.
 
 To use brpc with glog, add `-DWITH_GLOG=ON`.
 
@@ -305,7 +305,7 @@ $ sh run_tests.sh
 mkdir bld && cd bld && cmake .. && make
 ```
 
-To not link debugging symbols, use `cmake -DWITH_DEBUG_SYMBOLS=OFF ..` and 
compiled binaries will be much smaller.
+To not link debugging symbols, use `rm -f CMakeCache.txt && cmake 
-DWITH_DEBUG_SYMBOLS=OFF ..` and compiled binaries will be much smaller.
 
 To use brpc with glog, add `-DWITH_GLOG=ON`.
 
@@ -318,7 +318,7 @@ $ mkdir bld && cd bld && cmake .. && make
 $ ./echo_server &
 $ ./echo_client
 ```
-Examples link brpc statically, if you need to link the shared version, use 
`cmake -DLINK_SO=ON ..`
+Examples link brpc statically, if you need to link the shared version, use `rm 
-f CMakeCache.txt && cmake -DLINK_SO=ON ..`
 
 **Run tests**
 ```shell


-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[incubator-brpc] branch master updated: unify dynamic link option in make and cmake

2019-08-26 Thread jamesge
This is an automated email from the ASF dual-hosted git repository.

jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git


The following commit(s) were added to refs/heads/master by this push:
 new 1b90ea1  unify dynamic link option in make and cmake
 new 54025e4  Merge pull request #904 from zyearn/refine_cmake_example
1b90ea1 is described below

commit 1b90ea18d95ddaff5b1afd17eb1326a100cf7b33
Author: zhujiashun 
AuthorDate: Mon Aug 26 14:32:29 2019 +0800

unify dynamic link option in make and cmake
---
 docs/cn/getting_started.md   | 6 +++---
 example/asynchronous_echo_c++/CMakeLists.txt | 4 ++--
 example/auto_concurrency_limiter/CMakeLists.txt  | 4 ++--
 example/backup_request_c++/CMakeLists.txt| 4 ++--
 example/cancel_c++/CMakeLists.txt| 4 ++--
 example/cascade_echo_c++/CMakeLists.txt  | 4 ++--
 example/dynamic_partition_echo_c++/CMakeLists.txt| 4 ++--
 example/echo_c++/CMakeLists.txt  | 4 ++--
 example/echo_c++_hulu_pbrpc/CMakeLists.txt   | 4 ++--
 example/echo_c++_sofa_pbrpc/CMakeLists.txt   | 4 ++--
 example/echo_c++_ubrpc_compack/CMakeLists.txt| 4 ++--
 example/grpc_c++/CMakeLists.txt  | 4 ++--
 example/http_c++/CMakeLists.txt  | 4 ++--
 example/memcache_c++/CMakeLists.txt  | 4 ++--
 example/multi_threaded_echo_c++/CMakeLists.txt   | 4 ++--
 example/multi_threaded_echo_fns_c++/CMakeLists.txt   | 4 ++--
 example/multi_threaded_mcpack_c++/CMakeLists.txt | 4 ++--
 example/nshead_extension_c++/CMakeLists.txt  | 4 ++--
 example/nshead_pb_extension_c++/CMakeLists.txt   | 4 ++--
 example/parallel_echo_c++/CMakeLists.txt | 4 ++--
 example/partition_echo_c++/CMakeLists.txt| 4 ++--
 example/redis_c++/CMakeLists.txt | 4 ++--
 example/selective_echo_c++/CMakeLists.txt| 4 ++--
 example/session_data_and_thread_local/CMakeLists.txt | 4 ++--
 example/streaming_echo_c++/CMakeLists.txt| 4 ++--
 25 files changed, 51 insertions(+), 51 deletions(-)

diff --git a/docs/cn/getting_started.md b/docs/cn/getting_started.md
index 39cffc8..6c5410f 100644
--- a/docs/cn/getting_started.md
+++ b/docs/cn/getting_started.md
@@ -90,7 +90,7 @@ $ mkdir bld && cd bld && cmake .. && make
 $ ./echo_server &
 $ ./echo_client
 ```
-Examples link brpc statically, if you need to link the shared version, use 
`cmake -DEXAMPLE_LINK_SO=ON ..`
+Examples link brpc statically, if you need to link the shared version, use 
`cmake -DLINK_SO=ON ..`
 
 **Run tests**
 ```shell
@@ -180,7 +180,7 @@ $ mkdir bld && cd bld && cmake .. && make
 $ ./echo_server &
 $ ./echo_client
 ```
-Examples link brpc statically, if you need to link the shared version, use 
`cmake -DEXAMPLE_LINK_SO=ON ..`
+Examples link brpc statically, if you need to link the shared version, use 
`cmake -DLINK_SO=ON ..`
 
 **Run tests**
 ```shell
@@ -318,7 +318,7 @@ $ mkdir bld && cd bld && cmake .. && make
 $ ./echo_server &
 $ ./echo_client
 ```
-Examples link brpc statically, if you need to link the shared version, use 
`cmake -DEXAMPLE_LINK_SO=ON ..`
+Examples link brpc statically, if you need to link the shared version, use 
`cmake -DLINK_SO=ON ..`
 
 **Run tests**
 ```shell
diff --git a/example/asynchronous_echo_c++/CMakeLists.txt 
b/example/asynchronous_echo_c++/CMakeLists.txt
index 91c3953..c4408e4 100644
--- a/example/asynchronous_echo_c++/CMakeLists.txt
+++ b/example/asynchronous_echo_c++/CMakeLists.txt
@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 2.8.10)
 project(asynchronous_echo_c++ C CXX)
 
-option(EXAMPLE_LINK_SO "Whether examples are linked dynamically" OFF)
+option(LINK_SO "Whether examples are linked dynamically" OFF)
 
 execute_process(
 COMMAND bash -c "find ${PROJECT_SOURCE_DIR}/../.. -type d -regex 
\".*output/include$\" | head -n1 | xargs dirname | tr -d '\n'"
@@ -28,7 +28,7 @@ if (NOT THRIFTNB_LIB)
 endif()
 
 find_path(BRPC_INCLUDE_PATH NAMES brpc/server.h)
-if(EXAMPLE_LINK_SO)
+if(LINK_SO)
 find_library(BRPC_LIB NAMES brpc)
 else()
 find_library(BRPC_LIB NAMES libbrpc.a brpc)
diff --git a/example/auto_concurrency_limiter/CMakeLists.txt 
b/example/auto_concurrency_limiter/CMakeLists.txt
index 218f059..772093e 100644
--- a/example/auto_concurrency_limiter/CMakeLists.txt
+++ b/example/auto_concurrency_limiter/CMakeLists.txt
@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 2.8.10)
 project(asynchronous_echo_c++ C CXX)
 
-option(EXAMPLE_LINK_SO "Whether examples are linked dynamically" OFF)
+option(LINK_SO "Whether examples are linked dynamically" OFF)
 
 execute_process(
 COMMAND bash -c "find ${CMAKE_SOURCE_DIR}/../.. -type d -regex 
\".*output/include$\" | head -n1 | xargs dirname | tr -d '\n'"
@@ -17,7 +17,7 @@ protobuf_generate_cpp(PROTO_SRC PROTO_HEADER cl_test.proto)
 

[GitHub] [incubator-brpc] jamesge merged pull request #904: unify dynamic link option in make and cmake

2019-08-26 Thread GitBox
jamesge merged pull request #904: unify dynamic link option in make and cmake
URL: https://github.com/apache/incubator-brpc/pull/904
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] zyearn opened a new pull request #904: unify dynamic link option in make and cmake

2019-08-26 Thread GitBox
zyearn opened a new pull request #904: unify dynamic link option in make and 
cmake
URL: https://github.com/apache/incubator-brpc/pull/904
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] jamesge edited a comment on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
jamesge edited a comment on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-524727431
 
 
   就是example/multi_threaded_echo_c++用Makefile编译后运行echo_server并按上述流程操作的结果。os: 
ubuntu 16.04,gcc: 5.4, gdb:7.11.1, python: 2.7.12


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org



[GitHub] [incubator-brpc] jamesge commented on issue #903: tools: add gdb_bthread_stack.py

2019-08-26 Thread GitBox
jamesge commented on issue #903: tools: add gdb_bthread_stack.py
URL: https://github.com/apache/incubator-brpc/pull/903#issuecomment-524727431
 
 
   就是example/multi_threaded_echo_c++用Makefile编译后按上述流程操作的结果。os: ubuntu 
16.04,gcc: 5.4, gdb:7.11.1, python: 2.7.12


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org