Hi, lorin,
You don’t need to say sorry about this.
The pr has been approved by me ang merged.
Thanks
发件人: Lorin Lee
日期: 2021年9月2日 星期四 上午12:41
收件人: "dev@brpc.apache.org"
抄送: "zhongyi@gmail.com" , "642580...@qq.com"
<642580...@qq.com>
主题: Re: Oncall report from Aug 23rd to Aug 29th
Sorry,
tanzhongyi003 commented on pull request #1546:
URL: https://github.com/apache/incubator-brpc/pull/1546#issuecomment-910970852
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
tanzhongyi003 merged pull request #1546:
URL: https://github.com/apache/incubator-brpc/pull/1546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
jerrytan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 3d12367 community: update lorin's
Sorry, I have modified the oncall list just now, PTAL
https://github.com/apache/incubator-brpc/pull/1546/
I see Daojin has already taken over the oncall job, I will notify the
next person next time. cc Daojin Cai
tan zhongyi 于2021年9月1日周三 下午2:29写道：
> Thanks, Lorin,
> Have you modify the oncall
chenzhangyi commented on issue #1540:
URL: https://github.com/apache/incubator-brpc/issues/1540#issuecomment-910167014
用tcmalloc啥的看下吧，看起来多的就是和malloc相关的，就是pb3的实现里面多了一些内存分配。或者你看下更高版本的protobuf有没有解决这个问题
--
This is an automated message from the Apache Git Service.
To respond to the message,
xingdl2007 opened a new issue #1545:
URL: https://github.com/apache/incubator-brpc/issues/1545
rt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cdjingit commented on issue #1543:
URL: https://github.com/apache/incubator-brpc/issues/1543#issuecomment-910048273
是指没有brpc框架函数的调用关系吗？确定是有流量的？另外bin里的符号都保留了吗？有没有stripped掉？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
ijasonyi commented on pull request #1516:
URL: https://github.com/apache/incubator-brpc/pull/1516#issuecomment-909994530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
serverglen edited a comment on pull request #1483:
URL: https://github.com/apache/incubator-brpc/pull/1483#issuecomment-906898534
> Related issue: #1482
> 目前brpcz中只有method级别的eps(error_per_second)，本PR实现了server级别的eps。
> 其实server级别的eps对业务来说更为重要。
@lorinlee @zyearn @cdjingit
serverglen commented on pull request #1468:
URL: https://github.com/apache/incubator-brpc/pull/1468#issuecomment-909932353
@zyearn @lorinlee @cdjingit @TousakaRin 辛苦抽时间review下呗，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
serverglen commented on pull request #1461:
URL: https://github.com/apache/incubator-brpc/pull/1461#issuecomment-909931918
@zyearn @lorinlee @cdjingit @TousakaRin 辛苦帮review下呗，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijasonyi removed a comment on pull request #1516:
URL: https://github.com/apache/incubator-brpc/pull/1516#issuecomment-909994530
awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cdjingit commented on pull request #1474:
URL: https://github.com/apache/incubator-brpc/pull/1474#issuecomment-910026907
这个需要哪些定制需求呢？可以列一些场景吗？默认的tcp_listen()本身涉及一些校验逻辑和gflag，替换的话需要和tcp_listen()兼容
--
This is an automated message from the Apache Git Service.
To respond to the message,
serverglen commented on pull request #1474:
URL: https://github.com/apache/incubator-brpc/pull/1474#issuecomment-909932867
@zyearn @lorinlee @cdjingit @TousakaRin 辛苦抽时间review下呗，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lorinlee merged pull request #1499:
URL: https://github.com/apache/incubator-brpc/pull/1499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yujun411522 opened a new issue #1544:
URL: https://github.com/apache/incubator-brpc/issues/1544
如果差异只有pb的版本，那性能主要的差异也是pb本身吧。可以分别画个火焰图，做个差分火焰图看看cpu diff在哪里
_Originally posted by @lorinlee in
https://github.com/apache/incubator-brpc/issues/1540#issuecomment-906889000_
>
cdjingit commented on issue #1543:
URL: https://github.com/apache/incubator-brpc/issues/1543#issuecomment-910048273
是指没有brpc框架函数的调用关系吗？确定是有流量的？另外bin里的符号都保留了吗？有没有stripped掉？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cdjingit commented on pull request #1474:
URL: https://github.com/apache/incubator-brpc/pull/1474#issuecomment-910026907
这个需要哪些定制需求呢？可以列一些场景吗？默认的tcp_listen()本身涉及一些校验逻辑和gflag，替换的话需要和tcp_listen()兼容
--
This is an automated message from the Apache Git Service.
To respond to the message,
ijasonyi commented on pull request #1516:
URL: https://github.com/apache/incubator-brpc/pull/1516#issuecomment-909995268
awasome!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ijasonyi removed a comment on pull request #1516:
URL: https://github.com/apache/incubator-brpc/pull/1516#issuecomment-909994530
awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijasonyi commented on pull request #1516:
URL: https://github.com/apache/incubator-brpc/pull/1516#issuecomment-909994530
awesome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Thanks, Lorin,
Have you modify the oncall list page also?
BTW: would you please notify the next person who's oncall after you?
在 2021/9/1 上午10:52，“Lorin Lee” 写入:
Hi all,
The following PRs have been merged into master over the past week:
*
serverglen commented on pull request #1474:
URL: https://github.com/apache/incubator-brpc/pull/1474#issuecomment-909932867
@zyearn @lorinlee @cdjingit @TousakaRin 辛苦抽时间review下呗，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
serverglen commented on pull request #1468:
URL: https://github.com/apache/incubator-brpc/pull/1468#issuecomment-909932353
@zyearn @lorinlee @cdjingit @TousakaRin 辛苦抽时间review下呗，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
serverglen commented on pull request #1461:
URL: https://github.com/apache/incubator-brpc/pull/1461#issuecomment-909931918
@zyearn @lorinlee @cdjingit @TousakaRin 辛苦帮review下呗，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
serverglen edited a comment on pull request #1483:
URL: https://github.com/apache/incubator-brpc/pull/1483#issuecomment-906898534
> Related issue: #1482
> 目前brpcz中只有method级别的eps(error_per_second)，本PR实现了server级别的eps。
> 其实server级别的eps对业务来说更为重要。
@lorinlee @zyearn @cdjingit
27 matches
Mail list logo
