[GitHub] [brpc] owenliang commented on issue #1666: 使用h2:grpc当server端服务(grpc)持续不可用时,client端(brpc)陷入死循环

2023-01-19 Thread GitBox
owenliang commented on issue #1666: URL: https://github.com/apache/brpc/issues/1666#issuecomment-1397932105 的确如此,随便写个demo,让服务端死掉重启,客户端再也不连了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [brpc] wasphin merged pull request #2096: Install and pack brpc tools

2023-01-19 Thread GitBox
wasphin merged PR #2096: URL: https://github.com/apache/brpc/pull/2096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] wasphin opened a new pull request, #2096: Install and pack brpc tools

2023-01-19 Thread GitBox
wasphin opened a new pull request, #2096: URL: https://github.com/apache/brpc/pull/2096 ### What problem does this PR solve? Issue Number: NONE Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

[GitHub] [brpc] wasphin merged pull request #2095: Update release steps for TLP

2023-01-19 Thread GitBox
wasphin merged PR #2095: URL: https://github.com/apache/brpc/pull/2095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] wasphin opened a new pull request, #2095: Update release steps for TLP

2023-01-19 Thread GitBox
wasphin opened a new pull request, #2095: URL: https://github.com/apache/brpc/pull/2095 ### What problem does this PR solve? Issue Number: #2078 Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance

[GitHub] [brpc-website] wasphin commented on pull request #125: Fix download links

2023-01-18 Thread GitBox
wasphin commented on PR #125: URL: https://github.com/apache/brpc-website/pull/125#issuecomment-1396567478 好像是乌龙,校验文件没使用 dlcdn。 等下次发版时我再改回来。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [brpc] dandyhuang commented on issue #2048: 用户态tcp实现是否会开源呢?

2023-01-18 Thread GitBox
dandyhuang commented on issue #2048: URL: https://github.com/apache/brpc/issues/2048#issuecomment-1396331572 > 在7月份的视频中看到介绍说brpc实现了用户态tcp、去掉了bthread,目前是否已经上线使用?这个feature是否会开源呢? ![image](https://user-images.githubusercontent.com/19951954/207209476-eb8bec28-1444-4f90-a89b-c69eac029502.png)

[GitHub] [brpc] jenrryyou commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR

2023-01-18 Thread GitBox
jenrryyou commented on code in PR #2086: URL: https://github.com/apache/brpc/pull/2086#discussion_r1073469472 ## src/bthread/butex.cpp: ## @@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) { bool erase_from_butex(ButexWaiter*, bool, WaiterState); -int

[GitHub] [brpc] jenrryyou commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR

2023-01-18 Thread GitBox
jenrryyou commented on code in PR #2086: URL: https://github.com/apache/brpc/pull/2086#discussion_r1073469170 ## src/bthread/butex.cpp: ## @@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) { bool erase_from_butex(ButexWaiter*, bool, WaiterState); -int

[GitHub] [brpc] zhangke96 commented on pull request #1808: Mongo client

2023-01-18 Thread GitBox
zhangke96 commented on PR #1808: URL: https://github.com/apache/brpc/pull/1808#issuecomment-1386769913 > @zhangke96 mongoclient怎么样了, 我们现在也有这样的需求 最近没弄了,demo可以跑的。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [brpc] FightingCoder opened a new issue, #2094: 约千分之一的请求server耗时严重

2023-01-17 Thread GitBox
FightingCoder opened a new issue, #2094: URL: https://github.com/apache/brpc/issues/2094 **Describe the bug (描述bug)** io-bound型服务,服务压力很低。查看工作线程数以及cpu使用程度都没有问题。bthread_worker_count:9,bthread_worker_usage维持在1.5以下。process_cpu_usage 0.5以下。排除锁的嫌疑。 使用rpcz发现耗时大的请求都卡在了最后Leave阶段,以下是其中一个,Leave

[GitHub] [brpc] yanglimingcn commented on pull request #2093: Add Mysql Protocol

2023-01-17 Thread GitBox
yanglimingcn commented on PR #2093: URL: https://github.com/apache/brpc/pull/2093#issuecomment-1385095711 mysql的prepared statement协议的支持。 遇到的两个问题解决方案如下: 1、prepared statement首先是在某个连接上创建一个statement id,后续操作可以根据这个statement id向这个连接发送后续的请求。同一个语句在每个连接上的statement

[GitHub] [brpc] yanglimingcn opened a new pull request, #2093: Add Mysql Protocol

2023-01-17 Thread GitBox
yanglimingcn opened a new pull request, #2093: URL: https://github.com/apache/brpc/pull/2093 Add Mysql Protocol, support text protocol, transaction, support prepare statement. issue #209 ### What problem does this PR solve? Issue Number: Problem Summary:

[GitHub] [brpc] yanglimingcn closed pull request #692: Add Mysql Protocol, support transaction and prepared statement

2023-01-17 Thread GitBox
yanglimingcn closed pull request #692: Add Mysql Protocol, support transaction and prepared statement URL: https://github.com/apache/brpc/pull/692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [brpc] yanglimingcn closed pull request #722: Mysql transaction

2023-01-17 Thread GitBox
yanglimingcn closed pull request #722: Mysql transaction URL: https://github.com/apache/brpc/pull/722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc] yanglimingcn closed pull request #760: MySQL Prepared Statement support

2023-01-17 Thread GitBox
yanglimingcn closed pull request #760: MySQL Prepared Statement support URL: https://github.com/apache/brpc/pull/760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brpc] serverglen closed issue #2013: 基于请求延迟的并发控制

2023-01-16 Thread GitBox
serverglen closed issue #2013: 基于请求延迟的并发控制 URL: https://github.com/apache/brpc/issues/2013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc] wwbmmm merged pull request #2091: add timeout concurrency limiter doc

2023-01-16 Thread GitBox
wwbmmm merged PR #2091: URL: https://github.com/apache/brpc/pull/2091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] yanglimingcn commented on a diff in pull request #2091: add timeout concurrency limiter doc

2023-01-16 Thread GitBox
yanglimingcn commented on code in PR #2091: URL: https://github.com/apache/brpc/pull/2091#discussion_r1071768243 ## docs/cn/timeout_concurrency_limiter.md: ## @@ -0,0 +1,23 @@ +# 基于请求超时时间的限流 + +服务的处理能力是有客观上限的。当请求速度超过服务的处理速度时,服务就会过载。 +

[GitHub] [brpc] wwbmmm merged pull request #2092: Update oncall.md

2023-01-16 Thread GitBox
wwbmmm merged PR #2092: URL: https://github.com/apache/brpc/pull/2092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] lorinlee opened a new pull request, #2092: Update oncall.md

2023-01-16 Thread GitBox
lorinlee opened a new pull request, #2092: URL: https://github.com/apache/brpc/pull/2092 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

[GitHub] [brpc] wwbmmm commented on a diff in pull request #2091: add timeout concurrency limiter doc

2023-01-16 Thread GitBox
wwbmmm commented on code in PR #2091: URL: https://github.com/apache/brpc/pull/2091#discussion_r1071669830 ## docs/cn/timeout_concurrency_limiter.md: ## @@ -0,0 +1,23 @@ +# 基于请求超时时间的限流 + +服务的处理能力是有客观上限的。当请求速度超过服务的处理速度时,服务就会过载。 +

[GitHub] [brpc] yanglimingcn commented on issue #2013: 基于请求延迟的并发控制

2023-01-16 Thread GitBox
yanglimingcn commented on issue #2013: URL: https://github.com/apache/brpc/issues/2013#issuecomment-1383927392 #2091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brpc] yanglimingcn opened a new pull request, #2091: add timeout concurrency limiter doc

2023-01-16 Thread GitBox
yanglimingcn opened a new pull request, #2091: URL: https://github.com/apache/brpc/pull/2091 添加timeout concurrency limiter的文档 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brpc] serverglen opened a new issue, #2090: 适配loongarch64架构

2023-01-16 Thread GitBox
serverglen opened a new issue, #2090: URL: https://github.com/apache/brpc/issues/2090 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** **Describe the solution you'd like (描述你期望的解决方法)** **Describe alternatives you've considered (描述你想到的折衷方案)**

[GitHub] [brpc] wwbmmm merged pull request #2087: add max concurrency for timeout concurrency limiter

2023-01-15 Thread GitBox
wwbmmm merged PR #2087: URL: https://github.com/apache/brpc/pull/2087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] wwbmmm merged pull request #2089: WIP: fix doc && code style

2023-01-15 Thread GitBox
wwbmmm merged PR #2089: URL: https://github.com/apache/brpc/pull/2089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] cdjingit opened a new pull request, #2089: WIP: fix doc && code style

2023-01-15 Thread GitBox
cdjingit opened a new pull request, #2089: URL: https://github.com/apache/brpc/pull/2089 ### What problem does this PR solve? fix code style and doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [brpc] wwbmmm merged pull request #2088: Explicitly listing all third-part licensed files

2023-01-15 Thread GitBox
wwbmmm merged PR #2088: URL: https://github.com/apache/brpc/pull/2088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] wasphin opened a new pull request, #2088: Explicitly listing all third-part licensed files

2023-01-15 Thread GitBox
wasphin opened a new pull request, #2088: URL: https://github.com/apache/brpc/pull/2088 ### What problem does this PR solve? Issue Number: NONE Problem Summary: ### What is changed and the side effects? Changed: Update LICENSE to list files porting from

[GitHub] [brpc] wwbmmm commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR

2023-01-15 Thread GitBox
wwbmmm commented on code in PR #2086: URL: https://github.com/apache/brpc/pull/2086#discussion_r1070816953 ## src/bthread/butex.cpp: ## @@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) { bool erase_from_butex(ButexWaiter*, bool, WaiterState); -int

[GitHub] [brpc] yanglimingcn commented on issue #2013: 基于请求延迟的并发控制

2023-01-15 Thread GitBox
yanglimingcn commented on issue #2013: URL: https://github.com/apache/brpc/issues/2013#issuecomment-1383417016 OK,等我有时间补充一下哈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [brpc] ysj1173886760 commented on issue #845: 在aarch64下编译之后,运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况?

2023-01-15 Thread GitBox
ysj1173886760 commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383387003 > > 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 > > 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 > > 奇怪的是在我把我自己的项目设置成Release模式构建之后,就不会出现`sched_to itself`的错误了。 > >

[GitHub] [brpc] yanglimingcn opened a new pull request, #2087: add max concurrency for timeout concurrency limiter

2023-01-15 Thread GitBox
yanglimingcn opened a new pull request, #2087: URL: https://github.com/apache/brpc/pull/2087 基于延迟的并发控制,在average latency的统计还没有刷新的时候,有可能因为一些慢请求导致服务排队很多请求,这个最大并发的设置,可以在这种情况下保护服务不被太多的请求压垮。 @wwbmmm 请PR -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [brpc] wwbmmm commented on issue #845: 在aarch64下编译之后,运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况?

2023-01-15 Thread GitBox
wwbmmm commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383350427 > 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 > > 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 > > 奇怪的是在我把我自己的项目设置成Release模式构建之后,就不会出现`sched_to itself`的错误了。

[GitHub] [brpc] jenrryyou opened a new pull request, #2086: Fix butex wait_pthread handle EINTR

2023-01-15 Thread GitBox
jenrryyou opened a new pull request, #2086: URL: https://github.com/apache/brpc/pull/2086 wait_pthread处理被信号中断的情况。 没有这个处理之前,假设butex_wait_from_pthread的timeout设置为100s,但是这个线程每隔10s会被信号中断(如正在进行profile,会定时中断采集线程堆栈),futex_wait_private会返回EINTR,导致butex_wait_from_pthread永远不会超时返回。 -- This is an

[GitHub] [brpc] ysj1173886760 commented on issue #845: 在aarch64下编译之后,运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况?

2023-01-15 Thread GitBox
ysj1173886760 commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383136246 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 奇怪的是在我把我自己的项目设置成Release模式构建之后,就不会出现`sched_to itself`的错误了。 -- This is an

[GitHub] [brpc] lorinlee merged pull request #2047: Keep bthread TaskGroup abi compatible with NDEBUG macro

2023-01-15 Thread GitBox
lorinlee merged PR #2047: URL: https://github.com/apache/brpc/pull/2047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] lorinlee merged pull request #2083: typo fix for bthread introduction

2023-01-15 Thread GitBox
lorinlee merged PR #2083: URL: https://github.com/apache/brpc/pull/2083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] lorinlee commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1

2023-01-15 Thread GitBox
lorinlee commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1383112440 @xiaohei520321 获取不到ip的服务器上,hosts文件里有写127.0.0.1吗,删掉看可以不 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [brpc] chenBright commented on issue #2013: 基于请求延迟的并发控制

2023-01-13 Thread GitBox
chenBright commented on issue #2013: URL: https://github.com/apache/brpc/issues/2013#issuecomment-1381748915 @yanglimingcn 能写个关于这个特性的文档吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [brpc] wwbmmm commented on issue #1847: Support the latest Bazel compilation and documentation

2023-01-12 Thread GitBox
wwbmmm commented on issue #1847: URL: https://github.com/apache/brpc/issues/1847#issuecomment-1381375125 master has supported bazel 4.2.2, see this example: https://github.com/apache/brpc/tree/master/example/build_with_bazel this issue can be closed -- This is an automated message

[GitHub] [brpc] wwbmmm closed issue #1847: Support the latest Bazel compilation and documentation

2023-01-12 Thread GitBox
wwbmmm closed issue #1847: Support the latest Bazel compilation and documentation URL: https://github.com/apache/brpc/issues/1847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brpc] VirendraYadav1234 commented on issue #1847: Support the latest Bazel compilation and documentation

2023-01-12 Thread GitBox
VirendraYadav1234 commented on issue #1847: URL: https://github.com/apache/brpc/issues/1847#issuecomment-1381349749 I want to work on this issue please assign me this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [brpc] VirendraYadav1234 commented on issue #1931: size parameter of AnnotateBenignRaceSized should be typed size_t instead of long

2023-01-12 Thread GitBox
VirendraYadav1234 commented on issue #1931: URL: https://github.com/apache/brpc/issues/1931#issuecomment-1381348429 I want to work on this issue please assign me this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [brpc] VirendraYadav1234 commented on issue #1209: remove the docs and comments related to HealthCheckThread

2023-01-12 Thread GitBox
VirendraYadav1234 commented on issue #1209: URL: https://github.com/apache/brpc/issues/1209#issuecomment-1381348639 I want to work on this issue please assign me this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [brpc] wwbmmm merged pull request #2085: Remove DISCLAIMER

2023-01-12 Thread GitBox
wwbmmm merged PR #2085: URL: https://github.com/apache/brpc/pull/2085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] leaf-potato commented on issue #1991: support https alpn

2023-01-12 Thread GitBox
leaf-potato commented on issue #1991: URL: https://github.com/apache/brpc/issues/1991#issuecomment-1380575010 > 特别是当后端是个集群时,不同后端实例的ALPN协商结果可能是不同的,这样会让问题变得很复杂。 是这样的,实际在考虑的时候发现集群模式实现起来比较复杂,对现有的流程有很大的改动。 > 所以我建议,如果要在bRPC中支持ALPN协议,仅支持后端是单个ip的情况(single

[GitHub] [brpc] leaf-potato commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1

2023-01-12 Thread GitBox
leaf-potato commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1380558694 看着挺奇怪的,可能是机器哪儿的配置不对。brpc是调用系统的接口获取hostname后解析ip: 1. 可能hostname配置了多个ip地址,brpc只会选择第1个返回。 1. 可以考虑手动将真实的ip写到`/etc/hosts`文件里。 -- This is an automated message from the Apache Git

[GitHub] [brpc] luliyucoordinate closed issue #2073: 关于append_user_data中使用引用计数内存的问题

2023-01-12 Thread GitBox
luliyucoordinate closed issue #2073: 关于append_user_data中使用引用计数内存的问题 URL: https://github.com/apache/brpc/issues/2073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brpc] xiaohei520321 commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1

2023-01-12 Thread GitBox
xiaohei520321 commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1380256066 > 机器上执行下面命令看看输出结果是否正常: > > ```shell > host `hostname` > ``` 我有4台服务器,3台是能获取到本机ip的,1台只能获取到127.0.0.1 这4台服务器上运行结果都是: Host x not found: 3(NXDOMAIN)

[GitHub] [brpc] leaf-potato commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1

2023-01-12 Thread GitBox
leaf-potato commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1380235911 机器上执行下面命令看看输出结果是否正常: ```bash host `hostname` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [brpc] wwbmmm opened a new pull request, #2085: Remove DISCLAIMER

2023-01-12 Thread GitBox
wwbmmm opened a new pull request, #2085: URL: https://github.com/apache/brpc/pull/2085 ### What problem does this PR solve? Issue Number: 2078 Problem Summary: Since bRPC has graduated, the DISCLAIMER file can be removed. ### What is changed and the side effects?

[GitHub] [brpc] xiaohei520321 opened a new issue, #2084: my_ip_cstr获取本机ip为127.0.0.1

2023-01-11 Thread GitBox
xiaohei520321 opened a new issue, #2084: URL: https://github.com/apache/brpc/issues/2084 **Describe the bug (描述bug)** butil::my_ip_cstr() 获取本机的ip为127.0.0.1 **To Reproduce (复现方法)** **Expected behavior (期望行为)** 期望获取到真实的ip **Versions (各种版本)** OS:

[GitHub] [brpc] lorinlee commented on issue #2081: http_rpc_protocol.cpp中core掉了, 看起来不像是业务代码导致的

2023-01-11 Thread GitBox
lorinlee commented on issue #2081: URL: https://github.com/apache/brpc/issues/2081#issuecomment-1379725069 可能是业务代码把内存写坏了,这个问题好复现不,建议开ASAN复现下。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [brpc] freemandealer opened a new pull request, #2083: typo fix for bthread introduction

2023-01-11 Thread GitBox
freemandealer opened a new pull request, #2083: URL: https://github.com/apache/brpc/pull/2083 As term 'M:N' starts with a vowel sound [e], so it should be 'an' instead of 'a' grammatically. Signed-off-by: freemandealer ### What problem does this PR solve? Issue Number:

[GitHub] [brpc] xiaoyuxee closed issue #2074: 客户端请求比较耗时的case 时,rpc E1010,500 Internal Server Error

2023-01-11 Thread GitBox
xiaoyuxee closed issue #2074: 客户端请求比较耗时的case 时,rpc E1010,500 Internal Server Error URL: https://github.com/apache/brpc/issues/2074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brpc] xiaoyuxee commented on issue #2074: 客户端请求比较耗时的case 时,rpc E1010,500 Internal Server Error

2023-01-11 Thread GitBox
xiaoyuxee commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378488740 把 client 端 window size 调大后,问题解决。 > 客户端请求比较耗时的case ... 应该不是耗时引起,而是耗时的 case 所产生的 response 也比较大。 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [brpc] highkic opened a new issue, #2082: http接口获取到的 mbvar转prometheus metrics 格式, 提示格式非法

2023-01-10 Thread GitBox
highkic opened a new issue, #2082: URL: https://github.com/apache/brpc/issues/2082 **Describe the bug (描述bug)** 通过brpc_metrics接口获取mbvar 转化来的多lables guage打点,提示type非法 具体的值: # HELP lat_rank_score_total_latency{system="unknown",module="unknown",server="rank_server_nbase",status="0"}

[GitHub] [brpc] jiangdongzi commented on issue #2081: http_rpc_protocol.cpp中core掉了, 看起来不像是业务代码导致的

2023-01-10 Thread GitBox
jiangdongzi commented on issue #2081: URL: https://github.com/apache/brpc/issues/2081#issuecomment-1378264975 编译所用commit `a0fc1a2` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brpc] xiaoyuxee commented on issue #2074: 客户端请求比较耗时的case 时,rpc E1010,500 Internal Server Error

2023-01-10 Thread GitBox
xiaoyuxee commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378261134 > client 端信息如下: > > * ParallelChannel 中包含多个 SelectiveChannel,用于并行调用 SelectiveChannel 中某个 server > * protocol = "h2:grpc" > * SelectiveChannel

[GitHub] [brpc] wwbmmm commented on issue #2074: 客户端请求比较耗时的case 时,rpc E1010,500 Internal Server Error

2023-01-10 Thread GitBox
wwbmmm commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378255494 在client和server分别抓包看看 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brpc] xiaoyuxee commented on issue #2074: 客户端请求比较耗时的case 时,rpc E1010,500 Internal Server Error

2023-01-10 Thread GitBox
xiaoyuxee commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378251117 通过打印日志发现,client 端socket 接受到的 header 中已经是 500 了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [brpc] xiaoyuxee commented on issue #2074: 客户端请求比较耗时的case 时,rpc E1010,500 Internal Server Error

2023-01-10 Thread GitBox
xiaoyuxee commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378245453 > client和server间是不是还有一层http代理? 通过 k8s 的pod域名来调用 server 的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [brpc] jiangdongzi commented on issue #2081: http_rpc_protocol.cpp中core掉了, 看起来不像是业务代码导致的

2023-01-10 Thread GitBox
jiangdongzi commented on issue #2081: URL: https://github.com/apache/brpc/issues/2081#issuecomment-1378204081 偶发 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brpc] jiangdongzi opened a new issue, #2081: http_rpc_protocol.cpp中core掉了, 看起来不像是业务代码导致的

2023-01-10 Thread GitBox
jiangdongzi opened a new issue, #2081: URL: https://github.com/apache/brpc/issues/2081 ![image](https://user-images.githubusercontent.com/17529657/211712202-ba7362f1-f1f1-4ad5-9de1-0a0a6056367f.png) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [brpc] wwbmmm commented on issue #1991: support https alpn

2023-01-10 Thread GitBox
wwbmmm commented on issue #1991: URL: https://github.com/apache/brpc/issues/1991#issuecomment-1378175719 > @wwbmmm Client端的实现有几个问题想请教下:目前考虑的是在`ChannelSSLOptions`中新增ALPN的配置,在TLS协商成功后覆盖`ChannelOptions.protocol`字段进行后续的数据发送。 > >

[GitHub] [brpc] fzhedu closed issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2023-01-10 Thread GitBox
fzhedu closed issue #2052: 传输大量数据必须用butil::IOBuf 吗? URL: https://github.com/apache/brpc/issues/2052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc] fzhedu commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2023-01-10 Thread GitBox
fzhedu commented on issue #2052: URL: https://github.com/apache/brpc/issues/2052#issuecomment-1378169591 @leaf-potato 感谢您的回复。 通过微信官方群确认,append 和 append_user_data 将用户数据弄到 iobuf 都不需要序列化,并且用后者更高效,因为它避免 copy。 再次感谢您的耐心解答。 -- This is an automated message from the Apache Git Service. To

[GitHub] [brpc] wwbmmm closed issue #2062: 多维度bvar支持http内置服务查看吗?

2023-01-10 Thread GitBox
wwbmmm closed issue #2062: 多维度bvar支持http内置服务查看吗? URL: https://github.com/apache/brpc/issues/2062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc] wwbmmm commented on issue #2070: Bash shebangs are wrong: they should be #!/usr/bin/env bash

2023-01-10 Thread GitBox
wwbmmm commented on issue #2070: URL: https://github.com/apache/brpc/issues/2070#issuecomment-1378160786 related: #2072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brpc] wwbmmm commented on issue #2071: error: cannot initialize return object of type 'uint64_t' (aka 'unsigned long') with an rvalue of type 'pthread_t'

2023-01-10 Thread GitBox
wwbmmm commented on issue #2071: URL: https://github.com/apache/brpc/issues/2071#issuecomment-1378160660 related: #2072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brpc] wwbmmm commented on issue #2074: 客户端请求比较耗时的case 时,rpc E1010,500 Internal Server Error

2023-01-10 Thread GitBox
wwbmmm commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378160046 client和server间是不是还有一层http代理? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [brpc] wwbmmm commented on issue #2077: 支持xmake构建项目

2023-01-10 Thread GitBox
wwbmmm commented on issue #2077: URL: https://github.com/apache/brpc/issues/2077#issuecomment-1378158679 same as #1766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [brpc] xiedeacc closed issue #2080: import brpc in bazel compile error

2023-01-10 Thread GitBox
xiedeacc closed issue #2080: import brpc in bazel compile error URL: https://github.com/apache/brpc/issues/2080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [brpc] xiedeacc commented on issue #2080: import brpc in bazel compile error

2023-01-10 Thread GitBox
xiedeacc commented on issue #2080: URL: https://github.com/apache/brpc/issues/2080#issuecomment-1377338265 fixed by add openssl to workspace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [brpc] xiedeacc commented on issue #2080: import brpc in bazel compile error

2023-01-10 Thread GitBox
xiedeacc commented on issue #2080: URL: https://github.com/apache/brpc/issues/2080#issuecomment-1377274454 brpc itself can be compiled successfully, but imported as an dependency failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [brpc-website] wwbmmm merged pull request #127: update the apache url

2023-01-10 Thread GitBox
wwbmmm merged PR #127: URL: https://github.com/apache/brpc-website/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc-website] wasphin merged pull request #125: Fix download links

2023-01-10 Thread GitBox
wasphin merged PR #125: URL: https://github.com/apache/brpc-website/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc] xiedeacc opened a new issue, #2080: import bazel in bazel compile error

2023-01-10 Thread GitBox
xiedeacc opened a new issue, #2080: URL: https://github.com/apache/brpc/issues/2080 **Describe the bug (描述bug)** I import brpc in a bazel repo, first it said lack of crc32c, leveldb, snappy, zlib and some config file, it also need add some condition config to avoid bazel/config not

[GitHub] [brpc] NKcqx commented on issue #1847: Support the latest Bazel compilation and documentation

2023-01-10 Thread GitBox
NKcqx commented on issue #1847: URL: https://github.com/apache/brpc/issues/1847#issuecomment-1376939962 有一个小建议,提到 "latest Bazel" 的时候可否带上当时的 Bazel 版本? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [brpc] NKcqx commented on issue #1268: 如果用bazel编译brpc的话,bazel需要到多少版本呢?

2023-01-10 Thread GitBox
NKcqx commented on issue #1268: URL: https://github.com/apache/brpc/issues/1268#issuecomment-1376931584 protobuf 仍然有问题 bazel version: 4.2.2 brpc master commit: 5283d0d930c33e03346ab59de3580c061c3e90b8 报错: ``` INFO: Repository com_google_protobuf instantiated at:

[GitHub] [brpc-website] serverglen merged pull request #126: update the apache logo and description

2023-01-09 Thread GitBox
serverglen merged PR #126: URL: https://github.com/apache/brpc-website/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc-website] Huixxi commented on a diff in pull request #126: update the apache logo and description

2023-01-09 Thread GitBox
Huixxi commented on code in PR #126: URL: https://github.com/apache/brpc-website/pull/126#discussion_r1065368984 ## content/zh/_index.html: ## @@ -44,14 +44,14 @@ 你可以使用它: 搭建能在一个端口支持多协议的服务, 或访问各种服务。 -restful http/https, h2/gRPC.

[GitHub] [brpc-website] Huixxi commented on a diff in pull request #126: update the apache logo and description

2023-01-09 Thread GitBox
Huixxi commented on code in PR #126: URL: https://github.com/apache/brpc-website/pull/126#discussion_r1065368609 ## content/zh/_index.html: ## @@ -44,14 +44,14 @@ 你可以使用它: 搭建能在一个端口支持多协议的服务, 或访问各种服务。 -restful http/https, h2/gRPC.

[GitHub] [brpc-website] wasphin commented on a diff in pull request #126: update the apache logo and description

2023-01-09 Thread GitBox
wasphin commented on code in PR #126: URL: https://github.com/apache/brpc-website/pull/126#discussion_r1065357838 ## content/zh/_index.html: ## @@ -44,14 +44,14 @@ 你可以使用它: 搭建能在一个端口支持多协议的服务, 或访问各种服务。 -restful http/https, h2/gRPC.

[GitHub] [brpc-website] wasphin commented on a diff in pull request #122: Remove incubator

2023-01-09 Thread GitBox
wasphin commented on code in PR #122: URL: https://github.com/apache/brpc-website/pull/122#discussion_r1065355216 ## content/zh/docs/DownloadBRPC/index.md: ## @@ -50,25 +50,25 @@ Apache bRPC(孵化)作为源工件发布。我们很高兴宣布我们的1.3 -Apache bRPC (incubating)

[GitHub] [brpc-website] wasphin commented on pull request #125: Fix download links

2023-01-09 Thread GitBox
wasphin commented on PR #125: URL: https://github.com/apache/brpc-website/pull/125#issuecomment-1376762330 下载地址 dlcdn 和 download 都有用的,最终还是参考 tomcat 用 dlcdn 的吧。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [brpc] wwbmmm merged pull request #2079: Remove incubator in svn and download path

2023-01-09 Thread GitBox
wwbmmm merged PR #2079: URL: https://github.com/apache/brpc/pull/2079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [brpc] wwbmmm opened a new pull request, #2079: Remove incubator in svn and download path

2023-01-09 Thread GitBox
wwbmmm opened a new pull request, #2079: URL: https://github.com/apache/brpc/pull/2079 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

[GitHub] [brpc] wwbmmm opened a new issue, #2078: Apache bRPC Graduation Tasks

2023-01-09 Thread GitBox
wwbmmm opened a new issue, #2078: URL: https://github.com/apache/brpc/issues/2078 The ASF board has approved a resolution to graduate bRPC into a full Top Level Project. Thanks to everyone for your help to get to this point. To transition from the Apache Incubator to a new TLP,

[GitHub] [brpc-website] wwbmmm merged pull request #121: remove the incubating from brpc logo on the home page

2023-01-09 Thread GitBox
wwbmmm merged PR #121: URL: https://github.com/apache/brpc-website/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc-website] wwbmmm merged pull request #122: Remove incubator

2023-01-09 Thread GitBox
wwbmmm merged PR #122: URL: https://github.com/apache/brpc-website/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [brpc] wwbmmm merged pull request #2056: Remove incubator

2023-01-09 Thread GitBox
wwbmmm merged PR #2056: URL: https://github.com/apache/brpc/pull/2056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[GitHub] [incubator-brpc] leaf-potato opened a new issue, #2077: 支持xmake构建项目

2023-01-09 Thread GitBox
leaf-potato opened a new issue, #2077: URL: https://github.com/apache/incubator-brpc/issues/2077 xmake目前对c/c++项目的构建比较完善了,是否有支持xmake的计划呢? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-brpc] leaf-potato commented on issue #1991: support https alpn

2023-01-09 Thread GitBox
leaf-potato commented on issue #1991: URL: https://github.com/apache/incubator-brpc/issues/1991#issuecomment-1375729393 @wwbmmm Client端的实现有几个问题想请教下:目前考虑的是在`ChannelSSLOptions`中新增ALPN的配置,在TLS协商成功后覆盖`ChannelOptions.protocol`字段进行后续的数据发送。

[GitHub] [incubator-brpc] leaf-potato commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2023-01-09 Thread GitBox
leaf-potato commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1375721168 目前似乎没看到相关的文档或者测试数据,可以问下仓库的管理员~ 简单说下个人的理解: 1. 使用proto设置reponse:用户设置response => 序列化数据(框架) => 发送 2. attament传序列化数据:用户设置reponse => 序列化数据(用户) => 发送

[GitHub] [incubator-brpc] fzhedu commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗?

2023-01-09 Thread GitBox
fzhedu commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1375702075 @leaf-potato 谢谢你的指点,`append_user_data ` 确实可以避免大chunk copy 到 attachment 的问题。 Q3 我正在学习中。 针对 Q1 还有疑问,不理解你上面回复 ```

[GitHub] [incubator-brpc] wwbmmm merged pull request #2076: Rollback #2049 chang

2023-01-09 Thread GitBox
wwbmmm merged PR #2076: URL: https://github.com/apache/incubator-brpc/pull/2076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] co0l1ce opened a new pull request, #2076: Rollback #2049 chang

2023-01-08 Thread GitBox
co0l1ce opened a new pull request, #2076: URL: https://github.com/apache/incubator-brpc/pull/2076 ### What problem does this PR solve? Chang in #2049 has same problem for a different Link order(. brpc -> pthread), will can't find symbol and exit, so rollback, the Origin implement need

  1   2   3   4   5   6   7   8   9   10   >