[GitHub] [incubator-brpc] jamesge commented on issue #570: add queue mutex & uid barrel & switch for baidu protocol

2019-05-04 Thread GitBox
jamesge commented on issue #570: add queue mutex & uid barrel & switch for baidu protocol URL: https://github.com/apache/incubator-brpc/pull/570#issuecomment-489393004 需要有序用[streaming rpc](https://github.com/apache/incubator-brpc/blob/master/docs/cn/streaming_rpc.md) -

[GitHub] [incubator-brpc] Xavier1994 commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-05-05 Thread GitBox
Xavier1994 commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-489408599 我也遇到了这个问题, bt也是展示了core在brpc里, 所以应该怎么看到core在我业务代码的backtrace上 This is an automated

[GitHub] [incubator-brpc] d0ngjun commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-05-05 Thread GitBox
d0ngjun commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-489408867 我的做法是在回调内写一个大的try catch,这样可以捕获,避免brpc“吞掉”异常。 或者可以在关键代码块附近添加log,可以辅助判断 This is an

[GitHub] [incubator-brpc] Xavier1994 commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-05-05 Thread GitBox
Xavier1994 commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-489410109 @scottzzq 请假一下你的后面一个与业务逻辑相关的backtrace是如何打出来的 This is an automated message from th

[GitHub] [incubator-brpc] Xavier1994 edited a comment on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-05-05 Thread GitBox
Xavier1994 edited a comment on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-489410109 @scottzzq 请教一下你的后面一个与业务逻辑相关的backtrace是如何打出来的 This is an automated message

[GitHub] [incubator-brpc] Xavier1994 commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题

2019-05-05 Thread GitBox
Xavier1994 commented on issue #165: 在brpc接口内部core,但是使用gdb分析时遇到问题 URL: https://github.com/apache/incubator-brpc/issues/165#issuecomment-489419591 @d0ngjun 可以在brpc回调的函数都加上noexcept, 然后core的时候backtrace就会出来 This is an automated me

[GitHub] [incubator-brpc] skilxnTL commented on issue #753: 请问下开源版本和公司内部版本的同步机制是怎样的?

2019-05-05 Thread GitBox
skilxnTL commented on issue #753: 请问下开源版本和公司内部版本的同步机制是怎样的? URL: https://github.com/apache/incubator-brpc/issues/753#issuecomment-489511517 嗯嗯,我看github的版本已经增加了不少feature,确实不太好同步,谢谢。 This is an automated message from the Apache G

[GitHub] [incubator-brpc] skilxnTL closed issue #753: 请问下开源版本和公司内部版本的同步机制是怎样的?

2019-05-05 Thread GitBox
skilxnTL closed issue #753: 请问下开源版本和公司内部版本的同步机制是怎样的? URL: https://github.com/apache/incubator-brpc/issues/753 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-brpc] kenshinxf edited a comment on issue #743: 以同步调用的方式使用brpc thrift client, 当下游thrift服务端出现节点不可用的时候 ,task_group 线程组 会出现调度的极度不均匀

2019-05-06 Thread GitBox
kenshinxf edited a comment on issue #743: 以同步调用的方式使用brpc thrift client, 当下游thrift服务端出现节点不可用的时候 ,task_group 线程组 会出现调度的极度不均匀 URL: https://github.com/apache/incubator-brpc/issues/743#issuecomment-489926254 > > > 直接重启一台下游服务; 没有复现这个问题? 直接channel单连接一台下游服务试试;我昨天复现无数次了; 现在线上的服务改成半异步才好; 要不行我等下再试试;

[GitHub] [incubator-brpc] kenshinxf commented on issue #743: 以同步调用的方式使用brpc thrift client, 当下游thrift服务端出现节点不可用的时候 ,task_group 线程组 会出现调度的极度不均匀

2019-05-06 Thread GitBox
kenshinxf commented on issue #743: 以同步调用的方式使用brpc thrift client, 当下游thrift服务端出现节点不可用的时候 ,task_group 线程组 会出现调度的极度不均匀 URL: https://github.com/apache/incubator-brpc/issues/743#issuecomment-489926254 > > > 直接重启一台下游服务; 没有复现这个问题? 直接channel单连接一台下游服务试试;我昨天复现无数次了; 现在线上的服务改成半异步才好; 要不行我等下再试试; 然后整个程序

[GitHub] [incubator-brpc] TousakaRin opened a new pull request #754: add explicit key word for AdaptiveXXX

2019-05-07 Thread GitBox
TousakaRin opened a new pull request #754: add explicit key word for AdaptiveXXX URL: https://github.com/apache/incubator-brpc/pull/754 1. 为 AdaptiveXXX 的构造函数增加了explicit 关键字,以避免一些预期之外的隐式转换 (如执行 std::string == int,会调用 operator ==(butil:StringPiece, AdaptiveMaxConcurrency) 2. 用户代码中,一些显示的o

[GitHub] [incubator-brpc] haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-07 Thread GitBox
haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-490032908 多谢提醒,是描述的有问题。 是connection_type为single时,会出现超时。把connection_type改成short或者pooled后,就不会有超时现象了。

[GitHub] [incubator-brpc] peacedog123 commented on issue #465: Brpc couchbase

2019-05-08 Thread GitBox
peacedog123 commented on issue #465: Brpc couchbase URL: https://github.com/apache/incubator-brpc/pull/465#issuecomment-490388197 谢谢,社区这边不考虑合并么? This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-brpc] flily commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误

2019-05-08 Thread GitBox
flily commented on issue #695: gflags(2.1.2-3),g++( 4:5.3.1-1ubuntu1) protobuf( 2.6.1-1.3) Linux make编译错误 URL: https://github.com/apache/incubator-brpc/issues/695#issuecomment-490556339 这个问题我解决了,gflags和protobuf编译的时候没有`-fPIC`参数,最后链接的时候出的问题。这两个的源代码我自己重新编译了一次,在CMakeFiles.txt的最后加上一行`set(CMAKE_

[GitHub] [incubator-brpc] alicialin opened a new issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么

2019-05-08 Thread GitBox
alicialin opened a new issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么 URL: https://github.com/apache/incubator-brpc/issues/755 **Describe the bug (描述bug)* 因为BRPC 内部是系统级开的线程,对用户无感,如果请求是多线程写同一个地方,是否需要加锁,加锁后,整体性能是不是变慢? **To Reproduce (复现方法)** **Expected behavior (期望行为)**

[GitHub] [incubator-brpc] jamesge commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-08 Thread GitBox
jamesge commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-490734899 怎么复现这个问题呢?持续地发那个"300个key“可以复现么? This is an automated message from the Apache Git Servi

[GitHub] [incubator-brpc] GardianT commented on issue #658: client未开启ssl,出现core,调用栈显示在ssl相关函数上。

2019-05-09 Thread GitBox
GardianT commented on issue #658: client未开启ssl,出现core,调用栈显示在ssl相关函数上。 URL: https://github.com/apache/incubator-brpc/issues/658#issuecomment-490792120 remind,这个问题想问下有进度么?最近看见过四五次了。 This is an automated message from the Apache G

[GitHub] [incubator-brpc] stuhj commented on issue #712: 网络抖动造成client iobuf泄漏OOM

2019-05-09 Thread GitBox
stuhj commented on issue #712: 网络抖动造成client iobuf泄漏OOM URL: https://github.com/apache/incubator-brpc/issues/712#issuecomment-490812934 同样遇到这个问题,rpc channel连接数量稳定在5000,io-buf一直上涨 This is an automated message from t

[GitHub] [incubator-brpc] dapengbusi commented on issue #712: 网络抖动造成client iobuf泄漏OOM

2019-05-09 Thread GitBox
dapengbusi commented on issue #712: 网络抖动造成client iobuf泄漏OOM URL: https://github.com/apache/incubator-brpc/issues/712#issuecomment-490832981 我猜测,这个问题根本原因是brpc,依赖tc_malloc库,这个库其实很不好。开辟的大块内存,最后都不会被操作系统回收。尽管你调用了free。需要强制调用tcmalloc内置free函数。建议brpc后面版本更新至jemalloc。

[GitHub] [incubator-brpc] dapengbusi commented on issue #678: 关于一致性hash只支持32位key问题

2019-05-09 Thread GitBox
dapengbusi commented on issue #678: 关于一致性hash只支持32位key问题 URL: https://github.com/apache/incubator-brpc/issues/678#issuecomment-490836339 一致性hash,你提到的这个原因,这也是一方面原因。但我理解,一致性hash之所以选32位最大值,是因为虚拟节点个数,一般最大值也就这个。当然你也可以设置成16位的,任何你想设置的数字,但需要保证,虚拟节点对应的实体ip,分布较为均匀即可。

[GitHub] [incubator-brpc] chenlei5662 opened a new issue #756: 对arm64平台支持吗

2019-05-09 Thread GitBox
chenlei5662 opened a new issue #756: 对arm64平台支持吗 URL: https://github.com/apache/incubator-brpc/issues/756 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** **Describe the solution you'd like (描述你期望的解决方法)** **Describe alternatives you've considered (描述

[GitHub] [incubator-brpc] jasonszang opened a new pull request #757: Fix typo

2019-05-09 Thread GitBox
jasonszang opened a new pull request #757: Fix typo URL: https://github.com/apache/incubator-brpc/pull/757 Fixes issue #751 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-brpc] hawkingrei opened a new pull request #758: chore: update bazel

2019-05-09 Thread GitBox
hawkingrei opened a new pull request #758: chore: update bazel URL: https://github.com/apache/incubator-brpc/pull/758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-brpc] zyearn commented on issue #756: 对arm64平台支持吗

2019-05-09 Thread GitBox
zyearn commented on issue #756: 对arm64平台支持吗 URL: https://github.com/apache/incubator-brpc/issues/756#issuecomment-491147346 The [context lib](https://github.com/twlostow/libcontext) that brpc uses has already supported linux on arm64. But the version adopted by brpc maybe too old that new

[GitHub] [incubator-brpc] zyearn commented on issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么

2019-05-09 Thread GitBox
zyearn commented on issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么 URL: https://github.com/apache/incubator-brpc/issues/755#issuecomment-491148512 please read https://github.com/apache/incubator-brpc/blob/master/docs/en/client.md and https://github.com/apache/incubator-brpc/blob/master/docs/en/ser

[GitHub] [incubator-brpc] jamesge merged pull request #757: Fix typo

2019-05-09 Thread GitBox
jamesge merged pull request #757: Fix typo URL: https://github.com/apache/incubator-brpc/pull/757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-brpc] zyearn opened a new issue #759: ignoring some errors in circuit breaker

2019-05-09 Thread GitBox
zyearn opened a new issue #759: ignoring some errors in circuit breaker URL: https://github.com/apache/incubator-brpc/issues/759 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** Some errors should not be counted as the circuit breaker error, such as ELIMIT, or client-

[GitHub] [incubator-brpc] zyearn commented on issue #728: EINVAL返回码触发熔断问题

2019-05-09 Thread GitBox
zyearn commented on issue #728: EINVAL返回码触发熔断问题 URL: https://github.com/apache/incubator-brpc/issues/728#issuecomment-491150643 The current implementation considers all the error as feedback to circuit breaker, which may not be a reasonable way. I have opened a new [issue](https://github.c

[GitHub] [incubator-brpc] jasonszang commented on issue #751: There is a useless check in variable.cpp

2019-05-09 Thread GitBox
jasonszang commented on issue #751: There is a useless check in variable.cpp URL: https://github.com/apache/incubator-brpc/issues/751#issuecomment-491153666 Fixed in #757 This is an automated message from the Apache Git Servi

[GitHub] [incubator-brpc] yanglimingcn opened a new pull request #760: Mysql Prepared Statement support

2019-05-09 Thread GitBox
yanglimingcn opened a new pull request #760: Mysql Prepared Statement support URL: https://github.com/apache/incubator-brpc/pull/760 添加了mysql的prepared statement协议的支持。 目前遇到两个问题无法解决 1、prepared statement首先是在某个连接上创建一个statement id,后续操作可以根据这个statement id向这个连接发送后续的请求。同一个语句在每个连接上的statement i

[GitHub] [incubator-brpc] yanglimingcn commented on issue #760: Mysql Prepared Statement support

2019-05-09 Thread GitBox
yanglimingcn commented on issue #760: Mysql Prepared Statement support URL: https://github.com/apache/incubator-brpc/pull/760#issuecomment-491156813 issue #209 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-brpc] crise1990 opened a new issue #761: Centos 7.3运行example的echo_server报错

2019-05-09 Thread GitBox
crise1990 opened a new issue #761: Centos 7.3运行example的echo_server报错 URL: https://github.com/apache/incubator-brpc/issues/761 版本信息: brpc-0.9.5 protobuf-3.6.1 gflags-2.2.1 glog-0.4.0 编译brpc和example/echo_c++ 没有异常,运行./echo_server时报错: E0510 06:10:36.911083 2562 server.cpp:

[GitHub] [incubator-brpc] crise1990 commented on issue #761: Centos 7.3运行example的echo_server报错

2019-05-09 Thread GitBox
crise1990 commented on issue #761: Centos 7.3运行example的echo_server报错 URL: https://github.com/apache/incubator-brpc/issues/761#issuecomment-491175496 plus, while making example/http_c++ : Compiling http_client.o Linking http_client Compiling benchmark_http.o Linking benchmark_

[GitHub] [incubator-brpc] brianjcj opened a new issue #762: 支持Redis Sentinel

2019-05-10 Thread GitBox
brianjcj opened a new issue #762: 支持Redis Sentinel URL: https://github.com/apache/incubator-brpc/issues/762 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** **Describe the solution you'd like (描述你期望的解决方法)** **Describe alternatives you've considered (

[GitHub] [incubator-brpc] lwmonster opened a new issue #763: rpc 请求卡住了,不超时

2019-05-11 Thread GitBox
lwmonster opened a new issue #763: rpc 请求卡住了,不超时 URL: https://github.com/apache/incubator-brpc/issues/763 **Describe the bug (描述bug)** rpc 请求卡住了,不超时 **To Reproduce (复现方法)** **Expected behavior (期望行为)** 超时报错 **Versions (各种版本)** OS: Centos Compiler: gcc 4.8

[GitHub] [incubator-brpc] jamesge merged pull request #758: chore: update bazel

2019-05-12 Thread GitBox
jamesge merged pull request #758: chore: update bazel URL: https://github.com/apache/incubator-brpc/pull/758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-brpc] chenlei5662 commented on issue #756: 对arm64平台支持吗

2019-05-12 Thread GitBox
chenlei5662 commented on issue #756: 对arm64平台支持吗 URL: https://github.com/apache/incubator-brpc/issues/756#issuecomment-491646134 ok,thanks! This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-brpc] chenlei5662 closed issue #756: 对arm64平台支持吗

2019-05-12 Thread GitBox
chenlei5662 closed issue #756: 对arm64平台支持吗 URL: https://github.com/apache/incubator-brpc/issues/756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-brpc] xinxinsh opened a new issue #764: brpc http client head请求问题

2019-05-12 Thread GitBox
xinxinsh opened a new issue #764: brpc http client head请求问题 URL: https://github.com/apache/incubator-brpc/issues/764 **Describe the bug (描述bug)** 利用brpc http client构建head请求,出现url链接不上Error [E1008]Reached timeout=3ms @47.101.88.33:80, 同样的url构建get是可以成功的,我用curl去构建head请求是可以的 **To R

[GitHub] [incubator-brpc] alicialin commented on issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么

2019-05-13 Thread GitBox
alicialin commented on issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么 URL: https://github.com/apache/incubator-brpc/issues/755#issuecomment-491710044 感谢回复,可能我的问题没有问得比较明白。其实再BRPC 同步模型下服务使用的是bthead, 一般多线程写一个一个内存单元(比如数组)需要加锁。但是可能通过设计思路把,一个数组拆分成32个数组,那么同时写,就可以规避加锁问题。我的意思是,比如你知道服务器开了多少个线程,通过HASH 的方式,分开

[GitHub] [incubator-brpc] alicialin edited a comment on issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么

2019-05-13 Thread GitBox
alicialin edited a comment on issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么 URL: https://github.com/apache/incubator-brpc/issues/755#issuecomment-491710044 请教:多线程写问题, 一般多线程写一个内存单元(比如数组)需要加锁。但是可以通过设计思路把一个数组拆分成32个数组,那么同时写,就可以规避加锁问题,通过HASH 的方式,分开写,让1个线程写一个地方, 这样并发度就可以达到32.如果用BRPC 同步服务提供这样的功能,bthead不

[GitHub] [incubator-brpc] jamesge closed issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么

2019-05-13 Thread GitBox
jamesge closed issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么 URL: https://github.com/apache/incubator-brpc/issues/755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-brpc] jamesge commented on issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么

2019-05-13 Thread GitBox
jamesge commented on issue #755: 请教BRPC 如果请求是多线程写一个地方,需要加锁么 URL: https://github.com/apache/incubator-brpc/issues/755#issuecomment-491725005 即使消除了线程间的写-写冲突,也无法消除了读-写冲突。你先了解一下并发相关的知识,再回头思考一下这个问题吧。 This is an automated message fr

[GitHub] [incubator-brpc] haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-13 Thread GitBox
haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-491780281 请求压力大些就可以复现,我这面压测的时候网络大概是200Mbps,基本上持续压上一段时间就会出现超时现象。 This is an automated message fr

[GitHub] [incubator-brpc] jamesge commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-13 Thread GitBox
jamesge commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-491815200 这个redis-server是proxy还是什么,应该是single模式下流量都跑到一台redis-server上去了,而其他连接模式访问的是多台。这里的现象很可能就是压垮server端了。所谓“压垮”就是所有的请求都要在各层的buffer里排队,从而最终超时。这时候看client的cpu是没用的,b

[GitHub] [incubator-brpc] haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-13 Thread GitBox
haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-492102434 连接的是proxy,但是按照你的说法,那么出现超时的时候,此时redis-server是不可用的,但是我通过redis-cli连接这个proxy,各种命令畅通无阻。并且,重启redis-client进程,重新访问,立刻就不超时了。 -

[GitHub] [incubator-brpc] jamesge commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-13 Thread GitBox
jamesge commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-492103851 redis-cli,重启都不是走原来那个连接了吧。redis-server对于单个连接的处理速度未必很高 This is an automated message from

[GitHub] [incubator-brpc] haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-14 Thread GitBox
haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-492112261 重启之后,走的是新连接。但是如果这个时候不重启,我降低qps,由100qps降到1qps,依然会超时。 This is an automated message from

[GitHub] [incubator-brpc] yineima opened a new issue #765: brpc

2019-05-14 Thread GitBox
yineima opened a new issue #765: brpc URL: https://github.com/apache/incubator-brpc/issues/765 **Describe the bug (描述bug)** **To Reproduce (复现方法)** **Expected behavior (期望行为)** **Versions (各种版本)** OS: Compiler: brpc: protobuf: **Additional

[GitHub] [incubator-brpc] jamesge commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-14 Thread GitBox
jamesge commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-492117952 你提供一份可复现的client代码,及详细的复现步骤吧。 This is an automated message from the Apache Git Service.

[GitHub] [incubator-brpc] haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-14 Thread GitBox
haolujun commented on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-492156942 我这面复现步骤: 1: 每次mget 100个key,每个key的value大概为2K。 2: qps可以持续加大,可以一直加大到直到有超时错误,我这面大概是200qps。 3: 出现超时错误后,降低client的qps到1,这个时候依然会继续超时。 我这面的clien

[GitHub] [incubator-brpc] haolujun edited a comment on issue #744: Redis client长时间超时无法恢复,只能重启

2019-05-14 Thread GitBox
haolujun edited a comment on issue #744: Redis client长时间超时无法恢复,只能重启 URL: https://github.com/apache/incubator-brpc/issues/744#issuecomment-492156942 我这面复现步骤: 1: 每次mget 100个key,每个key是个整数字符串,key对应的value是大概为2K的字符串。 2: qps可以持续加大,可以一直加大到直到有超时错误,我这面大概是200qps。 3: 出现超时错误后,降低client的qps到1,这个时候

[GitHub] [incubator-brpc] skilxnTL commented on issue #765: brpc支持Prometheus收集,没有label维度的信息,类型限定是gauge

2019-05-15 Thread GitBox
skilxnTL commented on issue #765: brpc支持Prometheus收集,没有label维度的信息,类型限定是gauge URL: https://github.com/apache/incubator-brpc/issues/765#issuecomment-492574584 我理解 brpc 的 prometheus 是用来传输自己的 metric 信息的,而不是一套公开的机制,因此是不是对 counter summary 这些东西并没有什么需求,其实就是一堆统计信息 --

[GitHub] [incubator-brpc] cdjingit opened a new pull request #766: fix ssl state check failed

2019-05-15 Thread GitBox
cdjingit opened a new pull request #766: fix ssl state check failed URL: https://github.com/apache/incubator-brpc/pull/766 f This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-brpc] cdjingit commented on issue #766: fix ssl state check failed

2019-05-15 Thread GitBox
cdjingit commented on issue #766: fix ssl state check failed URL: https://github.com/apache/incubator-brpc/pull/766#issuecomment-492605901 #658 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-brpc] haolujun opened a new issue #767: 使用redis客户端时奇怪的200ms问题

2019-05-15 Thread GitBox
haolujun opened a new issue #767: 使用redis客户端时奇怪的200ms问题 URL: https://github.com/apache/incubator-brpc/issues/767 HI 大神: 在使用brpc的redis客户端访问redis时,发现很奇怪的长尾现象。redis的耗时在200ms处有一个特别明显的断层。如下图所示,下图时间单位是us。长尾处的时间基本都是200的倍数加上一小点零头,例如200+ms,400+ms,600+ms。我使用redis客户端,connection_type = poole

[GitHub] [incubator-brpc] fengliangwang commented on issue #577: bazel编译,使用glog问题

2019-05-15 Thread GitBox
fengliangwang commented on issue #577: bazel编译,使用glog问题 URL: https://github.com/apache/incubator-brpc/issues/577#issuecomment-492895644 请问此问题是如何修复解决的? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-brpc] GTHubT opened a new issue #768: channel连接失败

2019-05-15 Thread GitBox
GTHubT opened a new issue #768: channel连接失败 URL: https://github.com/apache/incubator-brpc/issues/768 **client端初始化一个channel后保留指针,后续的rpc复用这个channel。server端不定期stop start,在某次server start后,client端channel连接不上了,Not connected to xxx yet。这个会是什么原因呢? server是正常start的,应该可以排除time_wait。** **

[GitHub] [incubator-brpc] jamesge commented on issue #767: 使用redis客户端时奇怪的200ms问题

2019-05-15 Thread GitBox
jamesge commented on issue #767: 使用redis客户端时奇怪的200ms问题 URL: https://github.com/apache/incubator-brpc/issues/767#issuecomment-492903416 1. 之前设置backup_request_ms了么 2. 有不同延时请求的比例么?(cdf) This is an automated message from the Ap

[GitHub] [incubator-brpc] jamesge commented on issue #768: channel连接失败

2019-05-15 Thread GitBox
jamesge commented on issue #768: channel连接失败 URL: https://github.com/apache/incubator-brpc/issues/768#issuecomment-492903500 在做健康检查,默认最多3秒后会连上。 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-brpc] haolujun edited a comment on issue #767: 使用redis客户端时奇怪的200ms问题

2019-05-15 Thread GitBox
haolujun edited a comment on issue #767: 使用redis客户端时奇怪的200ms问题 URL: https://github.com/apache/incubator-brpc/issues/767#issuecomment-492908319 之前没有设置过backup_request_ms,只设置了timeout_ms=1000,connection_type=pooled,max_retry=3两个参数。我自己根据日志统计过耗时比例,大概0.5%的请求会超过200ms,99.5%的请求在50ms以内,也就是说超过50ms的请求基本

[GitHub] [incubator-brpc] haolujun commented on issue #767: 使用redis客户端时奇怪的200ms问题

2019-05-15 Thread GitBox
haolujun commented on issue #767: 使用redis客户端时奇怪的200ms问题 URL: https://github.com/apache/incubator-brpc/issues/767#issuecomment-492908319 之前没有设置过backup_request_ms,只设置了timeout_ms和connection_type两个参数。我自己根据日志统计过耗时比例,大概0.5%的请求会超过200ms,99.5%的请求在50ms以内,也就是说超过50ms的请求基本上全都是200+ms,400+ms,600+ms这种。 --

[GitHub] [incubator-brpc] haolujun edited a comment on issue #767: 使用redis客户端时奇怪的200ms问题

2019-05-15 Thread GitBox
haolujun edited a comment on issue #767: 使用redis客户端时奇怪的200ms问题 URL: https://github.com/apache/incubator-brpc/issues/767#issuecomment-492908319 之前没有设置过backup_request_ms,只设置了timeout_ms=1000,connection_type=pooled,max_retry=3这三个参数。我自己根据日志统计过耗时比例,大概0.5%的请求会超过200ms,99.5%的请求在50ms以内,也就是说超过50ms的请求基

[GitHub] [incubator-brpc] GTHubT commented on issue #768: channel连接失败

2019-05-15 Thread GitBox
GTHubT commented on issue #768: channel连接失败 URL: https://github.com/apache/incubator-brpc/issues/768#issuecomment-492912731 thanks! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-brpc] GTHubT closed issue #768: channel连接失败

2019-05-15 Thread GitBox
GTHubT closed issue #768: channel连接失败 URL: https://github.com/apache/incubator-brpc/issues/768 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-brpc] gavinchou opened a new issue #769: Compilation errors caused by ssl on MacOS

2019-05-15 Thread GitBox
gavinchou opened a new issue #769: Compilation errors caused by ssl on MacOS URL: https://github.com/apache/incubator-brpc/issues/769 **Describe the bug (描述bug)** It failed to build brpc on MacOS with all dependencies given. The essence of the bug is that `config_brpc.sh` does not

[GitHub] [incubator-brpc] gavinchou opened a new pull request #770: Fix compilation errors caused by ssl on MacOS

2019-05-15 Thread GitBox
gavinchou opened a new pull request #770: Fix compilation errors caused by ssl on MacOS URL: https://github.com/apache/incubator-brpc/pull/770 Bug report: #769 Related issue: #328 #360 #666 #723 #726 According to the [instruction](https://github.com/apache/incubator-brpc/blo

[GitHub] [incubator-brpc] gavinchou commented on issue #769: Compilation errors caused by ssl on MacOS

2019-05-15 Thread GitBox
gavinchou commented on issue #769: Compilation errors caused by ssl on MacOS URL: https://github.com/apache/incubator-brpc/issues/769#issuecomment-492924503 Corresponding pull request #770 This is an automated message from th

[GitHub] [incubator-brpc] jamesge merged pull request #770: Fix compilation errors caused by ssl on MacOS

2019-05-16 Thread GitBox
jamesge merged pull request #770: Fix compilation errors caused by ssl on MacOS URL: https://github.com/apache/incubator-brpc/pull/770 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-brpc] jamesge commented on issue #770: Fix compilation errors caused by ssl on MacOS

2019-05-16 Thread GitBox
jamesge commented on issue #770: Fix compilation errors caused by ssl on MacOS URL: https://github.com/apache/incubator-brpc/pull/770#issuecomment-492957268 Thanks for the patch and detailed explanations :) This is an automate

[GitHub] [incubator-brpc] veyrony commented on issue #577: bazel编译,使用glog问题

2019-05-16 Thread GitBox
veyrony commented on issue #577: bazel编译,使用glog问题 URL: https://github.com/apache/incubator-brpc/issues/577#issuecomment-493005915 > 请问此问题是如何修复解决的? 不用改代码,编译时加上 --define=with_glog=true $ bazel build --define=with_glog=true ... ---

[GitHub] [incubator-brpc] tmqsoft opened a new issue #771: brpc服务在ClosureGuard对象析构函数中coredump问题

2019-05-16 Thread GitBox
tmqsoft opened a new issue #771: brpc服务在ClosureGuard对象析构函数中coredump问题 URL: https://github.com/apache/incubator-brpc/issues/771 部分core栈 #0 0x7f50e83b5428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54 #1 0x7f50e83b702a in __GI_abort () at abort.c:89

[GitHub] [incubator-brpc] baoxuezhao commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-05-17 Thread GitBox
baoxuezhao commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-493368665 这个PR是不是只实现了Mysql协议的client部分,有对server端做实现吗?比如用brpc server mock一个Mysql server,自定义查询处理逻辑。 -

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-05-18 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-493682641 > 这个PR是不是只实现了Mysql协议的client部分,有对server端做实现吗?比如用brpc server mock一个Mysql server,自定义查询处理逻辑。 对,只实现了c

[GitHub] [incubator-brpc] timmyyao opened a new issue #772: 对于brpc client程序,bvar是否能够禁用

2019-05-18 Thread GitBox
timmyyao opened a new issue #772: 对于brpc client程序,bvar是否能够禁用 URL: https://github.com/apache/incubator-brpc/issues/772 Hi, 请问brpc目前是否有选项支持禁用bvar记录统计的功能,主要针对一些轻量化的客户端程序,希望rpc层面更加轻量,不需要bvar提供的功能 This is an automated message fr

[GitHub] [incubator-brpc] jamesge commented on issue #772: 对于brpc client程序,bvar是否能够禁用

2019-05-19 Thread GitBox
jamesge commented on issue #772: 对于brpc client程序,bvar是否能够禁用 URL: https://github.com/apache/incubator-brpc/issues/772#issuecomment-493733362 不能,brpc本身就大量使用bvar。 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-brpc] cdjingit commented on issue #766: fix ssl state check failed

2019-05-19 Thread GitBox
cdjingit commented on issue #766: fix ssl state check failed URL: https://github.com/apache/incubator-brpc/pull/766#issuecomment-493819603 @jamesge 帮忙看下这个fix This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-brpc] zyearn opened a new pull request #773: Fix backup req using j

2019-05-19 Thread GitBox
zyearn opened a new pull request #773: Fix backup req using j URL: https://github.com/apache/incubator-brpc/pull/773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-brpc] bidai541 opened a new issue #774: How to accepted files sent from http post ?

2019-05-19 Thread GitBox
bidai541 opened a new issue #774: How to accepted files sent from http post ? URL: https://github.com/apache/incubator-brpc/issues/774 hi, Is there any way to accepted http post files by brpc? ``` # python client requests.post(url=url, files=files, data=data) ``` I found n

[GitHub] [incubator-brpc] jamesge commented on issue #774: How to accepted files sent from http post ?

2019-05-19 Thread GitBox
jamesge commented on issue #774: How to accepted files sent from http post ? URL: https://github.com/apache/incubator-brpc/issues/774#issuecomment-493838074 brpc servers do accept http post requests. You could turn on --http_verbose in the brpc server to see the http requests that it accept

[GitHub] [incubator-brpc] bidai541 commented on issue #774: How to accepted files sent from http post ?

2019-05-20 Thread GitBox
bidai541 commented on issue #774: How to accepted files sent from http post ? URL: https://github.com/apache/incubator-brpc/issues/774#issuecomment-493864108 @jamesge Thank you for answering. But how to convert request attachment into a [key,value] pair similar to the previous one

[GitHub] [incubator-brpc] yanglimingcn commented on issue #760: Mysql Prepared Statement support

2019-05-20 Thread GitBox
yanglimingcn commented on issue #760: Mysql Prepared Statement support URL: https://github.com/apache/incubator-brpc/pull/760#issuecomment-493889516 添加了mysql的prepared statement协议的支持。 目前遇到两个问题无法解决 1、prepared statement首先是在某个连接上创建一个statement id,后续操作可以根据这个statement id向这个连接发送后续的请求。同一个语句在每个

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans…

2019-05-20 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, only support text protocol now, not support trans… URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-493899866 #760 This is an automated message

[GitHub] [incubator-brpc] yanglimingcn commented on issue #692: Add Mysql Protocol, support transaction and prepared statement

2019-05-20 Thread GitBox
yanglimingcn commented on issue #692: Add Mysql Protocol, support transaction and prepared statement URL: https://github.com/apache/incubator-brpc/pull/692#issuecomment-493910189 #760 This is an automated message from the

[GitHub] [incubator-brpc] yanglimingcn commented on issue #722: Mysql transaction

2019-05-20 Thread GitBox
yanglimingcn commented on issue #722: Mysql transaction URL: https://github.com/apache/incubator-brpc/pull/722#issuecomment-493910319 #760 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-brpc] yanglimingcn commented on issue #760: Mysql Prepared Statement support

2019-05-20 Thread GitBox
yanglimingcn commented on issue #760: Mysql Prepared Statement support URL: https://github.com/apache/incubator-brpc/pull/760#issuecomment-493910525 #722 #692 This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-brpc] bidai541 removed a comment on issue #774: How to accepted files sent from http post ?

2019-05-20 Thread GitBox
bidai541 removed a comment on issue #774: How to accepted files sent from http post ? URL: https://github.com/apache/incubator-brpc/issues/774#issuecomment-493864108 @jamesge Thank you for answering. But how to convert request attachment into a [key,value] pair similar to the prev

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285529883 ## File path: src/bthread/bthread.h ## @@ -26,7 +26,7 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285532817 ## File path: src/bthread/bthreadxx.h ## @@ -0,0 +1,284 @@ +

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285531320 ## File path: src/bthread/bthreadxx.h ## @@ -0,0 +1,284 @@ +

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285530381 ## File path: docs/cn/bthread_or_not.md ## @@ -50,6 +50,19 @

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285532272 ## File path: src/bthread/bthreadxx.h ## @@ -0,0 +1,284 @@ +

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285531728 ## File path: src/bthread/bthreadxx.h ## @@ -0,0 +1,284 @@ +

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285535562 ## File path: src/bthread/bthread.h ## @@ -26,7 +26,7 @@

[GitHub] [incubator-brpc] jasonszang commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jasonszang commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#issuecomment-493939291 @jamesge Hi Ge, thanks a lot for your review. I'll consider and fix these issues except the

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

2019-05-20 Thread GitBox
jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r285535562 ## File path: src/bthread/bthread.h ## @@ -26,7 +26,7 @@

[GitHub] [incubator-brpc] FearedHeart commented on issue #468: brpc的跨域支持怎么设置呢?

2019-05-20 Thread GitBox
FearedHeart commented on issue #468: brpc的跨域支持怎么设置呢? URL: https://github.com/apache/incubator-brpc/issues/468#issuecomment-493966838 在返回请求之前,设置response的header,对于跨域请求主要是下面3个。详细参见:https://developer.mozilla.org/zh-CN/docs/Web/HTTP/Access_control_CORS ``` cntl->http_response().SetHe

[GitHub] [incubator-brpc] zyearn opened a new pull request #775: Fix typo in gflags version

2019-05-20 Thread GitBox
zyearn opened a new pull request #775: Fix typo in gflags version URL: https://github.com/apache/incubator-brpc/pull/775 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-brpc] kevinmgyu commented on issue #400: brpc如何实现一来多回,也就是推送?

2019-05-21 Thread GitBox
kevinmgyu commented on issue #400: brpc如何实现一来多回,也就是推送? URL: https://github.com/apache/incubator-brpc/issues/400#issuecomment-494288183 websocket 现在支持吗 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-brpc] lwmonster commented on issue #763: rpc 请求卡住了,不超时

2019-05-21 Thread GitBox
lwmonster commented on issue #763: rpc 请求卡住了,不超时 URL: https://github.com/apache/incubator-brpc/issues/763#issuecomment-494322319 大概知道原因了, 自己的 pthread 和 brpc 的 pthread 互相等待,造成死锁。 This is an automated message from the Apache Git

<    1   2   3   4   5   6   7   8   9   10   >