[GitHub] [incubator-brpc] zyearn opened a new pull request #776: transmit discovery metadata into tag field of ServerNode

zyearn opened a new pull request #776: transmit discovery metadata into tag field of ServerNode URL: https://github.com/apache/incubator-brpc/pull/776 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #776: transmit discovery metadata into tag field of ServerNode

jamesge commented on a change in pull request #776: transmit discovery metadata into tag field of ServerNode URL: https://github.com/apache/incubator-brpc/pull/776#discussion_r285982336 ## File path: src/brpc/policy/discovery_naming_service.cpp ## @@ -163,6 +165,16 @@ int

[GitHub] [incubator-brpc] better629 commented on issue #2: 只支持c++？python？java？

better629 commented on issue #2: 只支持c++？python？java？ URL: https://github.com/apache/incubator-brpc/issues/2#issuecomment-494619938 没有支持Python版的吗 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-brpc] jamesge merged pull request #775: Fix typo in gflags version

jamesge merged pull request #775: Fix typo in gflags version URL: https://github.com/apache/incubator-brpc/pull/775 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #773: Fix backup req using h2

jamesge commented on a change in pull request #773: Fix backup req using h2 URL: https://github.com/apache/incubator-brpc/pull/773#discussion_r286767673 ## File path: src/brpc/stream_creator.h ## @@ -66,11 +66,9 @@ class StreamUserData { // Params: // sending_so

[GitHub] [incubator-brpc] jamesge commented on issue #766: fix ssl state check failed

jamesge commented on issue #766: fix ssl state check failed URL: https://github.com/apache/incubator-brpc/pull/766#issuecomment-495058867 @cdjingit 这个改法我觉得解决的不是root cause This is an automated message from the Apache Git Servic

[GitHub] [incubator-brpc] jamesge merged pull request #754: add explicit key word for AdaptiveXXX

jamesge merged pull request #754: add explicit key word for AdaptiveXXX URL: https://github.com/apache/incubator-brpc/pull/754 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-brpc] jamesge merged pull request #748: Fix a typo in bvar_c++.md

jamesge merged pull request #748: Fix a typo in bvar_c++.md URL: https://github.com/apache/incubator-brpc/pull/748 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-brpc] jamesge closed pull request #741: make get_or_new_task_control more simple

jamesge closed pull request #741: make get_or_new_task_control more simple URL: https://github.com/apache/incubator-brpc/pull/741 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-brpc] jamesge merged pull request #729: Fix typo

jamesge merged pull request #729: Fix typo URL: https://github.com/apache/incubator-brpc/pull/729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #741: make get_or_new_task_control more simple

jamesge commented on a change in pull request #741: make get_or_new_task_control more simple URL: https://github.com/apache/incubator-brpc/pull/741#discussion_r286768729 ## File path: src/bthread/bthread.cpp ## @@ -67,31 +70,28 @@ inline TaskControl* get_task_control() {

[GitHub] [incubator-brpc] jamesge commented on issue #723: fix build scripts under mac os env and add building section for README

jamesge commented on issue #723: fix build scripts under mac os env and add building section for README URL: https://github.com/apache/incubator-brpc/pull/723#issuecomment-495059968 之前的几个PR可能已经修复了一些相关问题，现在看看是否还有必要保留这个PR @wenweihu86

[GitHub] [incubator-brpc] jamesge merged pull request #776: transmit discovery metadata into tag field of ServerNode

jamesge merged pull request #776: transmit discovery metadata into tag field of ServerNode URL: https://github.com/apache/incubator-brpc/pull/776 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-brpc] old-bear commented on issue #766: fix ssl state check failed

old-bear commented on issue #766: fix ssl state check failed URL: https://github.com/apache/incubator-brpc/pull/766#issuecomment-495079928 看了下代码，有可能触发路径是这样的： 1. socket在成功connect后，后台启动`KeepWrite`准备往里写： > https://github.com/apache/incubator-brpc/blob/8fe8640e2f95a0e508f3070b086b7b25

[GitHub] [incubator-brpc] old-bear commented on issue #766: fix ssl state check failed

old-bear commented on issue #766: fix ssl state check failed URL: https://github.com/apache/incubator-brpc/pull/766#issuecomment-495082523 > 看了下代码，有可能触发路径是这样的： > > 1. socket在成功connect后，后台启动`KeepWrite`准备往里写： > > > https://github.com/apache/incubator-brpc/blob/8fe8640e2f95a0e508

[GitHub] [incubator-brpc] cdjingit commented on issue #766: fix ssl state check failed

cdjingit commented on issue #766: fix ssl state check failed URL: https://github.com/apache/incubator-brpc/pull/766#issuecomment-495082882 @jamesge @old-bear 这个问题之前有个fix相似，就是启动health check前，认为已经没有socket write了，否则socket引用计数不是2（通过WaitAndReset(2)）。但有一种可能是socket的从naming service删除了（socket 引用计

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r286771444 ## File path: src/bthread/condition_variable.cpp ## @@ -138,

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r286769974 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r286800107 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r286800855 ## File path: src/bthread/condition_variable.h ## @@ -13,91

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r286770094 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247 @@

[GitHub] [incubator-brpc] cuisonghui commented on issue #697: 客户端出现大量timeout

cuisonghui commented on issue #697: 客户端出现大量timeout URL: https://github.com/apache/incubator-brpc/issues/697#issuecomment-495126886 @jamesge 目前在使用ParallelChannel半同步模式，假如有一个下游节点出问题了，用什么方法可以知道？目前ParallelChannel是提供map和merge函数的，可以干预请求和返回，但是如果失败的，有这样的回调函数吗。 -

[GitHub] [incubator-brpc] jamesge merged pull request #773: Fix backup req using h2

jamesge merged pull request #773: Fix backup req using h2 URL: https://github.com/apache/incubator-brpc/pull/773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] yanglimingcn edited a comment on issue #760: MySQL Prepared Statement support

yanglimingcn edited a comment on issue #760: MySQL Prepared Statement support URL: https://github.com/apache/incubator-brpc/pull/760#issuecomment-493889516 添加了mysql的prepared statement协议的支持。 遇到的两个问题解决方案如下： 1、prepared statement首先是在某个连接上创建一个statement id，后续操作可以根据这个statement id向这个连接发送后续的请求

[GitHub] [incubator-brpc] zyearn opened a new pull request #777: separate cmake-compilation into different travis task

zyearn opened a new pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-brpc] cdjingit closed issue #747: BuiltinService不支持安全认证，可能导致一些支持热加载的gflag配置项被无端篡改

cdjingit closed issue #747: BuiltinService不支持安全认证，可能导致一些支持热加载的gflag配置项被无端篡改 URL: https://github.com/apache/incubator-brpc/issues/747 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-brpc] zyearn opened a new pull request #778: Dummy pr, just for test

zyearn opened a new pull request #778: Dummy pr, just for test URL: https://github.com/apache/incubator-brpc/pull/778 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287258094 ## File path: src/bthread/condition_variable.cpp ## @@ -1

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287259511 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287259820 ## File path: src/bthread/condition_variable.h ## @@ -13,

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287269978 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287269898 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287258094 ## File path: src/bthread/condition_variable.cpp ## @@ -1

[GitHub] [incubator-brpc] jasonszang commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#issuecomment-495532001 @jamesge Something went wrong building mesalink on Travis CI, which is obviously not the res

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287279417 ## File path: src/bthread/condition_variable.cpp ## @@ -138,

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287281730 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287286075 ## File path: src/bthread/mtx_cv_base.h ## @@ -0,0 +1,383 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287286325 ## File path: src/bthread/mtx_cv_base.h ## @@ -0,0 +1,383 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287285953 ## File path: src/bthread/mtx_cv_base.h ## @@ -0,0 +1,383 @@

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287288580 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287289917 ## File path: src/bthread/mtx_cv_base.h ## @@ -0,0 +1,383

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287288580 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,247

[GitHub] [incubator-brpc] zyearn commented on issue #629: tls: MesaLink TLS backend for RPC over TLS

zyearn commented on issue #629: tls: MesaLink TLS backend for RPC over TLS URL: https://github.com/apache/incubator-brpc/pull/629#issuecomment-49191 @kevinis There is a mesalink build problem in the latest [build](https://travis-ci.org/apache/incubator-brpc/jobs/536646641). Please have

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287286694 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,245 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287288258 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,245 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287287177 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,245 @@

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287303236 ## File path: src/bthread/mtx_cv_base.h ## @@ -0,0 +1,383 @@

[GitHub] [incubator-brpc] zyearn closed pull request #778: Dummy pr, just for test

zyearn closed pull request #778: Dummy pr, just for test URL: https://github.com/apache/incubator-brpc/pull/778 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #777: separate cmake-compilation into different travis task

zyearn commented on a change in pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#discussion_r287338451 ## File path: build_in_travis_ci.sh ## @@ -21,39 +21,30 @@ runcmd(){ echo "build combina

[GitHub] [incubator-brpc] zyearn commented on issue #98: Add thrift protocol for brpc.

zyearn commented on issue #98: Add thrift protocol for brpc. URL: https://github.com/apache/incubator-brpc/pull/98#issuecomment-495606822 @kenshinxf After running thrift installation command in .travis.yml, running make in thrift example is failed now. Please have a check, thanks

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r287377631 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,245

[GitHub] [incubator-brpc] jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on a change in pull request #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#discussion_r28734 ## File path: src/bthread/bthread_cxx.h ## @@ -0,0 +1,245

[GitHub] [incubator-brpc] jasonszang commented on issue #777: separate cmake-compilation into different travis task

jasonszang commented on issue #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#issuecomment-49569 Hi! Is there something wrong with mesalink currently? My PR fails because of unabling to build mesalink and I for sure did

[GitHub] [incubator-brpc] jasonszang edited a comment on issue #777: separate cmake-compilation into different travis task

jasonszang edited a comment on issue #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#issuecomment-49569 Hi! Is there something wrong with mesalink currently? My PR fails because of unabling to build mesalink and I for s

[GitHub] [incubator-brpc] jasonszang edited a comment on issue #777: separate cmake-compilation into different travis task

jasonszang edited a comment on issue #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#issuecomment-49569 Hi! I saw you did a test pr and then commented out mesalink from travis config. Is there something wrong with mesal

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #777: separate cmake-compilation into different travis task

jamesge commented on a change in pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#discussion_r287549045 ## File path: build_in_travis_ci.sh ## @@ -21,39 +21,30 @@ runcmd(){ echo "build combin

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #777: separate cmake-compilation into different travis task

jamesge commented on a change in pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#discussion_r287549058 ## File path: .travis.yml ## @@ -25,8 +26,7 @@ install: - sudo apt-get install -qq realpa

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #777: separate cmake-compilation into different travis task

zyearn commented on a change in pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#discussion_r287551513 ## File path: .travis.yml ## @@ -25,8 +26,7 @@ install: - sudo apt-get install -qq realpat

[GitHub] [incubator-brpc] zyearn commented on issue #777: separate cmake-compilation into different travis task

zyearn commented on issue #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#issuecomment-495856819 > Hi! I saw you did a test pr and then commented out mesalink from travis config. Is there something wrong with mesalink curre

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #777: separate cmake-compilation into different travis task

zyearn commented on a change in pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#discussion_r287558961 ## File path: build_in_travis_ci.sh ## @@ -21,39 +21,30 @@ runcmd(){ echo "build combina

[GitHub] [incubator-brpc] zyearn commented on issue #98: Add thrift protocol for brpc.

zyearn commented on issue #98: Add thrift protocol for brpc. URL: https://github.com/apache/incubator-brpc/pull/98#issuecomment-495907430 Fix it in https://github.com/apache/incubator-brpc/pull/777 This is an automated message

[GitHub] [incubator-brpc] jasonszang commented on issue #777: separate cmake-compilation into different travis task

jasonszang commented on issue #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#issuecomment-495968160 Can we depend on a pre-built mesalink on travis instead? Is it necessary that we build mesalink from source?

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #777: separate cmake-compilation into different travis task

jamesge commented on a change in pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#discussion_r287634788 ## File path: build_in_travis_ci.sh ## @@ -21,39 +21,30 @@ runcmd(){ echo "build combin

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #777: separate cmake-compilation into different travis task

zyearn commented on a change in pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777#discussion_r287636885 ## File path: build_in_travis_ci.sh ## @@ -21,39 +21,30 @@ runcmd(){ echo "build combina

[GitHub] [incubator-brpc] jamesge merged pull request #777: separate cmake-compilation into different travis task

jamesge merged pull request #777: separate cmake-compilation into different travis task URL: https://github.com/apache/incubator-brpc/pull/777 This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-brpc] jamesge commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jamesge commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#issuecomment-496109539 Please rebase on the master head to see if the travis-ci gets passed. -

[GitHub] [incubator-brpc] kevinmgyu opened a new issue #779: brpc 是否支持 访问tcp server的tcp client，如何实现兼容到框架中去

kevinmgyu opened a new issue #779: brpc 是否支持 访问tcp server的tcp client，如何实现兼容到框架中去 URL: https://github.com/apache/incubator-brpc/issues/779 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 是 **Describe the solution you'd like (描述你期望的解决方法)** 我需要在brpc服务器中访问一个

[GitHub] [incubator-brpc] xmm1989218 opened a new issue #780: 啥时候开源关于PROTOCOL_HADOOP_SERVER_RPC这个的实现

xmm1989218 opened a new issue #780: 啥时候开源关于PROTOCOL_HADOOP_SERVER_RPC这个的实现 URL: https://github.com/apache/incubator-brpc/issues/780 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** **Describe the solution you'd like (描述你期望的解决方法)** **Describe alternat

[GitHub] [incubator-brpc] zyearn opened a new pull request #781: fix wrong pointer in processing http response after h2goaway

zyearn opened a new pull request #781: fix wrong pointer in processing http response after h2goaway URL: https://github.com/apache/incubator-brpc/pull/781 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-brpc] lingbin closed issue #751: There is a useless check in variable.cpp

lingbin closed issue #751: There is a useless check in variable.cpp URL: https://github.com/apache/incubator-brpc/issues/751 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-brpc] yongs207 opened a new issue #782: RDMA的代码为什么没有何如到master分支

yongs207 opened a new issue #782: RDMA的代码为什么没有何如到master分支 URL: https://github.com/apache/incubator-brpc/issues/782 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** **Describe the solution you'd like (描述你期望的解决方法)** **Describe alternatives you've consi

[GitHub] [incubator-brpc] jamesge merged pull request #781: fix wrong pointer in processing http response after h2goaway

jamesge merged pull request #781: fix wrong pointer in processing http response after h2goaway URL: https://github.com/apache/incubator-brpc/pull/781 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-brpc] linlianmin commented on issue #699: Fail to select server from list

linlianmin commented on issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699#issuecomment-496440508 我也遇见了，另外，使用la和rr，random都不行，请问如何解决啊 This is an automated message from the Apach

[GitHub] [incubator-brpc] jamesge commented on issue #699: Fail to select server from list

jamesge commented on issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699#issuecomment-496477126 @linlianmin 非la算法遇到这个问题一般是server全挂了。 This is an automated message from the Apache

[GitHub] [incubator-brpc] linlianmin commented on issue #699: Fail to select server from list

linlianmin commented on issue #699: Fail to select server from list URL: https://github.com/apache/incubator-brpc/issues/699#issuecomment-496538613 我用的http:// ，使用rr算法，可以确保源站没挂，现在的现象是 有成功，也有失败，看失败的记录就是fail to select server，使用的pooled，感觉有点象pooled连接池里连接被用光了，没有排队，直接返回错误了，有空闲就又继续请求？ ---

[GitHub] [incubator-brpc] linlianmin opened a new issue #783: [E112]Fail to select server from http://xxx.com

linlianmin opened a new issue #783: [E112]Fail to select server from http://xxx.com URL: https://github.com/apache/incubator-brpc/issues/783 **Describe the bug (描述bug)** channel复用，init一次，使用http:// ，rr算法，pooled连接池方式，流量比较大的时候，就会产生大量的[E112]Fail to select server from http://xxx.com，但是服务是正常

[GitHub] [incubator-brpc] jasonszang opened a new pull request #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang opened a new pull request #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784 ... so that we don't build a world of huge binaries that is forced to take every single piece of object files from those

[GitHub] [incubator-brpc] eric-buaa-cn commented on a change in pull request #741: make get_or_new_task_control more simple

eric-buaa-cn commented on a change in pull request #741: make get_or_new_task_control more simple URL: https://github.com/apache/incubator-brpc/pull/741#discussion_r288168083 ## File path: src/bthread/bthread.cpp ## @@ -67,31 +70,28 @@ inline TaskControl* get_task_control(

[GitHub] [incubator-brpc] jasonszang commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset

jasonszang commented on issue #749: Modernizing bthread: modern style C++ bthread support library, the essential subset URL: https://github.com/apache/incubator-brpc/pull/749#issuecomment-496758807 Travis looks good now @jamesge

[GitHub] [incubator-brpc] skilxnTL opened a new issue #786: 单客户端对单sever发压无法压满qps

skilxnTL opened a new issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786 56逻辑core的机器*2，一台做server，一台做 Client，16Byte无随机延迟的 Echo 服务，使用rpc_press 发压，client 和 server 均无法打满单机的 CPU，此时单 client 大概能发出 50w 左右的 qps，通过 多client * 多机器 发压，能够将server打到近400w的qps，瓶颈在单条 TC

[GitHub] [incubator-brpc] skilxnTL opened a new issue #785: 单客户端对单sever发压无法压满qps

skilxnTL opened a new issue #785: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/785 56逻辑core的机器*2，一台做server，一台做 Client，16Byte无随机延迟的 Echo 服务，使用rpc_press 发压，client 和 server 均无法打满单机的 CPU，此时单 client 大概能发出 50w 左右的 qps，通过 多client * 多机器 发压，能够将server打到近400w的qps，瓶颈在单条 TC

[GitHub] [incubator-brpc] jamesge commented on issue #786: 单客户端对单sever发压无法压满qps

jamesge commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-496779073 协议和连接方式分别是什么？如果是单连接，最大吞吐是会受限的，因为要争抢一个tcp连接。真实场景中一个client往往连多台server，这个限制一般不会触及。 This is an

[GitHub] [incubator-brpc] skilxnTL commented on issue #786: 单客户端对单sever发压无法压满qps

skilxnTL commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-496790960 忘记提及，协议走的就是默认的，应该是baidu_std_protocol，连接方式没有特别配置，应该也是默认的。只是好奇这个瓶颈在哪里，看来应该是单链接带来的？～ This is

[GitHub] [incubator-brpc] zyearn commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

zyearn commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496806693 Hi, the cxxflags used in shared_lib and test are different, please make sure that UTs generated by cmake can

[GitHub] [incubator-brpc] jamesge commented on issue #786: 单客户端对单sever发压无法压满qps

jamesge commented on issue #786: 单客户端对单sever发压无法压满qps URL: https://github.com/apache/incubator-brpc/issues/786#issuecomment-496814947 可以尝试增加client端的线程数 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496818695 Ah, I see you require that some different cxxflags be used to compile non-test code for your unit tests

[GitHub] [incubator-brpc] scottzzq opened a new issue #787: brpc single模式下无法摘掉故障机器

scottzzq opened a new issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787 **Describe the bug (描述bug)** 使用brpc client访问下游服务，如果下游服务某台机器故障(模拟故障可以用iptables命令直接将目标ip数据包过滤掉)，这个时候brpc client仍然向故障机器发送请求，根本原因是brpc针对某个socket上出现的超时请求没有做额外的探测工作。如果是临时的出现的几次

[GitHub] [incubator-brpc] jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496818695 Ah, I see you require that some different cxxflags be used to compile non-test code for your unit

[GitHub] [incubator-brpc] jamesge commented on issue #787: brpc single模式下无法摘掉故障机器

jamesge commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-496820028 可以试验下[熔断](https://github.com/apache/incubator-brpc/blob/master/docs/cn/circuit_breaker.md) ---

[GitHub] [incubator-brpc] jamesge commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jamesge commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496821857 UT may turn on additional debugging macros to check consistencies and would like the release build being un

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496828743 If creating binaries that have different logic and behave differently for UT cannot be avoided then perh

[GitHub] [incubator-brpc] scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器

scottzzq commented on issue #787: brpc single模式下无法摘掉故障机器 URL: https://github.com/apache/incubator-brpc/issues/787#issuecomment-496832828 https://github.com/apache/incubator-brpc/blob/master/src/brpc/socket.cpp#L878 这一行直接调用了SetFailed，内部重新设置fd=-1, 理论上会执行到这一行https://github.com/apache/incubat

[GitHub] [incubator-brpc] zyearn commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

zyearn commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496844520 The logic in UT and release is not strict different but has a relation of Inclusion. It means that if UT is

[GitHub] [incubator-brpc] jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang commented on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496851874 Then you need to make sure this relation of inclusion is always true by writing good tests always. Might

[GitHub] [incubator-brpc] jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ...

jasonszang edited a comment on issue #784: Improve cmake: make unit tests link against the brpc shared library ... URL: https://github.com/apache/incubator-brpc/pull/784#issuecomment-496851874 Then you need to make sure this relation of inclusion is always true by writing good codes and te

[GitHub] [incubator-brpc] xmm1989218 closed issue #780: 啥时候开源关于PROTOCOL_HADOOP_SERVER_RPC这个的实现

xmm1989218 closed issue #780: 啥时候开源关于PROTOCOL_HADOOP_SERVER_RPC这个的实现 URL: https://github.com/apache/incubator-brpc/issues/780 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

zyearn commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r288497042 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::Circu

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r288506093 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::C

[GitHub] [incubator-brpc] TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

TousakaRin commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r288506093 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::C

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy

zyearn commented on a change in pull request #701: CircuitBreaker： fix race condition， adjust reset policy URL: https://github.com/apache/incubator-brpc/pull/701#discussion_r288509691 ## File path: src/brpc/circuit_breaker.cpp ## @@ -162,16 +164,21 @@ CircuitBreaker::Circu

<    2   3   4   5   6   7   8   9   10   11   >