[GitHub] [brpc] owenliang commented on issue #1666: 使用h2:grpc当server端服务（grpc）持续不可用时，client端（brpc）陷入死循环
owenliang commented on issue #1666: URL: https://github.com/apache/brpc/issues/1666#issuecomment-1397932105 的确如此，随便写个demo，让服务端死掉重启，客户端再也不连了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wasphin merged pull request #2096: Install and pack brpc tools
wasphin merged PR #2096: URL: https://github.com/apache/brpc/pull/2096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wasphin opened a new pull request, #2096: Install and pack brpc tools
wasphin opened a new pull request, #2096: URL: https://github.com/apache/brpc/pull/2096 ### What problem does this PR solve? Issue Number: NONE Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): N/A - Breaking backward compatibility(向后兼容性): N/A --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wasphin merged pull request #2095: Update release steps for TLP
wasphin merged PR #2095: URL: https://github.com/apache/brpc/pull/2095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wasphin opened a new pull request, #2095: Update release steps for TLP
wasphin opened a new pull request, #2095: URL: https://github.com/apache/brpc/pull/2095 ### What problem does this PR solve? Issue Number: #2078 Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): N/A - Breaking backward compatibility(向后兼容性): N/A --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] wasphin commented on pull request #125: Fix download links
wasphin commented on PR #125: URL: https://github.com/apache/brpc-website/pull/125#issuecomment-1396567478 好像是乌龙，校验文件没使用 dlcdn。 等下次发版时我再改回来。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] dandyhuang commented on issue #2048: 用户态tcp实现是否会开源呢？
dandyhuang commented on issue #2048: URL: https://github.com/apache/brpc/issues/2048#issuecomment-1396331572 > 在7月份的视频中看到介绍说brpc实现了用户态tcp、去掉了bthread，目前是否已经上线使用？这个feature是否会开源呢？  哪个视频呢，能分享一下不。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] jenrryyou commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR
jenrryyou commented on code in PR #2086:
URL: https://github.com/apache/brpc/pull/2086#discussion_r1073469472
##
src/bthread/butex.cpp:
##
@@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) {
bool erase_from_butex(ButexWaiter*, bool, WaiterState);
-int wait_pthread(ButexPthreadWaiter& pw, timespec* ptimeout) {
+int wait_pthread(ButexPthreadWaiter& pw, const timespec* abstime) {
+timespec * ptimeout = NULL;
+timespec timeout;
+int64_t timeout_us;
+
+if (abstime != NULL) {
+timeout_us = butil::timespec_to_microseconds(*abstime) -
butil::gettimeofday_us();
+if (timeout_us < MIN_SLEEP_US) {
+errno = ETIMEDOUT;
+return -1;
+}
+timeout = butil::microseconds_to_timespec(timeout_us);
+ptimeout =
+}
+
while (true) {
const int rc = futex_wait_private(, PTHREAD_NOT_SIGNALLED,
ptimeout);
Review Comment:
已修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] jenrryyou commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR
jenrryyou commented on code in PR #2086:
URL: https://github.com/apache/brpc/pull/2086#discussion_r1073469170
##
src/bthread/butex.cpp:
##
@@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) {
bool erase_from_butex(ButexWaiter*, bool, WaiterState);
-int wait_pthread(ButexPthreadWaiter& pw, timespec* ptimeout) {
+int wait_pthread(ButexPthreadWaiter& pw, const timespec* abstime) {
+timespec * ptimeout = NULL;
+timespec timeout;
+int64_t timeout_us;
+
+if (abstime != NULL) {
+timeout_us = butil::timespec_to_microseconds(*abstime) -
butil::gettimeofday_us();
+if (timeout_us < MIN_SLEEP_US) {
+errno = ETIMEDOUT;
+return -1;
Review Comment:
已经修改，感谢指出
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] zhangke96 commented on pull request #1808: Mongo client
zhangke96 commented on PR #1808: URL: https://github.com/apache/brpc/pull/1808#issuecomment-1386769913 > @zhangke96 mongoclient怎么样了, 我们现在也有这样的需求 最近没弄了，demo可以跑的。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] FightingCoder opened a new issue, #2094: 约千分之一的请求server耗时严重
FightingCoder opened a new issue, #2094: URL: https://github.com/apache/brpc/issues/2094 **Describe the bug (描述bug)** io-bound型服务，服务压力很低。查看工作线程数以及cpu使用程度都没有问题。bthread_worker_count:9，bthread_worker_usage维持在1.5以下。process_cpu_usage 0.5以下。排除锁的嫌疑。 使用rpcz发现耗时大的请求都卡在了最后Leave阶段，以下是其中一个，Leave core.HttpService.HotSearch阶段耗时350ms： 2023/01/18-14:58:29.320573 Received request(1378) from 127.0.0.1:53900 http log_id=0 trace=99c59dc851f7088b span=c51c916151762d93 14:58:29.320625.52 Processing the request in a new bthread 14:58:29.320672.47 Enter core.HttpService.HotSearch 14:58:29.320753.81 Requesting redis-server@xxx redis log_id=0 call_id=7142530642355 trace=99c59dc851f7088b span=[c51c916151762d94](http://xxx/rpcz?trace=99c59dc851f7088b=c51c916151762d94) 14:58:29.320770.17 Requested(49) [1] 14:58:29.322242. 1472 Received response(14) of request[1] 14:58:29.322252.10 Processing the response in a new bthread 14:58:29.322256. 4 Back to user's callsite ... 14:58:29.468671.17 Requested(467) [1] 14:58:29.469738. 1067 Received response(5) of request[1] 14:58:29.469747. 9 Processing the response in a new bthread 14:58:29.469751. 4 Back to user's callsite 14:58:29.820964.351213 Leave core.HttpService.HotSearch 14:58:29.821091. 127 Responded(5280) **To Reproduce (复现方法)** **Expected behavior (期望行为)** **Versions (各种版本)** OS: CentOS Linux release 7.9.2009 Compiler: gcc8 brpc: 0.9.7 protobuf: 3.19 **Additional context/screenshots (更多上下文/截图)** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn commented on pull request #2093: Add Mysql Protocol
yanglimingcn commented on PR #2093: URL: https://github.com/apache/brpc/pull/2093#issuecomment-1385095711 mysql的prepared statement协议的支持。 遇到的两个问题解决方案如下： 1、prepared statement首先是在某个连接上创建一个statement id，后续操作可以根据这个statement id向这个连接发送后续的请求。同一个语句在每个连接上的statement id是不同的。在pooled模式下，每次RPC选择的连接是不同的，所以需要记录SocketId和statement id的关系，我们这里称为id_map。但是一个SocketId有可能关闭，然后又重新建立起来，这个新SocketId对应的连接没有这个statement id。id_map没有机制可以做到同步更新，保存的SocketId与statement id关系信息是旧的关系。这样就会产生问题。 这个问题的修改方式是，给socketid对应的fd一个唯一的版本号，每次通过stmt_id找到socketid的时候对比一下版本号，版本号一致说明fd没有变化，版本号不一致说明fd变化过。 2、目前还不能支持single模式，唯一的原因就是auth部分，正常auth多个请求会竞争发送auth，后续操作就不需要发送auth了，auth不用等待服务端应答，就可以让其他请求继续发送。但是mysql的auth和这个逻辑不通，mysql的auth首先接收mysql-server发送过来的salt，客户端根据salt加密密码，再把加密后的密码发送给服务端。这样的逻辑如果不等待服务端应答就解锁别的请求，就会出现发送auth的请求落后于正常的请求，导致消息乱序。 这个目前就先不支持single模式了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn opened a new pull request, #2093: Add Mysql Protocol
yanglimingcn opened a new pull request, #2093: URL: https://github.com/apache/brpc/pull/2093 Add Mysql Protocol, support text protocol, transaction, support prepare statement. issue #209 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn closed pull request #692: Add Mysql Protocol, support transaction and prepared statement
yanglimingcn closed pull request #692: Add Mysql Protocol, support transaction and prepared statement URL: https://github.com/apache/brpc/pull/692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn closed pull request #722: Mysql transaction
yanglimingcn closed pull request #722: Mysql transaction URL: https://github.com/apache/brpc/pull/722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn closed pull request #760: MySQL Prepared Statement support
yanglimingcn closed pull request #760: MySQL Prepared Statement support URL: https://github.com/apache/brpc/pull/760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] serverglen closed issue #2013: 基于请求延迟的并发控制
serverglen closed issue #2013: 基于请求延迟的并发控制 URL: https://github.com/apache/brpc/issues/2013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm merged pull request #2091: add timeout concurrency limiter doc
wwbmmm merged PR #2091: URL: https://github.com/apache/brpc/pull/2091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn commented on a diff in pull request #2091: add timeout concurrency limiter doc
yanglimingcn commented on code in PR #2091: URL: https://github.com/apache/brpc/pull/2091#discussion_r1071768243 ## docs/cn/timeout_concurrency_limiter.md: ## @@ -0,0 +1,23 @@ +# 基于请求超时时间的限流 + +服务的处理能力是有客观上限的。当请求速度超过服务的处理速度时，服务就会过载。 + +如果服务持续过载，会导致越来越多的请求积压，最终所有的请求都必须等待较长时间才能被处理，从而使整个服务处于瘫痪状态。 + +与之相对的，如果直接拒绝掉一部分请求，反而能够让服务能够"及时"处理更多的请求。对应的方法就是[设置最大并发](https://github.com/brpc/brpc/blob/master/docs/cn/server.md#%E9%99%90%E5%88%B6%E6%9C%80%E5%A4%A7%E5%B9%B6%E5%8F%91)。 + + +## 算法描述 +在服务正常运营过程中，流量的增减、请求体的大小变化，磁盘的顺序、随机读写，这些都会影响请求的延迟，用户一般情况下不希望请求延迟的波动造成错误，即使会有一些请求的排队造成请求延迟增加，因此，一般用户设置的请求超时时间都会是服务平均延迟的3至4倍。基于请求超时时间的限流是根据统计服务平均延迟和请求设置的超时时间相比较，来估算请求是否能够在设置的超时时间内完成处理，如果能够能完成则接受请求，如果不能完成则拒绝请求。由于统计服务平均延迟和当前请求的实际延迟会有一定的时间差，因此需要设置一个比较宽泛的最大并发度，保证服务不会因为突然的慢请求造成短时间内服务堆积过多的请求。 + +## 开启方法 +目前只有method级别支持自适应限流。如果要为某个method开启自适应限流，只需要将它的最大并发设置为"timeout"即可，如果客户端没有开启FLAGS_baidu_std_protocol_deliver_timeout_ms，可以设置FLAGS_timeout_cl_default_timeout_ms来调整一个默认的请求超时时间，可以设置FLAGS_timeout_cl_max_concurrency来调整最大并发度。 Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm merged pull request #2092: Update oncall.md
wwbmmm merged PR #2092: URL: https://github.com/apache/brpc/pull/2092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] lorinlee opened a new pull request, #2092: Update oncall.md
lorinlee opened a new pull request, #2092: URL: https://github.com/apache/brpc/pull/2092 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on a diff in pull request #2091: add timeout concurrency limiter doc
wwbmmm commented on code in PR #2091: URL: https://github.com/apache/brpc/pull/2091#discussion_r1071669830 ## docs/cn/timeout_concurrency_limiter.md: ## @@ -0,0 +1,23 @@ +# 基于请求超时时间的限流 + +服务的处理能力是有客观上限的。当请求速度超过服务的处理速度时，服务就会过载。 + +如果服务持续过载，会导致越来越多的请求积压，最终所有的请求都必须等待较长时间才能被处理，从而使整个服务处于瘫痪状态。 + +与之相对的，如果直接拒绝掉一部分请求，反而能够让服务能够"及时"处理更多的请求。对应的方法就是[设置最大并发](https://github.com/brpc/brpc/blob/master/docs/cn/server.md#%E9%99%90%E5%88%B6%E6%9C%80%E5%A4%A7%E5%B9%B6%E5%8F%91)。 + + +## 算法描述 +在服务正常运营过程中，流量的增减、请求体的大小变化，磁盘的顺序、随机读写，这些都会影响请求的延迟，用户一般情况下不希望请求延迟的波动造成错误，即使会有一些请求的排队造成请求延迟增加，因此，一般用户设置的请求超时时间都会是服务平均延迟的3至4倍。基于请求超时时间的限流是根据统计服务平均延迟和请求设置的超时时间相比较，来估算请求是否能够在设置的超时时间内完成处理，如果能够能完成则接受请求，如果不能完成则拒绝请求。由于统计服务平均延迟和当前请求的实际延迟会有一定的时间差，因此需要设置一个比较宽泛的最大并发度，保证服务不会因为突然的慢请求造成短时间内服务堆积过多的请求。 + +## 开启方法 +目前只有method级别支持自适应限流。如果要为某个method开启自适应限流，只需要将它的最大并发设置为"timeout"即可，如果客户端没有开启FLAGS_baidu_std_protocol_deliver_timeout_ms，可以设置FLAGS_timeout_cl_default_timeout_ms来调整一个默认的请求超时时间，可以设置FLAGS_timeout_cl_max_concurrency来调整最大并发度。 Review Comment: 自适应限流 -> 基于超时的限流？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn commented on issue #2013: 基于请求延迟的并发控制
yanglimingcn commented on issue #2013: URL: https://github.com/apache/brpc/issues/2013#issuecomment-1383927392 #2091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn opened a new pull request, #2091: add timeout concurrency limiter doc
yanglimingcn opened a new pull request, #2091: URL: https://github.com/apache/brpc/pull/2091 添加timeout concurrency limiter的文档 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] serverglen opened a new issue, #2090: 适配loongarch64架构
serverglen opened a new issue, #2090: URL: https://github.com/apache/brpc/issues/2090 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** **Describe the solution you'd like (描述你期望的解决方法)** **Describe alternatives you've considered (描述你想到的折衷方案)** **Additional context/screenshots (更多上下文/截图)** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm merged pull request #2087: add max concurrency for timeout concurrency limiter
wwbmmm merged PR #2087: URL: https://github.com/apache/brpc/pull/2087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm merged pull request #2089: WIP: fix doc && code style
wwbmmm merged PR #2089: URL: https://github.com/apache/brpc/pull/2089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] cdjingit opened a new pull request, #2089: WIP: fix doc && code style
cdjingit opened a new pull request, #2089: URL: https://github.com/apache/brpc/pull/2089 ### What problem does this PR solve? fix code style and doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm merged pull request #2088: Explicitly listing all third-part licensed files
wwbmmm merged PR #2088: URL: https://github.com/apache/brpc/pull/2088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wasphin opened a new pull request, #2088: Explicitly listing all third-part licensed files
wasphin opened a new pull request, #2088: URL: https://github.com/apache/brpc/pull/2088 ### What problem does this PR solve? Issue Number: NONE Problem Summary: ### What is changed and the side effects? Changed: Update LICENSE to list files porting from Chromium. Side effects: - Performance effects(性能影响): N/A - Breaking backward compatibility(向后兼容性): N/A --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR
wwbmmm commented on code in PR #2086:
URL: https://github.com/apache/brpc/pull/2086#discussion_r1070816953
##
src/bthread/butex.cpp:
##
@@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) {
bool erase_from_butex(ButexWaiter*, bool, WaiterState);
-int wait_pthread(ButexPthreadWaiter& pw, timespec* ptimeout) {
+int wait_pthread(ButexPthreadWaiter& pw, const timespec* abstime) {
+timespec * ptimeout = NULL;
+timespec timeout;
+int64_t timeout_us;
+
+if (abstime != NULL) {
+timeout_us = butil::timespec_to_microseconds(*abstime) -
butil::gettimeofday_us();
+if (timeout_us < MIN_SLEEP_US) {
+errno = ETIMEDOUT;
+return -1;
+}
+timeout = butil::microseconds_to_timespec(timeout_us);
+ptimeout =
+}
+
while (true) {
const int rc = futex_wait_private(, PTHREAD_NOT_SIGNALLED,
ptimeout);
Review Comment:
可以把计算ptimeout的逻辑移到while里面，futex_wait_private的前面，这样可以减少重复逻辑
##
src/bthread/butex.cpp:
##
@@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) {
bool erase_from_butex(ButexWaiter*, bool, WaiterState);
-int wait_pthread(ButexPthreadWaiter& pw, timespec* ptimeout) {
+int wait_pthread(ButexPthreadWaiter& pw, const timespec* abstime) {
+timespec * ptimeout = NULL;
+timespec timeout;
+int64_t timeout_us;
+
+if (abstime != NULL) {
+timeout_us = butil::timespec_to_microseconds(*abstime) -
butil::gettimeofday_us();
+if (timeout_us < MIN_SLEEP_US) {
+errno = ETIMEDOUT;
+return -1;
Review Comment:
这里直接return，没走erase_from_butex的逻辑，是不是不对。
##
src/bthread/butex.cpp:
##
@@ -146,13 +160,19 @@ int wait_pthread(ButexPthreadWaiter& pw, timespec*
ptimeout) {
// Acquire fence makes this thread sees changes before wakeup.
return rc;
}
-if (rc != 0 && errno == ETIMEDOUT) {
-// Note that we don't handle the EINTR from futex_wait here since
-// pthreads waiting on a butex should behave similarly as bthreads
-// which are not able to be woken-up by signals.
-// EINTR on butex is only producible by TaskGroup::interrupt().
+if (rc != 0 && ptimeout != NULL) {
+// Handle the EINTR from futex_wait
+if (errno != ETIMEDOUT)
+{
Review Comment:
{ 不用换行
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn commented on issue #2013: 基于请求延迟的并发控制
yanglimingcn commented on issue #2013: URL: https://github.com/apache/brpc/issues/2013#issuecomment-1383417016 OK，等我有时间补充一下哈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] ysj1173886760 commented on issue #845: 在aarch64下编译之后，运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况？
ysj1173886760 commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383387003 > > 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 > > 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 > > 奇怪的是在我把我自己的项目设置成Release模式构建之后，就不会出现`sched_to itself`的错误了。 > > 使用的是master的最新代码吗？ 是的。尝试使用了这个PR中的修改--在Mac下禁用了那两个函数的优化，仍然会出现问题。后来试了几次发现-O2 -O1优化下可以正常运行，-O0就会出现`sched_to itself`以及`task_group.cpp:298`出现空指针的问题。目前还不清楚原因，就在我自己的项目中用-O2先缓解这个问题了。 我是在自己的项目中将brpc作为subdirectory引入的，不清楚我的Cmake中的编译选项会不会影响到brpc的编译。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] yanglimingcn opened a new pull request, #2087: add max concurrency for timeout concurrency limiter
yanglimingcn opened a new pull request, #2087: URL: https://github.com/apache/brpc/pull/2087 基于延迟的并发控制，在average latency的统计还没有刷新的时候，有可能因为一些慢请求导致服务排队很多请求，这个最大并发的设置，可以在这种情况下保护服务不被太多的请求压垮。 @wwbmmm 请PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on issue #845: 在aarch64下编译之后，运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况？
wwbmmm commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383350427 > 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 > > 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 > > 奇怪的是在我把我自己的项目设置成Release模式构建之后，就不会出现`sched_to itself`的错误了。 使用的是master的最新代码吗？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] jenrryyou opened a new pull request, #2086: Fix butex wait_pthread handle EINTR
jenrryyou opened a new pull request, #2086: URL: https://github.com/apache/brpc/pull/2086 wait_pthread处理被信号中断的情况。 没有这个处理之前，假设butex_wait_from_pthread的timeout设置为100s，但是这个线程每隔10s会被信号中断（如正在进行profile，会定时中断采集线程堆栈），futex_wait_private会返回EINTR，导致butex_wait_from_pthread永远不会超时返回。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] ysj1173886760 commented on issue #845: 在aarch64下编译之后，运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况？
ysj1173886760 commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383136246 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 奇怪的是在我把我自己的项目设置成Release模式构建之后，就不会出现`sched_to itself`的错误了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] lorinlee merged pull request #2047: Keep bthread TaskGroup abi compatible with NDEBUG macro
lorinlee merged PR #2047: URL: https://github.com/apache/brpc/pull/2047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] lorinlee merged pull request #2083: typo fix for bthread introduction
lorinlee merged PR #2083: URL: https://github.com/apache/brpc/pull/2083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] lorinlee commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1
lorinlee commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1383112440 @xiaohei520321 获取不到ip的服务器上，hosts文件里有写127.0.0.1吗，删掉看可以不 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] chenBright commented on issue #2013: 基于请求延迟的并发控制
chenBright commented on issue #2013: URL: https://github.com/apache/brpc/issues/2013#issuecomment-1381748915 @yanglimingcn 能写个关于这个特性的文档吗？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on issue #1847: Support the latest Bazel compilation and documentation
wwbmmm commented on issue #1847: URL: https://github.com/apache/brpc/issues/1847#issuecomment-1381375125 master has supported bazel 4.2.2, see this example: https://github.com/apache/brpc/tree/master/example/build_with_bazel this issue can be closed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm closed issue #1847: Support the latest Bazel compilation and documentation
wwbmmm closed issue #1847: Support the latest Bazel compilation and documentation URL: https://github.com/apache/brpc/issues/1847 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] VirendraYadav1234 commented on issue #1847: Support the latest Bazel compilation and documentation
VirendraYadav1234 commented on issue #1847: URL: https://github.com/apache/brpc/issues/1847#issuecomment-1381349749 I want to work on this issue please assign me this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] VirendraYadav1234 commented on issue #1931: size parameter of AnnotateBenignRaceSized should be typed size_t instead of long
VirendraYadav1234 commented on issue #1931: URL: https://github.com/apache/brpc/issues/1931#issuecomment-1381348429 I want to work on this issue please assign me this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] VirendraYadav1234 commented on issue #1209: remove the docs and comments related to HealthCheckThread
VirendraYadav1234 commented on issue #1209: URL: https://github.com/apache/brpc/issues/1209#issuecomment-1381348639 I want to work on this issue please assign me this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm merged pull request #2085: Remove DISCLAIMER
wwbmmm merged PR #2085: URL: https://github.com/apache/brpc/pull/2085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] leaf-potato commented on issue #1991: support https alpn
leaf-potato commented on issue #1991: URL: https://github.com/apache/brpc/issues/1991#issuecomment-1380575010 > 特别是当后端是个集群时，不同后端实例的ALPN协商结果可能是不同的，这样会让问题变得很复杂。 是这样的，实际在考虑的时候发现集群模式实现起来比较复杂，对现有的流程有很大的改动。 > 所以我建议，如果要在bRPC中支持ALPN协议，仅支持后端是单个ip的情况（single server模式），在这种模式下，可以在Channel::Init的时候，先向后端发起一个连接，然后根据协商结果确定协议。 OK 那Client端暂时就先支持single server模式下的ALPN，集群模式后续有更多实际场景时再进行考虑。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] leaf-potato commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1
leaf-potato commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1380558694 看着挺奇怪的，可能是机器哪儿的配置不对。brpc是调用系统的接口获取hostname后解析ip： 1. 可能hostname配置了多个ip地址，brpc只会选择第1个返回。 1. 可以考虑手动将真实的ip写到`/etc/hosts`文件里。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] luliyucoordinate closed issue #2073: 关于append_user_data中使用引用计数内存的问题
luliyucoordinate closed issue #2073: 关于append_user_data中使用引用计数内存的问题 URL: https://github.com/apache/brpc/issues/2073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiaohei520321 commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1
xiaohei520321 commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1380256066 > 机器上执行下面命令看看输出结果是否正常： > > ```shell > host `hostname` > ``` 我有4台服务器，3台是能获取到本机ip的，1台只能获取到127.0.0.1 这4台服务器上运行结果都是： Host x not found: 3(NXDOMAIN) 其中x是该机子的hostname -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] leaf-potato commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1
leaf-potato commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1380235911 机器上执行下面命令看看输出结果是否正常： ```bash host `hostname` ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm opened a new pull request, #2085: Remove DISCLAIMER
wwbmmm opened a new pull request, #2085: URL: https://github.com/apache/brpc/pull/2085 ### What problem does this PR solve? Issue Number: 2078 Problem Summary: Since bRPC has graduated, the DISCLAIMER file can be removed. ### What is changed and the side effects? Changed: Remove DISCLAIMER Side effects: No - Performance effects(性能影响): No - Breaking backward compatibility(向后兼容性): No --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiaohei520321 opened a new issue, #2084: my_ip_cstr获取本机ip为127.0.0.1
xiaohei520321 opened a new issue, #2084: URL: https://github.com/apache/brpc/issues/2084 **Describe the bug (描述bug)** butil::my_ip_cstr() 获取本机的ip为127.0.0.1 **To Reproduce (复现方法)** **Expected behavior (期望行为)** 期望获取到真实的ip **Versions (各种版本)** OS: Compiler: brpc: protobuf: **Additional context/screenshots (更多上下文/截图)** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] lorinlee commented on issue #2081: http_rpc_protocol.cpp中core掉了, 看起来不像是业务代码导致的
lorinlee commented on issue #2081: URL: https://github.com/apache/brpc/issues/2081#issuecomment-1379725069 可能是业务代码把内存写坏了，这个问题好复现不，建议开ASAN复现下。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] freemandealer opened a new pull request, #2083: typo fix for bthread introduction
freemandealer opened a new pull request, #2083: URL: https://github.com/apache/brpc/pull/2083 As term 'M:N' starts with a vowel sound [e], so it should be 'an' instead of 'a' grammatically. Signed-off-by: freemandealer ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiaoyuxee closed issue #2074: 客户端请求比较耗时的case 时，rpc E1010，500 Internal Server Error
xiaoyuxee closed issue #2074: 客户端请求比较耗时的case 时，rpc E1010，500 Internal Server Error URL: https://github.com/apache/brpc/issues/2074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiaoyuxee commented on issue #2074: 客户端请求比较耗时的case 时，rpc E1010，500 Internal Server Error
xiaoyuxee commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378488740 把 client 端 window size 调大后，问题解决。 > 客户端请求比较耗时的case ... 应该不是耗时引起，而是耗时的 case 所产生的 response 也比较大。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] highkic opened a new issue, #2082: http接口获取到的 mbvar转prometheus metrics 格式, 提示格式非法
highkic opened a new issue, #2082:
URL: https://github.com/apache/brpc/issues/2082
**Describe the bug (描述bug)**
通过brpc_metrics接口获取mbvar 转化来的多lables guage打点，提示type非法
具体的值:
# HELP
lat_rank_score_total_latency{system="unknown",module="unknown",server="rank_server_nbase",status="0"}
# TYPE
lat_rank_score_total_latency{system="unknown",module="unknown",server="rank_server_nbase",status="0"}
gauge
lat_rank_score_total_latency{system="unknown",module="unknown",server="rank_server_nbase",status="0"}
22
**To Reproduce (复现方法)**
typedef bvar::MultiDimension MLatencyRecorder;
MLatencyRecorder lat_rank_score_total("lat_rank_score_total", {"system",
"module", "server", "status"});
mbvar_dump=true
mbvar_dump_format= prometheus
打点收集，然后prometheus收集组件通过 http://$ip:$port/brpc_metrics获取打点结果，提示错误
invalid metirc type "system=\"square\" ** gauge"
**Expected behavior (期望行为)**
能正常收集
**Versions (各种版本)**
OS: linux
Compiler: gcc 7.3.1
brpc: 1月10号版master
protobuf: 3.6.0
**Additional context/screenshots (更多上下文/截图)**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] jiangdongzi commented on issue #2081: http_rpc_protocol.cpp中core掉了, 看起来不像是业务代码导致的
jiangdongzi commented on issue #2081: URL: https://github.com/apache/brpc/issues/2081#issuecomment-1378264975 编译所用commit `a0fc1a2` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiaoyuxee commented on issue #2074: 客户端请求比较耗时的case 时，rpc E1010，500 Internal Server Error
xiaoyuxee commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378261134 > client 端信息如下： > > * ParallelChannel 中包含多个 SelectiveChannel，用于并行调用 SelectiveChannel 中某个 server > * protocol = "h2:grpc" > * SelectiveChannel `timeout_ms`、`connect_timeout_ms` 均为 -1 > 刚刚试了下，client protocol 改为 "baidu_std" 则没问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on issue #2074: 客户端请求比较耗时的case 时，rpc E1010，500 Internal Server Error
wwbmmm commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378255494 在client和server分别抓包看看 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiaoyuxee commented on issue #2074: 客户端请求比较耗时的case 时，rpc E1010，500 Internal Server Error
xiaoyuxee commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378251117 通过打印日志发现，client 端socket 接受到的 header 中已经是 500 了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiaoyuxee commented on issue #2074: 客户端请求比较耗时的case 时，rpc E1010，500 Internal Server Error
xiaoyuxee commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378245453 > client和server间是不是还有一层http代理？ 通过 k8s 的pod域名来调用 server 的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] jiangdongzi commented on issue #2081: http_rpc_protocol.cpp中core掉了, 看起来不像是业务代码导致的
jiangdongzi commented on issue #2081: URL: https://github.com/apache/brpc/issues/2081#issuecomment-1378204081 偶发 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] jiangdongzi opened a new issue, #2081: http_rpc_protocol.cpp中core掉了, 看起来不像是业务代码导致的
jiangdongzi opened a new issue, #2081: URL: https://github.com/apache/brpc/issues/2081  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on issue #1991: support https alpn
wwbmmm commented on issue #1991: URL: https://github.com/apache/brpc/issues/1991#issuecomment-1378175719 > @wwbmmm Client端的实现有几个问题想请教下：目前考虑的是在`ChannelSSLOptions`中新增ALPN的配置，在TLS协商成功后覆盖`ChannelOptions.protocol`字段进行后续的数据发送。 > > Q1：`Channel.Init()`方法并不会实际建立连接，这样在初始化阶段并不知道需要使用哪种协议。而在`Channel.CallMethod()`方法调用Socket发送数据前，函数内已经有根据protocol值的特殊逻辑处理。这样的话是否可以在在`Init`就进行TLS握手确定使用的协议？或者还有其他比较好的办法吗？ > > Q2：由于protocol是针对下游整体而言的，当下游是集群时，某个下游（ip:port）协商成功了是否就可以认为是整个集群的结果？以及后续连接断开重连（连接池）是否可以直接复用之前的协商结果？ > > Q3：除了普通的Channel，考虑到ParallelChannel、SelectiveChannel等其他Channel也有可能需要涉及到ALPN，是否可以将协商功能实现在ChannelBase中？ ALPN的流程对现有RPC框架的冲击较大。因为ALPN是在连接建立之后才能确定协议，而RPC是在Channel::Init确定协议，CallMethod时根据协议序列化好请求，用LB选择后端服务器，再发起与后端的连接。特别是当后端是个集群时，不同后端实例的ALPN协商结果可能是不同的，这样会让问题变得很复杂。 所以我建议，如果要在bRPC中支持ALPN协议，仅支持后端是单个ip的情况（single server模式），在这种模式下，可以在Channel::Init的时候，先向后端发起一个连接，然后根据协商结果确定协议。 ParallelChannel、SelectiveChannel没必要处理ALPN的逻辑，只要子Channel支持了就可以。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] fzhedu closed issue #2052: 传输大量数据必须用butil::IOBuf 吗？
fzhedu closed issue #2052: 传输大量数据必须用butil::IOBuf 吗？ URL: https://github.com/apache/brpc/issues/2052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] fzhedu commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗？
fzhedu commented on issue #2052: URL: https://github.com/apache/brpc/issues/2052#issuecomment-1378169591 @leaf-potato 感谢您的回复。 通过微信官方群确认，append 和 append_user_data 将用户数据弄到 iobuf 都不需要序列化，并且用后者更高效，因为它避免 copy。 再次感谢您的耐心解答。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm closed issue #2062: 多维度bvar支持http内置服务查看吗？
wwbmmm closed issue #2062: 多维度bvar支持http内置服务查看吗？ URL: https://github.com/apache/brpc/issues/2062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on issue #2070: Bash shebangs are wrong: they should be #!/usr/bin/env bash
wwbmmm commented on issue #2070: URL: https://github.com/apache/brpc/issues/2070#issuecomment-1378160786 related: #2072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on issue #2071: error: cannot initialize return object of type 'uint64_t' (aka 'unsigned long') with an rvalue of type 'pthread_t'
wwbmmm commented on issue #2071: URL: https://github.com/apache/brpc/issues/2071#issuecomment-1378160660 related: #2072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on issue #2074: 客户端请求比较耗时的case 时，rpc E1010，500 Internal Server Error
wwbmmm commented on issue #2074: URL: https://github.com/apache/brpc/issues/2074#issuecomment-1378160046 client和server间是不是还有一层http代理？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm commented on issue #2077: 支持xmake构建项目
wwbmmm commented on issue #2077: URL: https://github.com/apache/brpc/issues/2077#issuecomment-1378158679 same as #1766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiedeacc closed issue #2080: import brpc in bazel compile error
xiedeacc closed issue #2080: import brpc in bazel compile error URL: https://github.com/apache/brpc/issues/2080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiedeacc commented on issue #2080: import brpc in bazel compile error
xiedeacc commented on issue #2080: URL: https://github.com/apache/brpc/issues/2080#issuecomment-1377338265 fixed by add openssl to workspace -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiedeacc commented on issue #2080: import brpc in bazel compile error
xiedeacc commented on issue #2080: URL: https://github.com/apache/brpc/issues/2080#issuecomment-1377274454 brpc itself can be compiled successfully, but imported as an dependency failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] wwbmmm merged pull request #127: update the apache url
wwbmmm merged PR #127: URL: https://github.com/apache/brpc-website/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] wasphin merged pull request #125: Fix download links
wasphin merged PR #125: URL: https://github.com/apache/brpc-website/pull/125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] xiedeacc opened a new issue, #2080: import bazel in bazel compile error
xiedeacc opened a new issue, #2080:
URL: https://github.com/apache/brpc/issues/2080
**Describe the bug (描述bug)**
I import brpc in a bazel repo, first it said lack of crc32c, leveldb,
snappy, zlib and some config file, it also need add some condition config to
avoid bazel/config not found problem, after I fixed these problem, meet a
compile error, how to fix this problem?
```
ERROR:
/root/.cache/bazel/_bazel_root/e690f860c4a8dbf4e57f137579fceef1/external/brpc/BUILD.bazel:287:11:
Compiling src/butil/iobuf.cpp failed: (Exit 1): gcc failed: error executing
command (from target @brpc//:butil) /usr/bin/gcc -U_FORTIFY_SOURCE
-fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object
-fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG
-ffunction-sections ... (remaining 75 arguments skipped)
Use --sandbox_debug to see verbose messages from the sandbox and retain the
sandbox build root for debugging
external/brpc/src/butil/iobuf.cpp: In static member function 'static ssize_t
butil::IOBuf::cut_multiple_into_SSL_channel(SSL*, butil::IOBuf* const*, size_t,
int*)':
external/brpc/src/butil/iobuf.cpp:1005:28: error: 'BIO_fd_non_fatal_error'
was not declared in this scope
1005 | && BIO_fd_non_fatal_error(errno) == 1)) {
|^~
external/brpc/src/butil/iobuf.cpp:1025:24: error: 'BIO_fd_non_fatal_error'
was not declared in this scope
1025 | if (rc <= 0 && BIO_fd_non_fatal_error(errno) == 0) {
|^~
external/brpc/src/butil/iobuf.cpp: In member function 'ssize_t
butil::IOPortal::append_from_SSL_channel(SSL*, int*, size_t)':
external/brpc/src/butil/iobuf.cpp:1698:28: error: 'BIO_fd_non_fatal_error'
was not declared in this scope
1698 | && BIO_fd_non_fatal_error(errno) == 1)) {
|^~
INFO: Elapsed time: 117.540s, Critical Path: 8.33s
INFO: 379 processes: 43 internal, 336 linux-sandbox.
FAILED: Build did NOT complete successfully
```
**To Reproduce (复现方法)**
**Expected behavior (期望行为)**
**Versions (各种版本)**
OS:
Compiler:
brpc:
protobuf:
**Additional context/screenshots (更多上下文/截图)**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] NKcqx commented on issue #1847: Support the latest Bazel compilation and documentation
NKcqx commented on issue #1847: URL: https://github.com/apache/brpc/issues/1847#issuecomment-1376939962 有一个小建议，提到 "latest Bazel" 的时候可否带上当时的 Bazel 版本？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] NKcqx commented on issue #1268: 如果用bazel编译brpc的话，bazel需要到多少版本呢？
NKcqx commented on issue #1268:
URL: https://github.com/apache/brpc/issues/1268#issuecomment-1376931584
protobuf 仍然有问题
bazel version: 4.2.2
brpc master commit: 5283d0d930c33e03346ab59de3580c061c3e90b8
报错：
```
INFO: Repository com_google_protobuf instantiated at:
/Users/paer/Documents/work/Code/incubator-brpc/WORKSPACE:236:13: in
Repository rule http_archive defined at:
/private/var/tmp/_bazel_paer/ce07402dfb742d9a250bfd2335df0ebb/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31:
in
INFO: Repository 'com_google_protobuf' used the following cache hits instead
of downloading the corresponding file.
* Hash '87407cd28e7a9c95d9f61a098a53cf031109d451a7763e7dd1253abf8b4df422'
for https://github.com/protocolbuffers/protobuf/archive/refs/tags/v3.19.1.tar.gz
If the definition of 'com_google_protobuf' was updated, verify that the
hashes were also updated.
ERROR: An error occurred during the fetch of repository
'com_google_protobuf':
Traceback (most recent call last):
File
"/private/var/tmp/_bazel_paer/ce07402dfb742d9a250bfd2335df0ebb/external/bazel_tools/tools/build_defs/repo/http.bzl",
line 121, column 10, in _http_archive_impl
patch(ctx)
File
"/private/var/tmp/_bazel_paer/ce07402dfb742d9a250bfd2335df0ebb/external/bazel_tools/tools/build_defs/repo/utils.bzl",
line 161, column 21, in patch
fail("Error applying patch command %s:\n%s%s" %
Error in fail: Error applying patch command sed -i protobuf.bzl -re
'4,4d;417,508d':
sed: -I or -i may not be used with stdin
ERROR: Error fetching repository: Traceback (most recent call last):
File
"/private/var/tmp/_bazel_paer/ce07402dfb742d9a250bfd2335df0ebb/external/bazel_tools/tools/build_defs/repo/http.bzl",
line 121, column 10, in _http_archive_impl
patch(ctx)
File
"/private/var/tmp/_bazel_paer/ce07402dfb742d9a250bfd2335df0ebb/external/bazel_tools/tools/build_defs/repo/utils.bzl",
line 161, column 21, in patch
fail("Error applying patch command %s:\n%s%s" %
Error in fail: Error applying patch command sed -i protobuf.bzl -re
'4,4d;417,508d':
sed: -I or -i may not be used with stdin
INFO: Repository openssl instantiated at:
/Users/paer/Documents/work/Code/incubator-brpc/WORKSPACE:256:13: in
Repository rule http_archive defined at:
/private/var/tmp/_bazel_paer/ce07402dfb742d9a250bfd2335df0ebb/external/bazel_tools/tools/build_defs/repo/http.bzl:336:31:
in
ERROR: /Users/paer/Documents/work/Code/incubator-brpc/BUILD.bazel:295:11:
//:butil depends on @com_google_protobuf//:protobuf in repository
@com_google_protobuf which failed to fetch. no such package
'@com_google_protobuf//': Error applying patch command sed -i protobuf.bzl -re
'4,4d;417,508d':
sed: -I or -i may not be used with stdin
ERROR: Analysis of target '//:brpc' failed; build aborted: Analysis failed
INFO: Elapsed time: 2.990s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets
configured)
Fetching @local_config_xcode; fetching
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] serverglen merged pull request #126: update the apache logo and description
serverglen merged PR #126: URL: https://github.com/apache/brpc-website/pull/126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] Huixxi commented on a diff in pull request #126: update the apache logo and description
Huixxi commented on code in PR #126: URL: https://github.com/apache/brpc-website/pull/126#discussion_r1065368984 ## content/zh/_index.html: ## @@ -44,14 +44,14 @@ 你可以使用它： 搭建能在一个端口支持多协议的服务, 或访问各种服务。 -restful http/https, h2/gRPC. 使用bRPC的http实现比libcurl方便多了。从其他语言通过HTTP/h2+json访问基于protobuf的协议. +restful http/https， h2/gRPC， 使用bRPC的http实现比libcurl方便多了。从其他语言通过HTTP/h2+json访问基于protobuf的协议。 redis and memcached, 线程安全，比官方client更方便。 rtmp/flv/hls, 可用于搭建流媒体服务。 - hadoop_rpc (可能开源) - 支持rdma(即将开源) + hadoop_rpc (可能开源)。 + 支持rdma(即将开源)。 Review Comment: > 已经开源并合入主分支了。 > > 这个是不是又要两边同步文档了？ 这个等新版本发布之后同步吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] Huixxi commented on a diff in pull request #126: update the apache logo and description
Huixxi commented on code in PR #126: URL: https://github.com/apache/brpc-website/pull/126#discussion_r1065368609 ## content/zh/_index.html: ## @@ -44,14 +44,14 @@ 你可以使用它： 搭建能在一个端口支持多协议的服务, 或访问各种服务。 -restful http/https, h2/gRPC. 使用bRPC的http实现比libcurl方便多了。从其他语言通过HTTP/h2+json访问基于protobuf的协议. +restful http/https， h2/gRPC， 使用bRPC的http实现比libcurl方便多了。从其他语言通过HTTP/h2+json访问基于protobuf的协议。 redis and memcached, 线程安全，比官方client更方便。 rtmp/flv/hls, 可用于搭建流媒体服务。 - hadoop_rpc (可能开源) - 支持rdma(即将开源) + hadoop_rpc (可能开源)。 + 支持rdma(即将开源)。 Review Comment: 对的 我也发现了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] wasphin commented on a diff in pull request #126: update the apache logo and description
wasphin commented on code in PR #126: URL: https://github.com/apache/brpc-website/pull/126#discussion_r1065357838 ## content/zh/_index.html: ## @@ -44,14 +44,14 @@ 你可以使用它： 搭建能在一个端口支持多协议的服务, 或访问各种服务。 -restful http/https, h2/gRPC. 使用bRPC的http实现比libcurl方便多了。从其他语言通过HTTP/h2+json访问基于protobuf的协议. +restful http/https， h2/gRPC， 使用bRPC的http实现比libcurl方便多了。从其他语言通过HTTP/h2+json访问基于protobuf的协议。 redis and memcached, 线程安全，比官方client更方便。 rtmp/flv/hls, 可用于搭建流媒体服务。 - hadoop_rpc (可能开源) - 支持rdma(即将开源) + hadoop_rpc (可能开源)。 + 支持rdma(即将开源)。 Review Comment: 已经开源并合入主分支了。 这个是不是又要两边同步文档了？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] wasphin commented on a diff in pull request #122: Remove incubator
wasphin commented on code in PR #122: URL: https://github.com/apache/brpc-website/pull/122#discussion_r1065355216 ## content/zh/docs/DownloadBRPC/index.md: ## @@ -50,25 +50,25 @@ Apache bRPC（孵化）作为源工件发布。我们很高兴宣布我们的1.3 -Apache bRPC (incubating) 1.3.0 (tar.gz) +Apache bRPC 1.3.0 (tar.gz) Review Comment: 这个不应该删吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] wasphin commented on pull request #125: Fix download links
wasphin commented on PR #125: URL: https://github.com/apache/brpc-website/pull/125#issuecomment-1376762330 下载地址 dlcdn 和 download 都有用的，最终还是参考 tomcat 用 dlcdn 的吧。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm merged pull request #2079: Remove incubator in svn and download path
wwbmmm merged PR #2079: URL: https://github.com/apache/brpc/pull/2079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm opened a new pull request, #2079: Remove incubator in svn and download path
wwbmmm opened a new pull request, #2079: URL: https://github.com/apache/brpc/pull/2079 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm opened a new issue, #2078: Apache bRPC Graduation Tasks
wwbmmm opened a new issue, #2078: URL: https://github.com/apache/brpc/issues/2078 The ASF board has approved a resolution to graduate bRPC into a full Top Level Project. Thanks to everyone for your help to get to this point. To transition from the Apache Incubator to a new TLP, there's a few action items we need to do to complete the transition. These are identified by https://incubator.apache.org/guides/transferring.html#life_after_graduation. Task list - Update Incubator status records - [ ] Update the incubator status file (in svn) https://svn.apache.org/repos/asf/incubator/public/trunk/content/projects/brpc.xml - [ ] Update podling status page https://incubator.apache.org/projects/ https://incubator.apache.org/projects/brpc.html https://svn.apache.org/repos/asf/incubator/public/trunk/content/podlings.xml - Source repo changes - [x] Create JIRA ticket [INFRA-24070](https://issues.apache.org/jira/browse/INFRA-24070) to request ASF Infra remove "incubator-" prefix of git repos and move dist folder in SVN repositories from the incubator to other locations https://github.com/apache/incubator-brpc https://github.com/apache/incubator-brpc-website old: https://dist.apache.org/repos/dist/release/incubator/brpc new: https://dist.apache.org/repos/dist/release/brpc - [ ] Post announcement to dev list telling everyone the repo renaming containing instructions for developers describing how to change their git remotes. - [x] Update website, pom.xml, and other resources to point to the new repository location - Source code - [x] Remove "Incubating" from source code - [ ] Remove DISCLAIMER from git repo - [ ] Update Release documents - Websites - [x] Remove incubating/podding related resources from the website. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] wwbmmm merged pull request #121: remove the incubating from brpc logo on the home page
wwbmmm merged PR #121: URL: https://github.com/apache/brpc-website/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc-website] wwbmmm merged pull request #122: Remove incubator
wwbmmm merged PR #122: URL: https://github.com/apache/brpc-website/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [brpc] wwbmmm merged pull request #2056: Remove incubator
wwbmmm merged PR #2056: URL: https://github.com/apache/brpc/pull/2056 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] leaf-potato opened a new issue, #2077: 支持xmake构建项目
leaf-potato opened a new issue, #2077: URL: https://github.com/apache/incubator-brpc/issues/2077 xmake目前对c/c++项目的构建比较完善了，是否有支持xmake的计划呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] leaf-potato commented on issue #1991: support https alpn
leaf-potato commented on issue #1991: URL: https://github.com/apache/incubator-brpc/issues/1991#issuecomment-1375729393 @wwbmmm Client端的实现有几个问题想请教下：目前考虑的是在`ChannelSSLOptions`中新增ALPN的配置，在TLS协商成功后覆盖`ChannelOptions.protocol`字段进行后续的数据发送。 Q1：`Channel.Init()`方法并不会实际建立连接，这样在初始化阶段并不知道需要使用哪种协议。而在`Channel.CallMethod()`方法调用Socket发送数据前，函数内已经有根据protocol值的特殊逻辑处理。这样的话是否可以在在`Init`就进行TLS握手确定使用的协议？或者还有其他比较好的办法吗？ Q2：由于protocol是针对下游整体而言的，当下游是集群时，某个下游（ip:port）协商成功了是否就可以认为是整个集群的结果？以及后续连接断开重连（连接池）是否可以直接复用之前的协商结果？ Q3：除了普通的Channel，考虑到ParallelChannel、SelectiveChannel等其他Channel也有可能需要涉及到ALPN，是否可以将协商功能实现在ChannelBase中？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] leaf-potato commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗？
leaf-potato commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1375721168 目前似乎没看到相关的文档或者测试数据，可以问下仓库的管理员~ 简单说下个人的理解： 1. 使用proto设置reponse：用户设置response => 序列化数据（框架） => 发送 2. attament传序列化数据：用户设置reponse => 序列化数据（用户） => 发送 可以看到两种方式都需要存储序列化后的数据，区别在于序列化的地方不同。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] fzhedu commented on issue #2052: 传输大量数据必须用butil::IOBuf 吗？
fzhedu commented on issue #2052: URL: https://github.com/apache/incubator-brpc/issues/2052#issuecomment-1375702075 @leaf-potato 谢谢你的指点，`append_user_data ` 确实可以避免大chunk copy 到 attachment 的问题。 Q3 我正在学习中。 针对 Q1 还有疑问，不理解你上面回复 ``` 在限制范围内，attachment和proto的区别在于序列化和反序列化，如果attachment是传proto序列化后的数据，理论上两者差距不大。 ``` 针对`attachment传proto序列化后的数据，理论上两者差距不大`，是不是因为采用 `append_user_data `没有复制数据，所以跟直接传proto序列化后的数据效果差不多？如果采用 `append` 复制proto序列化后的数据到 iobuf，就应该会慢一些？ 这一块有官方文档说明么？或者有没有实验数据。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm merged pull request #2076: Rollback #2049 chang
wwbmmm merged PR #2076: URL: https://github.com/apache/incubator-brpc/pull/2076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
[GitHub] [incubator-brpc] co0l1ce opened a new pull request, #2076: Rollback #2049 chang
co0l1ce opened a new pull request, #2076: URL: https://github.com/apache/incubator-brpc/pull/2076 ### What problem does this PR solve? Chang in #2049 has same problem for a different Link order(. brpc -> pthread), will can't find symbol and exit, so rollback, the Origin implement need we link brpc befor pthread, we can use ldd binary to check it Issue Number: #2049 Problem Summary: the fix is not perfect ### What is changed and the side effects? Changed:rollback to origin implement Side effects: - Performance effects(性能影响):no effects - Breaking backward compatibility(向后兼容性):compatibility --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
