[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-11 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r274744617 ## File path: src/brpc/load_balancer.h ## @@ -24,6 +24,8 @@ #include "brpc/shared_object.h"

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-10 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273888162 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -289,5 +376,23 @@ void C

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-09 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273799156 ## File path: src/brpc/policy/consistent_hashing_load_balancer.h ## @@ -56,14 +54,28 @@ class Con

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-09 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273778076 ## File path: src/brpc/policy/consistent_hashing_load_balancer.h ## @@ -56,14 +54,28 @@ class Con

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-09 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273778076 ## File path: src/brpc/policy/consistent_hashing_load_balancer.h ## @@ -56,14 +54,28 @@ class Con

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-09 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273454920 ## File path: src/brpc/policy/consistent_hashing_load_balancer.h ## @@ -56,14 +54,28 @@ class Con

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-09 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273453006 ## File path: src/brpc/policy/hasher.cpp ## @@ -157,6 +165,10 @@ const char *GetHashName(uint32_t

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-09 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r273436491 ## File path: src/brpc/policy/consistent_hashing_load_balancer.h ## @@ -56,14 +54,28 @@ class Con

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-08 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272998794 ## File path: src/brpc/load_balancer.cpp ## @@ -74,6 +80,10 @@ int SharedLoadBalancer::Init(const

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-08 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272997740 ## File path: src/brpc/policy/consistent_hashing_load_balancer.cpp ## @@ -29,16 +31,110 @@ namesp

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor

2019-04-04 Thread GitBox
zyearn commented on a change in pull request #592: lb configurable && consistency hash lb refactor URL: https://github.com/apache/incubator-brpc/pull/592#discussion_r272432447 ## File path: src/brpc/load_balancer.h ## @@ -102,8 +104,21 @@ class LoadBalancer : public NonCon