Re: Changes to loc example

2009-08-05 Thread Martin Grotzke
On Tue, 2009-08-04 at 20:47 -0700, Alex Boisvert wrote: > On Tue, Aug 4, 2009 at 8:29 PM, Daniel Spiewak wrote: > > > > > > > Everything in Buildr is an extension added on to project, if first_time > > > decided to stop working, so would compiling, testing, packaging, etc. > > > > > > That's part

Re: Changes to loc example

2009-08-05 Thread Martin Grotzke
On Tue, 2009-08-04 at 17:47 -0700, Alex Boisvert wrote: > On Mon, Aug 3, 2009 at 1:27 PM, Martin Grotzke > wrote: > > > On Mon, 2009-08-03 at 11:01 -0700, Alex Boisvert wrote: > > > Oh and I was perusing the repo and saw your sloccount.rb extension... I'm > > > guessing it's still a work-in-progr

Re: Changes to loc example

2009-08-04 Thread Alex Boisvert
Oh, I see. I checked earlier but I missed that. That's the issue then. Thanks! alex On Tue, Aug 4, 2009 at 8:50 PM, Assaf Arkin wrote: > On Tue, Aug 4, 2009 at 8:45 PM, Alex Boisvert > wrote: > > > On Tue, Aug 4, 2009 at 8:20 PM, Assaf Arkin wrote: > > > > > On Tue, Aug 4, 2009 at 7:31 P

Re: Changes to loc example

2009-08-04 Thread Assaf Arkin
On Tue, Aug 4, 2009 at 8:45 PM, Alex Boisvert wrote: > On Tue, Aug 4, 2009 at 8:20 PM, Assaf Arkin wrote: > > > On Tue, Aug 4, 2009 at 7:31 PM, Alex Boisvert > > wrote: > > > > > I've managed to narrow down the issue to the > > > Buildr::Extension::ClassMethods.callbacks method which returns an

Re: Changes to loc example

2009-08-04 Thread Alex Boisvert
On Tue, Aug 4, 2009 at 8:29 PM, Daniel Spiewak wrote: > > > > Everything in Buildr is an extension added on to project, if first_time > > decided to stop working, so would compiling, testing, packaging, etc. > > > That's part of why I don't understand Martin's bug. We *know* that > first_time is

Re: Changes to loc example

2009-08-04 Thread Alex Boisvert
On Tue, Aug 4, 2009 at 8:20 PM, Assaf Arkin wrote: > On Tue, Aug 4, 2009 at 7:31 PM, Alex Boisvert > wrote: > > > I've managed to narrow down the issue to the > > Buildr::Extension::ClassMethods.callbacks method which returns an invalid > > Callback instance. I came up with a quick fix but I'm

Re: Changes to loc example

2009-08-04 Thread Daniel Spiewak
> > Everything in Buildr is an extension added on to project, if first_time > decided to stop working, so would compiling, testing, packaging, etc. That's part of why I don't understand Martin's bug. We *know* that first_time is working, otherwise everything would be broken. However, the issue

Re: Changes to loc example

2009-08-04 Thread Assaf Arkin
On Tue, Aug 4, 2009 at 7:31 PM, Alex Boisvert wrote: > I've managed to narrow down the issue to the > Buildr::Extension::ClassMethods.callbacks method which returns an invalid > Callback instance. I came up with a quick fix but I'm not sure why this is > happening or if it's the right solution.

Re: Changes to loc example

2009-08-04 Thread Alex Boisvert
I've managed to narrow down the issue to the Buildr::Extension::ClassMethods.callbacks method which returns an invalid Callback instance. I came up with a quick fix but I'm not sure why this is happening or if it's the right solution. boisv...@sixtine:~/svn/buildr-ext$ svn-diff Index: lib/buildr/

Re: Changes to loc example

2009-08-04 Thread Alex Boisvert
On Mon, Aug 3, 2009 at 1:27 PM, Martin Grotzke wrote: > On Mon, 2009-08-03 at 11:01 -0700, Alex Boisvert wrote: > > Oh and I was perusing the repo and saw your sloccount.rb extension... I'm > > guessing it's still a work-in-progress and wanted to point out that it > would > > be better to allocat

Re: Changes to loc example

2009-08-03 Thread Daniel Spiewak
I can reproduce the problem (and your solution). It still doesn't make any sense to me though. Actually, it's probably indicative of some deeper problem with the way we're using Rake. Assaf, I'm getting well out of my depth here, could you look at this? Daniel On Mon, Aug 3, 2009 at 4:59 PM, M

Re: Changes to loc example

2009-08-03 Thread Martin Grotzke
I did this: module LinesOfCode include Extension desc "WeirdWeirdWeird" Project.local_task('loc') first_time do # Define task not specific to any project. #Project.local_task('loc') end ... end And now buildr -T shows the loc task as "WeirdWeirdWeird"... Just for interest:

Re: Changes to loc example

2009-08-03 Thread Daniel Spiewak
That doesn't make any sense to me. I've done a number of extensions now using local_task, none of them have had any problems. Just looking at your sources, everything should work. Just for kicks, try moving the local_task bit *out* of the first_time block, see what happens. Daniel On Mon, Aug

Re: Changes to loc example

2009-08-03 Thread Martin Grotzke
On Mon, 2009-08-03 at 11:01 -0700, Alex Boisvert wrote: > Oh and I was perusing the repo and saw your sloccount.rb extension... I'm > guessing it's still a work-in-progress and wanted to point out that it would > be better to allocate a new SloccountConfig in before_define instead of > having a sin

Re: Changes to loc example

2009-08-03 Thread Martin Grotzke
Ok, thanks for the hint! However, using `task` doesn't change anything for me. buildr -T still prints the available loc tasks as myproj:loc and myproj:mysubproj:loc. Invoking `buildr loc` results in Don't know how to build task 'loc' Removing the first_time stuff also doesn't change anything, I

Re: Changes to loc example

2009-08-03 Thread Alex Boisvert
Oh and I was perusing the repo and saw your sloccount.rb extension... I'm guessing it's still a work-in-progress and wanted to point out that it would be better to allocate a new SloccountConfig in before_define instead of having a single configuration instance across all projects. My (unsolicited

Re: Changes to loc example

2009-08-03 Thread Daniel Spiewak
You should use `task` rather than `define_task`. I think that's probably the root of all your problems. My changes can be seen here: http://github.com/djspiewak/buildr-addons/tree/master Daniel On Mon, Aug 3, 2009 at 11:43 AM, Martin Grotzke < martin.grot...@javakaffee.de> wrote: > Here's the

Re: Changes to loc example

2009-08-03 Thread Martin Grotzke
Here's the loc extension (loc.rb): http://github.com/magro/buildr-addons/tree/master Cheers, Martin On Mon, 2009-08-03 at 11:29 -0500, Daniel Spiewak wrote: > That really doesn't make any sense. Could we see the full sources? > > Daniel > > On Mon, Aug 3, 2009 at 4:58 AM, Martin Grotzke > wr

Re: Changes to loc example

2009-08-03 Thread Daniel Spiewak
That really doesn't make any sense. Could we see the full sources? Daniel On Mon, Aug 3, 2009 at 4:58 AM, Martin Grotzke wrote: > And I noticed that with the example one has to invoke > buildr myproj:loc > for the project or > buildr myproj:mysubproj:loc > for a subproject. > > The > firs

Re: Changes to loc example

2009-08-03 Thread Martin Grotzke
And I noticed that with the example one has to invoke buildr myproj:loc for the project or buildr myproj:mysubproj:loc for a subproject. The first_time do Project.local_task('loc') end seems to have no effect. Is this intended? Cheers, Martin On Mon, 2009-08-03 at 11:47 +0200,

Changes to loc example

2009-08-03 Thread Martin Grotzke
Hi, I just want to create a sloccount extension and for this started with the loc example. I had to do minor changes, which I applied to the extending.textile: http://github.com/magro/buildr/commit/b880acaca4892a4000143d089b59873247808bc0 Without these changes: - the task is not shown with build