Re: Manifest packaging: not closing the Tempfile ?

2010-04-11 Thread Antoine Toulme
Filing https://issues.apache.org/jira/browse/BUILDR-423 for it. On Sat, Apr 10, 2010 at 21:32, Alex Boisvert wrote: > On Sat, Apr 10, 2010 at 10:27 AM, Antoine Toulme > wrote: > >> Line 181 of packaging.rb, we don't close the Tempfile that represents the >> MANIFEST.MF. >> I understand that we n

Re: Manifest packaging: not closing the Tempfile ?

2010-04-10 Thread Alex Boisvert
On Sat, Apr 10, 2010 at 10:27 AM, Antoine Toulme wrote: > Line 181 of packaging.rb, we don't close the Tempfile that represents the > MANIFEST.MF. > I understand that we need to keep the file, but we could maybe close it > with > unlink set to false ? > That sounds like an open file leak to me oth

Manifest packaging: not closing the Tempfile ?

2010-04-10 Thread Antoine Toulme
Line 181 of packaging.rb, we don't close the Tempfile that represents the MANIFEST.MF. I understand that we need to keep the file, but we could maybe close it with unlink set to false ? That sounds like an open file leak to me otherwise. Should I file a bug ? Antoine