Re: [DISCUSS] Tests vs multiline strings

2019-12-14 Thread Rui Wang
Replace $ with something else will have a large impact. E.g. projects using Calcite might have tests that verify plans by plan.toString() thus $ is exposed in many places. Can we only use Kotlin for tests that does not evaluate plans? I think there are still many tests that does not have "$" can

Re: [DISCUSS] Tests vs multiline strings

2019-12-14 Thread Haisheng Yuan
The plan becomes not so easier to read, which is more important to me. Unless we change $ to other symbol, I am inclined to keep using Java. I am not sure why schemas in MaterializationTest require column names to be quoted, If we can change that, queries will be much easier to read (even for

[DISCUSS] Tests vs multiline strings

2019-12-14 Thread Vladimir Sitnikov
Hi, Calcite tests sometimes require multiline strings. For instance: input SQL, output plan. TL;DR: let's use Kotlin to improve test code readability. What do you think? Unfortunately, Java <14 lacks multiline strings, so the current tests are not that pretty :( They are hard to read, hard to

Re: How to keep quotes in SqlIdentifier?

2019-12-14 Thread Muhammad Gelbana
I don't find it correct to have quotes, double-quotes, backticks or anything other than the identifier name in the SqlNode's identifier. If you need it, you can just add it your self. But why do you want to have the identifier this way ? May be there is another way to achieve your goal ? On