Re: Gradle prepareVote task does not run unit tests

2020-03-30 Thread Stamatis Zampetakis
While the test VM was functional I was running locally as many tests as possible including Postgres, Druid, etc. The current instructions for preparing a release do ask to ensure that tests succeed and optionally ask for extra tests. If more people believe that the release manager should not run a

[jira] [Created] (CALCITE-3888) Exclude jetty-server from core's compileClasspath

2020-03-30 Thread Jiahui Jiang (Jira)
Jiahui Jiang created CALCITE-3888: - Summary: Exclude jetty-server from core's compileClasspath Key: CALCITE-3888 URL: https://issues.apache.org/jira/browse/CALCITE-3888 Project: Calcite Issue

Re: Split Join condition with CAST which only widening nullability

2020-03-30 Thread Julian Hyde
If we're going down the path, we should consider that 'b IS TRUE' and 'b IS NOT FALSE' are somewhat like casts. Removing them from join conditions does not affect the result of the join. And the same apply to filter conditions. I don't know whether removing casts, _ IS TRUE and _ IS NOT FALSE fro

Re: Split Join condition with CAST which only widening nullability

2020-03-30 Thread Zoltan Haindrich
Hey Shuo! Thank you for sharing the testcase! I've seen that you were able to fix it by calling the builder instead of copy - right now I think fixing this thru ReduceExpressionRule might be better - as it could also fix up other cases. I've tried disabling nullability retainment for filters/jo

[jira] [Created] (CALCITE-3887) Filter and Join conditions may not need to retain nullability during simplifications

2020-03-30 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created CALCITE-3887: - Summary: Filter and Join conditions may not need to retain nullability during simplifications Key: CALCITE-3887 URL: https://issues.apache.org/jira/browse/CALCITE-3887