Re: [DISCUSS] Towards Calcite 1.23.0

2020-05-05 Thread Chunwei Lei
Hi, Haisheng, I would like to review the PR for CALCITE-3896. Best, Chunwei On Wed, May 6, 2020 at 4:50 AM Rui Wang wrote: > Thanks for leading 1.23.0 release, Haisheng! > > I will actively contact Danny and Feng to see if we can reach a conclusion > on

[jira] [Created] (CALCITE-3973) Writing SQL hints to a string results in SQL that cannot be parsed

2020-05-05 Thread Alex Baden (Jira)
Alex Baden created CALCITE-3973: --- Summary: Writing SQL hints to a string results in SQL that cannot be parsed Key: CALCITE-3973 URL: https://issues.apache.org/jira/browse/CALCITE-3973 Project: Calcite

[jira] [Created] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

2020-05-05 Thread Xiening Dai (Jira)
Xiening Dai created CALCITE-3972: Summary: Allow RelBuilder to create RelNode with convention and use it for trait convert Key: CALCITE-3972 URL: https://issues.apache.org/jira/browse/CALCITE-3972

Re: [DISCUSS] Towards Calcite 1.23.0

2020-05-05 Thread Rui Wang
Thanks for leading 1.23.0 release, Haisheng! I will actively contact Danny and Feng to see if we can reach a conclusion on https://github.com/apache/calcite/pull/1761 by next monday. -Rui On Tue, May 5, 2020 at 11:31 AM Haisheng Yuan wrote: > Yes, no problem. Will have a RC before next

Re: [DISCUSS] Towards Calcite 1.23.0

2020-05-05 Thread Haisheng Yuan
Yes, no problem. Will have a RC before next Monday, PDT. @Roman, thanks for helping. This is the PR: https://github.com/apache/calcite/pull/1953 Haisheng On 2020/05/05 14:57:48, Julian Hyde wrote: > Thanks for volunteering, Haisheng. > > Before everyone piles in with wish-lists, can we set a

Re: [DISCUSS] Towards Calcite 1.23.0

2020-05-05 Thread Julian Hyde
Thanks for volunteering, Haisheng. Before everyone piles in with wish-lists, can we set a timescale for the release? I would suggest an aggressive timescale, for example an RC a week from today. Hold the RC only for mandatory cases. Other stuff gets in if it’s ready. Julian > On May 5,

Re: Advise on ClassCastException in Linq4j$EnumeratorIterator

2020-05-05 Thread Julian Hyde
To repeat. In Enumerable convention, a SQL TIMESTAMP value must be represented as a Java Long value. Julian PS Please subscribe to the dev list, to avoid moderation delays. And do not email issues@; it is only for automatically generated emails. > On May 5, 2020, at 7:22 AM, Ayelet Morris

Re: Advise on ClassCastException in Linq4j$EnumeratorIterator

2020-05-05 Thread Ayelet Morris
+ Calcite support mailing list. Hi again, I didn't receive any response from you guys, but I continued to debug this today and managed to print the generated code and I saw a weird casting that might explain what happens there: public Object current() { final Object[] current =

Re: Advise on ClassCastException in Linq4j$EnumeratorIterator

2020-05-05 Thread Ayelet Morris
Sorry about the last email, it was a bit early... I found the exact location of the exception, in the current() method you can see the wrong cast: DateTimeUtils.floorDiv(*(Long) current[8]*, 8640L)) As I explained earlier, the type of the field is TIMESTAMP, and it cannot be cast to long this

Re: [DISCUSS] Towards Calcite 1.23.0

2020-05-05 Thread Ruben Q L
Thanks for starting the discussion, Stamatis. Just a reminder that there is a blocking issue [1] that needs to be solved (it is a regression introduced after 1.22). Apart from that, it would be nice if we could include [2] in 1.23. Best regards, Ruben [1]

Re: [DISCUSS] Towards Calcite 1.23.0

2020-05-05 Thread Roman Kondakov
Hi Haisheng, I would like to review CALCITE-3896. Do you have a PR? -- Kind Regards Roman Kondakov On 05.05.2020 06:37, Haisheng Yuan wrote: > IIRC, I am the release manager for 1.23.0. > > I think CALCITE-3896 (top-down trait request) is in good shape, it will be > nice if it can go into