Re: [CALCITE-4431] Use requireNonNull(var, "var") instead of requireNonNull(var) for better error messages

2020-12-09 Thread Haisheng Yuan
Makes sense. On 2020/12/09 22:44:35, Stamatis Zampetakis wrote: > Sounds reasonable and shares some goals with JEP358 [1] so why not. > > [1] https://openjdk.java.net/jeps/358 > > On Wed, Dec 9, 2020 at 8:26 AM Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > > > Hi, > > > > I

Re: [HELP] Local build fails

2020-12-09 Thread Chunwei Lei
Vladimir, Julian, Liya, thank you very much for your help. It works now. Best, Chunwei On Thu, Dec 10, 2020 at 4:12 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Fixed. > > Vladimir >

Re: grouping() function occurs value large than 1

2020-12-09 Thread JiaTao Tao
Got it, thanks Julian! Regards! Aron Tao Julian Hyde 于2020年12月9日周三 下午2:26写道: > GROUPING_ID is problematic for both optimizers and humans, because if the > columns are permuted the value changes, and that causes problems. I think > GROUPING is working well for our purposes. > > Of course you

[jira] [Created] (CALCITE-4433) Add UNPIVOT operator to SQL

2020-12-09 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-4433: Summary: Add UNPIVOT operator to SQL Key: CALCITE-4433 URL: https://issues.apache.org/jira/browse/CALCITE-4433 Project: Calcite Issue Type: Bug

Re: [CALCITE-4431] Use requireNonNull(var, "var") instead of requireNonNull(var) for better error messages

2020-12-09 Thread Stamatis Zampetakis
Sounds reasonable and shares some goals with JEP358 [1] so why not. [1] https://openjdk.java.net/jeps/358 On Wed, Dec 9, 2020 at 8:26 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Hi, > > I suggest we use requireNonNull(var, "var") pattern rather > than requireNonNull(var). > >

Re: [HELP] Local build fails

2020-12-09 Thread Vladimir Sitnikov
Fixed. Vladimir

Re: [HELP] Local build fails

2020-12-09 Thread Julian Hyde
Vladimir, Thanks for adding the check (and logging the gradle issue) to make sure that this doesn't happen again. However, your logic is off: > Caused by: java.lang.IllegalArgumentException: Apache Calcite requires Java > 1.8.0u202 or later. The current Java version is 13 Julian On Wed, Dec

Re: [HELP] Local build fails

2020-12-09 Thread Vladimir Sitnikov
>Try adding —no-build-cache to Gradle’s command line. It worked for me. Thanks for figuring out the cause. Just in case, the better workaround would be --rerun-tasks (it literally reruns tasks). I've added the full Java version to the cache key in