Re: discussion about the mehtod quoteStringLiteral in SqlDialect.java

2021-06-24 Thread Yanjing Wang
I have the same doubt, why don't we remove the prepending charset name? Saurabh Gupta 于2021年6月25日周五 上午9:23写道: > Hi , > The method quoteStringLiteral(StringBuilder buf, @Nullable String > charsetName,String val) > > Will convert non Ascii characters to UNICODE. Also if charset is specified >

discussion about the mehtod quoteStringLiteral in SqlDialect.java

2021-06-24 Thread Saurabh Gupta
Hi , The method quoteStringLiteral(StringBuilder buf, @Nullable String charsetName,String val) Will convert non Ascii characters to UNICODE. Also if charset is specified then it would append the charset name after the literal. Can you put some light on why we are doing this ? So here we treat

Re: [ANNOUNCE] New committer: Vladimir Ozerov

2021-06-24 Thread Julian Hyde
Welcome, Vladimir! > On Jun 24, 2021, at 6:00 PM, Albert wrote: > > Congrats. > just found the blog: https://www.querifylabs.com/author/vladimir-ozerov > > On Thu, Jun 24, 2021 at 2:27 PM Alessandro Solimando < > alessandro.solima...@gmail.com> wrote: > >> Congratulations Vladimir, well

Re: [ANNOUNCE] New committer: Vladimir Ozerov

2021-06-24 Thread Albert
Congrats. just found the blog: https://www.querifylabs.com/author/vladimir-ozerov On Thu, Jun 24, 2021 at 2:27 PM Alessandro Solimando < alessandro.solima...@gmail.com> wrote: > Congratulations Vladimir, well deserved, I had the chance to read some > of the blog posts and I have appreciated them

[jira] [Created] (CALCITE-4666) Implement PERCENTILE_CONT and PERCENTILE_DISC as logical rewrites

2021-06-24 Thread Rafay A (Jira)
Rafay A created CALCITE-4666: Summary: Implement PERCENTILE_CONT and PERCENTILE_DISC as logical rewrites Key: CALCITE-4666 URL: https://issues.apache.org/jira/browse/CALCITE-4666 Project: Calcite

Re: [Question] Obtaining aliases for group columns in aggregate (especially after AGGREGATE_PROJECT_MERGE)

2021-06-24 Thread Stamatis Zampetakis
Hi Ishan, Why do you need to do logical -> physical -> logical transformation? Regarding aliases, there is no guarantee that they will be retained. There are various places where there is some effort to keep them intact but your code shouldn't rely on this. Best, Stamatis On Tue, Jun 15, 2021

Re: [ANNOUNCE] New committer: Vladimir Ozerov

2021-06-24 Thread Alessandro Solimando
Congratulations Vladimir, well deserved, I had the chance to read some of the blog posts and I have appreciated them very much. Best regards, Alessandro On Thu, 24 Jun 2021 at 07:58, Viliam Durina wrote: > > Congratulations! > > Viliam > > On Thu, 24 Jun 2021 at 06:58, Forward Xu wrote: > > >