Re: [DISCUSS] Parser with involved tables

2022-04-13 Thread Yanjing Wang
Thanks Jacques, It's so elaborate that I get it. Jacques Nadeau 于2022年4月14日周四 03:01写道: > You need to complete validation in order to confirm that all tables are > real. For example, validation includes clarifying ambiguities (since users > can rely on implicit resolution but rel trees cannot).

Re: [DISCUSS] Rename 'master' branch to 'main' (part 2)

2022-04-13 Thread Francis Chuang
+1 as well given that the Github tooling for doing this has matured. On 14/04/2022 2:20 am, Jacques Nadeau wrote: +1 on moving this forward. Thanks for bringing it up again. On Wed, Apr 13, 2022 at 3:52 AM Stamatis Zampetakis wrote: +1 Indeed the process seems to be rather easy with

Re: [DISCUSS] Parser with involved tables

2022-04-13 Thread Jacques Nadeau
You need to complete validation in order to confirm that all tables are real. For example, validation includes clarifying ambiguities (since users can rely on implicit resolution but rel trees cannot). For #2: this is a really hard thing to do with Calcite. We did this in Apache Drill by

Re: Changes to the rule pattern interface

2022-04-13 Thread Julian Hyde
1. I agree with Jacques. Thanks, Vladimir, for asking the question ‘is progress really progress?’. We may not back out these changes (probably won’t) but it will inform future discussions. It’s valid to say ‘when did X as part of the rule refactoring, that didn’t deliver on promises’. 2.

Re: Changes to the rule pattern interface

2022-04-13 Thread Jacques Nadeau
Vladimir, It's always good to ask these kinds of questions. e.g. "Is progress really progress?" I think moving to a configuration object was a substantial improvement. Until Java has default parameters and named parameters, I don't know of another good way to make rules sufficiently configurable

[jira] [Created] (CALCITE-5092) Calcite Web: API doc search gives links with invalid "undefined" subpath resulting in 404

2022-04-13 Thread Ian Bertolacci (Jira)
Ian Bertolacci created CALCITE-5092: --- Summary: Calcite Web: API doc search gives links with invalid "undefined" subpath resulting in 404 Key: CALCITE-5092 URL: https://issues.apache.org/jira/browse/CALCITE-5092

Re: [DISCUSS] Rename 'master' branch to 'main' (part 2)

2022-04-13 Thread Jacques Nadeau
+1 on moving this forward. Thanks for bringing it up again. On Wed, Apr 13, 2022 at 3:52 AM Stamatis Zampetakis wrote: > +1 > > Indeed the process seems to be rather easy with GitHub. I assume the > changes will be propagated automatically to the Gitbox repo as well. > > Stamatis > > On Tue,

Re: [DISCUSS] Rename 'master' branch to 'main' (part 2)

2022-04-13 Thread Stamatis Zampetakis
+1 Indeed the process seems to be rather easy with GitHub. I assume the changes will be propagated automatically to the Gitbox repo as well. Stamatis On Tue, Apr 12, 2022, 10:41 PM Michael Mior wrote: > +1 > > Thanks for resurfacing this Julian. Since main is becoming the default > pretty

Re: [DISCUSS] Parser with involved tables

2022-04-13 Thread Yanjing Wang
Hi Alessandro, Thanks for your feedback, the RelOptUtil#findAllTables requires its input is a relNode, But many times we need extract all tables before validation, this has the following advantages. 1. no metadata need and fast. 2. we can compose a on-demand catalog, rather get all schemas,

Re: [DISCUSS] Parser with involved tables

2022-04-13 Thread Alessandro Solimando
Hi Yanjing, I found a discussion in the ML suggesting to use RelOptUtil#findAllTables to get all tables involved in a query: https://lists.apache.org/thread/wcfv2bhdytwsoyc3qlsnxcd7nmnnlb06 Can you check if that's what you want? Best regards, Alessandro On Wed, 13 Apr 2022 at 09:33, Yanjing

[DISCUSS] Parser with involved tables

2022-04-13 Thread Yanjing Wang
Hi Commnunity, In real scenarios, many developers want to get what tables a query statement contains. such as 'WITH t as (SELECT * FROM t1) SELECT * FROM t, t2', it only contains table t1 and t2. I tried to visit the SqlNode and found this solution is very complicated and has very many checks,