Re: PR Review Request

2022-06-22 Thread Jing Zhang
Hi everyone, This is an awesome discussion to improve collaborating between different projects. Thanks Julian, Jacques, Austin, Martijn, Timo's effort to make it happen. Best, Jing Zhang Martijn Visser 于2022年6月23日周四 01:43写道: > Hi Jacques, Julian, Austin and everyone else, > > Thank you very

CI Failed in JDK15

2022-06-22 Thread Yanjing Wang
Hi, I encountered the following failure in JDK15, but the other JDK versions are ok. https://github.com/apache/calcite/pull/2838/checks?check_run_id=7004293571 the related pr is https://github.com/apache/calcite/pull/2838, I suspect this error is accidental, is there somebody knowing about

Re: [jira] Jiajun Xie mentioned you on CALCITE-5013 (Jira) (JIRA)

2022-06-22 Thread Jess Balint
Sure I'll take a look. Thanks for raising it. On Wed, Jun 22, 2022 at 6:52 PM Julian Hyde wrote: > Can someone else do this review? > > > Begin forwarded message: > > *From: *"Jiajun Xie (Jira)" > *Subject: **[jira] Jiajun Xie mentioned you on CALCITE-5013 (Jira) (JIRA)* > *Date: *June 14,

Fwd: [jira] Jiajun Xie mentioned you on CALCITE-5013 (Jira) (JIRA)

2022-06-22 Thread Julian Hyde
Can someone else do this review? > Begin forwarded message: > > From: "Jiajun Xie (Jira)" > Subject: [jira] Jiajun Xie mentioned you on CALCITE-5013 (Jira) (JIRA) > Date: June 14, 2022 at 7:13:00 AM PDT > To: jh...@apache.org > > Jiajun Xie >

Re: CALCITE-4382: "CompileException on table with array of struct column"

2022-06-22 Thread Julian Hyde
Joshua, The usual way we work is to create a GitHub pull request. If it’s not complete, you can mark it ‘draft’, so no one would merge it to main, but people could at least look at your work. Link the pull request to https://issues.apache.org/jira/browse/CALCITE-4382

CALCITE-4382: "CompileException on table with array of struct column"

2022-06-22 Thread Joshua Maurice
Hi all, Sorry if this is the wrong list. I have a question regarding CALCITE-4382: "CompileException on table with array of struct column". I've been playing with the code, and I've managed to make nested arrays and structs of all kinds work. I'd like to merge the work to github, but I'm pretty

Re: PR Review Request

2022-06-22 Thread Martijn Visser
Hi Jacques, Julian, Austin and everyone else, Thank you very much for sharing all your experiences and providing really valuable input. I'll definitely relay this back to the original discussion thread in the Flink community. Part of bringing this information back to the Flink community is also

Re: PR Review Request

2022-06-22 Thread Timo Walther
Hi everyone, This is a really great discussion. Thanks for starting it Martijn and your input Jacques! I have been fighting against forking Calcite in Flink for years already. Even when merging forks of Flink that transitively forked Calcite, in the end we were able to resolve conflicts /

Re: Aggregates push down

2022-06-22 Thread Вадим Ахмедов
Hi Benchao, Thank you very much for your reply. Unfortunately, I did not find what you wrote in the Calcite documentation. It seems to be very sketchy. There is source code for adapters with processing aggregates, for example, Mongodb, but to understand thoroughly this it needs to spend a lot of

Re: [DISCUSS] Towards Calcite 1.31.0

2022-06-22 Thread Yanjing Wang
Thanks Andrei, now there is nobody to review these PRs, It's ok to change to 1.32,I think pr-2838 for CALCITE-5045 should be merged before 1.31, because it's simple and Yingyu Wang encountered this