Re: Calcite jars with shaded guava

2022-12-09 Thread Gian Merlino
Hmm. In that case I'm not sure why we came to the belief that newer Calcites could not be used with Guava 16.0.1. Maybe it was from reading the Calcite release notes rather than actually testing it. It would be great if this just works. I raised this PR:

[jira] [Created] (CALCITE-5428) Reduce minimum Guava version to 16.0.1.

2022-12-09 Thread Gian Merlino (Jira)
Gian Merlino created CALCITE-5428: - Summary: Reduce minimum Guava version to 16.0.1. Key: CALCITE-5428 URL: https://issues.apache.org/jira/browse/CALCITE-5428 Project: Calcite Issue Type:

Re: Calcite jars with shaded guava

2022-12-09 Thread Julian Hyde
I ran with '-Dguava.version=16.0.1' and it seems to just work. If you want this to be the new minimum, please create a Jira case and PR. Changes will be needed to main.yml (GitHub CI), comments in gradle.properties, and history.md (release notes for the upcoming release). Julian On Fri, Dec 9,

Re: Calcite jars with shaded guava

2022-12-09 Thread Gian Merlino
If Calcite ends up dropping the minimum to 16, that would certainly be helpful, and appreciated, since it would mean Druid can upgrade Calcite without needing to also tackle the Hadoop 2 problem. Please let us know if it seems like that would be in the cards! In case Calcite sticks on Guava

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2022-12-09 Thread Alessandro Solimando
Hi all, thanks Stamatis for the proposal and the work, I am a huge fan of Sonar and I really miss it on Calcite, so a big +1 from me on this. In Hive so far we have received good feedback, so I hope it will be welcomed here too. Best regards, Alessandro On Fri, 9 Dec 2022 at 19:02, Stamatis

[DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2022-12-09 Thread Stamatis Zampetakis
Hi all, I just logged CALCITE-5427 [1] for introducing code quality & coverage metrics in Calcite CI. I added some motivation and examples under the ticket so please have a look and let me know what you think. If there are no objections, I will follow-up with INFRA to set things up for the

[jira] [Created] (CALCITE-5427) Provide code quality/coverage metrics with SonarCloud and JaCoCo

2022-12-09 Thread Stamatis Zampetakis (Jira)
Stamatis Zampetakis created CALCITE-5427: Summary: Provide code quality/coverage metrics with SonarCloud and JaCoCo Key: CALCITE-5427 URL: https://issues.apache.org/jira/browse/CALCITE-5427

[jira] [Created] (CALCITE-5426) BlockBuilder should not reuse mutable objects

2022-12-09 Thread Dmitry Sysolyatin (Jira)
Dmitry Sysolyatin created CALCITE-5426: -- Summary: BlockBuilder should not reuse mutable objects Key: CALCITE-5426 URL: https://issues.apache.org/jira/browse/CALCITE-5426 Project: Calcite