Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-11 Thread Alessandro Solimando
Hi everyone, I agree with Julian that we should be open to see what value Sonar brings with the current setup, but for a true accounting we need many more data points, two examples are just not enough. In my experience I see reviewers asking contributors to fix real issues that Sonarlint plugin

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-11 Thread Julian Hyde
The instanceof case was complicated. The code that Kevin wrote was good, and appropriate, and when Sonar blocked it Stamatis was able to find an alternative formulation, which existed because, by luck, the JSR had deprecated an exception class but not its base class. I spent 30 minutes

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-11 Thread Ruben Q L
Hello, First of all, thanks Stamatis for implementing this, I think it is something good for the project. In the beginning things might be a bit complicated (as always) and we might need some adjustments / clarifications, but I hope that in the long run we'll see this as a useful feature.

Re: [ANNOUNCE] New committer: Alex Plehanov

2023-01-11 Thread Alessandro Solimando
Welcome Alex! On Wed, 11 Jan 2023 at 10:04, stanilovsky evgeny wrote: > Congratulations, Alex! > > > Welcome, Alex! > > > > Andrei Sereda 于2023年1月11日周三 01:16写道: > > > >> Welcome, Alex! > >> > >> On Tue, Jan 10, 2023, 11:01 Stamatis Zampetakis > >> wrote: > >> > >> > Welcome Alex! Looking

Re: [ANNOUNCE] New committer: Alex Plehanov

2023-01-11 Thread stanilovsky evgeny
Congratulations, Alex! Welcome, Alex! Andrei Sereda 于2023年1月11日周三 01:16写道: Welcome, Alex! On Tue, Jan 10, 2023, 11:01 Stamatis Zampetakis wrote: > Welcome Alex! Looking forward to working with you. > > Best, > Stamatis > > On Tue, Jan 10, 2023 at 2:48 AM Chunwei Lei > wrote: > > >

Re: [ANNOUNCE] New committer: Alex Plehanov

2023-01-11 Thread xiong duan
Welcome, Alex! Andrei Sereda 于2023年1月11日周三 01:16写道: > Welcome, Alex! > > On Tue, Jan 10, 2023, 11:01 Stamatis Zampetakis wrote: > > > Welcome Alex! Looking forward to working with you. > > > > Best, > > Stamatis > > > > On Tue, Jan 10, 2023 at 2:48 AM Chunwei Lei > > wrote: > > > > > Welcome,