I have merged a fix for CALCITE-5489. Thanks to Tanner and TJ for their help.
There is one failure in the build, but I'm pretty sure it is
intermittent and is related to CI infrastructure, not our code.
Jess, Go ahead and make that RC.
Julian
On Thu, Jan 26, 2023 at 10:50 AM Julian Hyde
I added two tests. One for BigQuery's TIMESTAMP_DIFF(timestamp, timestamp,
unit) and one for the standard TIMESTAMPDIFF(unit, timestamp, timestamp).
This verifies that flag literals work for both functions.
TIMESTAMP_DIFF(quarter, timestamp, timestamp) is an incorrect pattern
whether it is a flag
I tried your PR https://github.com/apache/calcite/pull/3048/files. It fixes the
bug, but the test cases you have included to not reproduce the bug. I think
that TIMESTAMP_DIFF(quarter, TIMESTAMP ‘…’, ’TIMESTAMP ‘…’) is the problematic
pattern, but you have tested TIMESTAMP_DIFF(TIMESTAMP ‘…’,
Yes I will be putting up a PR with a fix in the next hour or so. Sorry
about the hold up!
Tanner
On Thu, Jan 26, 2023 at 8:09 AM Julian Hyde wrote:
> I agree that this is a blocker.
>
> Sergey’s PR illustrates the problem but isn’t a great fix. The fix should
> look for “flag” literals in
Thanks for the warm welcome to everyone!
A few words about myself:
I am from Hungary, and I work for Cloudera.
My focus is Apache Phoenix, and its sub-projects, but I also contribute to
HBase and other projects at times.
As many of you know, one of the Phoenix sub-projects is Phoenix Query
I agree that this is a blocker.
Sergey’s PR illustrates the problem but isn’t a great fix. The fix should look
for “flag” literals in order to distinguish between the function variants. The
test case should be in a Quidem test rather than RexBuikderTest.
Tanner, do you have time to work on a
Welcome Istvan!
--
Michael Mior
mm...@apache.org
On Tue, Jan 24, 2023 at 4:58 PM Stamatis Zampetakis
wrote:
> Apache Calcite's Project Management Committee (PMC) has invited Istvan
> Toth to become a committer, and we are pleased to announce that he
> has accepted.
>
> Istvan began
Leonid Chistov created CALCITE-5502:
---
Summary: RelToSql converter generates where clause with window
expression
Key: CALCITE-5502
URL: https://issues.apache.org/jira/browse/CALCITE-5502
Project:
Stamatis Zampetakis created CALCITE-5501:
Summary: SqlToRelConverterTest.checkActualAndReferenceFiles fails
intermittently in Jenkins CI
Key: CALCITE-5501
URL:
Congrats and welcome Istvan!
> On 26 Jan 2023, at 02:16, Benchao Li wrote:
>
> Congrats Istvan!
>
> Alessandro Solimando 于2023年1月25日周三 14:56写道：
>
>> Congrats Ivan!
>>
>> On Tue 24 Jan 2023, 22:59 Francis Chuang,
>> wrote:
>>
>>> Congrats, Istvan!
>>>
>>> On 25/01/2023 8:58 am, Stamatis
According to our Jira dashboard [1] it seems there's still one blocker
issue for 1.33 [2] (it was categorized as blocker because it was a
regression).
I guess we should complete this ticket before starting the RC.
[1]
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
[2]
11 matches
Mail list logo
