Re: Extending SqlValidatorImpl with custom nodes

2023-04-17 Thread LakeShen
Hi Jonathan, In my opinion, I think SqlCreate or SqlDrop doesn't need pass it to the validator. When create table or drop table sql was parsed to SqlNode(SqlCreate Or SqlDrop),firstly you should determine what type of SqlNode it is and then use the appropriate Handler to handle your DDL

[jira] [Created] (CALCITE-5655) Wrong plan for multiple IN/SOME sub-queries with OR predicate

2023-04-17 Thread Runkang He (Jira)
Runkang He created CALCITE-5655: --- Summary: Wrong plan for multiple IN/SOME sub-queries with OR predicate Key: CALCITE-5655 URL: https://issues.apache.org/jira/browse/CALCITE-5655 Project: Calcite

Extending SqlValidatorImpl with custom nodes

2023-04-17 Thread Jonathan Sternberg
Hi, When attempting to implement new nodes, such as create table or drop table, and utilize the sql validator, what's the suggested manner for implementation? I see SqlValidatorImpl is the default implementation of the validator, but I don't see a way to add new node types to the validator. When

Re: [DISCUSS] Running Sql Logic Tests for Calcite

2023-04-17 Thread Julian Hyde
I agree with Stamatis that this has a similar “shape” to Quidem. I’d be happy to host the project under github.com/hydromatic. (If the maven group is net.hydromatic I can publish artifacts to Maven Central and Calcite could depend on those artifacts.) Regarding the frequency of testing. If we

Re: [DISCUSS] Running Sql Logic Tests for Calcite

2023-04-17 Thread Stamatis Zampetakis
Hey Mihai, Thanks for starting this discussion! Let's focus on the first question for now: Q1: Should the new slt module under PR-3145 [1] become part of Calcite repo or get its own? For those who have not followed the discussion under the CALCITE-5615 [2] let me try to summarize a few things

[jira] [Created] (CALCITE-5654) Support PostgreSQL's interval syntax

2023-04-17 Thread Tim Nieradzik (Jira)
Tim Nieradzik created CALCITE-5654: -- Summary: Support PostgreSQL's interval syntax Key: CALCITE-5654 URL: https://issues.apache.org/jira/browse/CALCITE-5654 Project: Calcite Issue Type: