Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-24 Thread Benchao Li
Thanks Mihai for the quick response, I'll take a look at the PR. Mihai Budiu 于2023年10月25日周三 05:02写道: > > For the blocker issues, I have filed two PRs which should collectively fix > them. > > https://github.com/apache/calcite/pull/3481 fixes > https://issues.apache.org/jira/browse/CALCITE-5990,

[jira] [Created] (CALCITE-6071) RexNode should carry source position information for runtime error reporting

2023-10-24 Thread Mihai Budiu (Jira)
Mihai Budiu created CALCITE-6071: Summary: RexNode should carry source position information for runtime error reporting Key: CALCITE-6071 URL: https://issues.apache.org/jira/browse/CALCITE-6071 Projec

Re: Runtime error with source position

2023-10-24 Thread Julian Hyde
I don’t think any such code exists in Calcite. When I spoke recently I may have mistakenly said that Calcite had such code, but I was thinking of Morel. If you look at commit https://github.com/hydromatic/morel/commit/21c6fef0bfd2c0aa7f8ff83e83a025ab5b675876 you will see that I added a ‘pos’ ar

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-24 Thread Mihai Budiu
For the blocker issues, I have filed two PRs which should collectively fix them. https://github.com/apache/calcite/pull/3481 fixes https://issues.apache.org/jira/browse/CALCITE-5990, but does not include tests, because the test fixture needs to be fixed as well for the tests to pass. There are

Runtime error with source position

2023-10-24 Thread Mihai Budiu
Hello, I would like to have some runtime errors, such as division by 0, report to the user the source code position of the original operation within the SQL query. However, I could not find any examples that do that, and I am not sure how this information can be propagated through the Rel repre

Re: [DISCUSS] Towards Calcite 1.36.0

2023-10-24 Thread Benchao Li
A quick update on the current status for issues targeted 1.36.0 We need more reviewers for #2 and #3 since the end of October is approaching. Please correct me if I'm mistaken, especially for issues in #1. #1. Issues already have reviewers, and seems promising to be merged shortly https://issues

Re: Reviewing blog post

2023-10-24 Thread Stamatis Zampetakis
Great content Mihai, thanks for putting this together! As Julian suggested the whole content of the blog could be put in a news entry under the respective page [1]. Alternatively, if it is a link to an external site you could add it under the external resources section [2]. Many apache projects a