Re: [DISCUSS] Binary files for testing InnoDB adapter

2020-07-17 Thread Michael Mior
That explanation makes sense to me. +1 Since it can't be easily automated, I'd suggest we include a very brief description of how to recreate the file. -- Michael Mior mm...@apache.org Le jeu. 16 juil. 2020 à 15:28, Julian Hyde a écrit : > > Michael, > > I think that sentence covers the

Re: [DISCUSS] Binary files for testing InnoDB adapter

2020-07-16 Thread Forward Xu
+1 If we can add the function(Example: innodb-java-writer) of generating ibd files in the next version, I think it will be better. In this way, InnoDB adapter initially has the capability of a database, and can further improve the current unit test. best Forward Stamatis Zampetakis

Re: [DISCUSS] Binary files for testing InnoDB adapter

2020-07-16 Thread Stamatis Zampetakis
Hello, It's good to avoid non-readable files when possible but I don't think we have to worry too much about it. The ASF foundation does not require all files in a release to be protected by copyright law and lists a few exceptions [1]. The file is a database dump so I don't see much creativity

Re: [DISCUSS] Binary files for testing InnoDB adapter

2020-07-16 Thread Enrico Olivelli
Il Gio 16 Lug 2020, 21:28 Julian Hyde ha scritto: > Michael, > > I think that sentence covers the situation where, say, we ship a > .class file without shipping the .java it was generated from. > > In our case, we are shipping the equivalent of the .class file and the > .java file (namely

Re: [DISCUSS] Binary files for testing InnoDB adapter

2020-07-16 Thread Julian Hyde
Michael, I think that sentence covers the situation where, say, we ship a .class file without shipping the .java it was generated from. In our case, we are shipping the equivalent of the .class file and the .java file (namely EMP.ibd and the scott.sql that MySQL generated it from). We have to

Re: [DISCUSS] Binary files for testing InnoDB adapter

2020-07-16 Thread Michael Mior
I don't personally have a problem with this, but it seems as though it might violate the release policy. Specifically the statement "It is also necessary for the PMC to ensure that the source package is sufficient to build any binary artifacts associated with the release."

Re: [DISCUSS] Binary files for testing InnoDB adapter

2020-07-15 Thread Enrico Olivelli
IMHO If you need those files for tests and you don't have a way to generate them it is allowed to keep them. You can add some readme file that explain their nature. You can also add a check sum file. Just my 2 cents Enrico Il Gio 16 Lug 2020, 05:40 Francis Chuang ha scritto: > I am +1 for

[DISCUSS] Binary files for testing InnoDB adapter

2020-07-15 Thread Julian Hyde
TL;DR: PMC members, would you vote for a release 1.24 if it includes binary files necessary for testing? I would like to include the InnoDB adapter [1] in release 1.24. It is well written, well documented, and it is ready. There is one problem: there are some binary files (in InnoDB format) [2]