Re: [DISCUSS] Small contributions

.de> wrote: > >> Yes, I totally agree that's a major change by any means. As Julian pointed >> out above its only about non-code changes. >> >> Julian >> >> From: Andrei Sereda >> Sent: Friday, September 27, 2019 7:2

Re: [DISCUSS] Small contributions

@calcite.apache.org > Subject: Re: [DISCUSS] Small contributions > > I presume 3rd party library upgrades should go through regular process > (jira/PR etc.) ? > > Dependency upgrade is not considered "small change" since impact is > greater than just a "t

Re: [DISCUSS] Small contributions

Yes, I totally agree that's a major change by any means. As Julian pointed out above its only about non-code changes. Julian From: Andrei Sereda Sent: Friday, September 27, 2019 7:25:56 PM To: dev@calcite.apache.org Subject: Re: [DISCUSS] Small contributions I

Re: [DISCUSS] Small contributions

gt; >> I agree that we should accept these small changes but not create JIRA > for them. > >> In my opinion, maybe we can label the PR of these small changes. And > process them at regular intervals in case of forgetting. > >> > >> best, > >> -

Re: [DISCUSS] Small contributions

t; wenhui >> >> >> >> winifred.wenhui.t...@gmail.com >> >> From: Haisheng Yuan >> Date: 2019-09-26 10:17 >> To: Francis Chuang; dev@calcite.apache.org (dev@calcite.apache.org) >> Subject: Re: Re: [DISCUSS] Small contributions >>> mo

Re: Re: [DISCUSS] Small contributions

mall changes. And process > them at regular intervals in case of forgetting. > > best, > -- > wenhui > > > > winifred.wenhui.t...@gmail.com > > From: Haisheng Yuan > Date: 2019-09-26 10:17 > To: Francis Chuang; dev@calcite.apache.org (dev@calcite.apache.or

Re: Re: [DISCUSS] Small contributions

10:17 To: Francis Chuang; dev@calcite.apache.org (dev@calcite.apache.org) Subject: Re: Re: [DISCUSS] Small contributions > most of the time, the author of the fix would have moved on and have forgotten about it, resulting in the improvement falling through the cracks. ​Make sense. I think

Re: Re: [DISCUSS] Small contributions

> cracks. > > ​Make sense. I think our current position worth reconsidering and I > agree with Francis. > > - Haisheng > > -- > 发件人：Francis Chuang > 日 期：2019年09月26日 09:20:49 > 收件人： > 主 题：Re: [DISCUSS] Smal

Re: Re: [DISCUSS] Small contributions

eng -- 发件人：Francis Chuang 日　期：2019年09月26日 09:20:49 收件人： 主　题：Re: [DISCUSS] Small contributions From personal experience, I think we should accept these small changes. I have had lots of cases where I am reading code or documentation on Github and found small errors or ty

Re: [DISCUSS] Small contributions

From personal experience, I think we should accept these small changes. I have had lots of cases where I am reading code or documentation on Github and found small errors or typos that are easy to fix, so I'd edit directly in Github and open a PR. These changes do improve the codebase and fix

Re: [DISCUSS] Small contributions

I have mixed feelings about this, because on one hand, I'd like to have these things corrected but on the other hand, we're already bogged down with PRs. Perhaps a good compromise is to make it clear that a JIRA should not be created and have some type of tag indicated in the title of the PR. This

[DISCUSS] Small contributions

I noticed this exchange in https://github.com/apache/calcite/pull/1475: > Q. Just curious, does Calcite accept hotfix style PR that fixes typos, > comments, etc.? > A. As long as they are large enough. But for 1 line typo fix, it is not worth >