Re: [DISCUSS] Towards Calcite 1.31.0

Andrei, If you discovered something that may be of use to the next RM, can you add a note to CALCITE-4856? (Even though that issue is closed, it still seems to be the best place to put troubleshooting tips.) Julian On Fri, Jul 22, 2022 at 8:06 PM Andrei Sereda wrote: > > It should be all good

Re: [DISCUSS] Towards Calcite 1.31.0

It should be all good now. My problem was that I use different accounts for github and gitbox. For some reason the gradle release plugin was using github credentials ( asfGitSourceUsername property) and not nexus ones (asfNexusUsername) from ~/.gradle/gradle.properties. Maybe because of the

Re: [DISCUSS] Towards Calcite 1.31.0

Thanks, Julian. I did include GITBOX in the prepare vote command. $ gradle prepareVote -Prc=0 -Pasf -Pasf.git.pushRepositoryProvider=GITBOX On Fri, Jul 22, 2022 at 1:31 PM Julian Hyde wrote: > Andrei, Are you perhaps running into > https://issues.apache.org/jira/browse/CALCITE-4856 ? > > On

Re: [DISCUSS] Towards Calcite 1.31.0

Andrei, Are you perhaps running into https://issues.apache.org/jira/browse/CALCITE-4856 ? On Fri, Jul 22, 2022 at 7:36 AM Andrei Sereda wrote: > > Quick update. > > I've addressed all comments in the release notes PR. > > While tagging RC0, I've run into small issue with apache gitbox >

Re: [DISCUSS] Towards Calcite 1.31.0

Quick update. I've addressed all comments in the release notes PR. While tagging RC0, I've run into small issue with apache gitbox authorization (see below) but should be able to solve them (I've released 1.25 in the past without problems with the new gradle process) > Task :pushRcTag Pushing

Re: [DISCUSS] Towards Calcite 1.31.0

Hi Julian, I think it is a great idea. Please take a look at proposed release notes: https://github.com/apache/calcite/pull/2858 Thanks, Andrei. On Wed, Jul 20, 2022 at 4:31 PM Julian Hyde wrote: > Andrei, > > One thing that has worked well is for the RM to create a PR with the > release

Re: [DISCUSS] Towards Calcite 1.31.0

Andrei, One thing that has worked well is for the RM to create a PR with the release notes. People can then review the release notes, comment on that PR, and add their own release notes. As RM you would not submit the PR, but instead manually rebase onto the final RC. Julian > On Jul 19,

Re: [DISCUSS] Towards Calcite 1.31.0

Hello, Anything specific you'd like to be added to the release notes of 1.31 ? If so, please provide a short summary as well as JIRA id. Andrei. On Tue, Jul 12, 2022 at 10:07 PM Andrei Sereda wrote: > Hi Julian, > > > > Andrei, Are there any remaining blockers for 1.31? > No blockers for

Re: [DISCUSS] Towards Calcite 1.31.0

Hi Julian, > Andrei, Are there any remaining blockers for 1.31? No blockers for 1.31. Any pending issues can be moved towards 1.32. > Can we proceed with an RC0? Yes, I'll start the release very soon. Thanks for fixing the regression. Andrei. On Tue, Jul 12, 2022 at 4:35 PM Julian Hyde

Re: [DISCUSS] Towards Calcite 1.31.0

I merged https://issues.apache.org/jira/browse/CALCITE-5194 , the fix for the regression due to https://issues.apache.org/jira/browse/CALCITE-35 , yesterday. Andrei, Are there any remaining

Re: [DISCUSS] Towards Calcite 1.31.0

Thanks Andrei, now there is nobody to review these PRs, It's ok to change to 1.32，I think pr-2838 for CALCITE-5045 should be merged before 1.31, because it's simple and Yingyu Wang encountered this

Re: [DISCUSS] Towards Calcite 1.31.0

Julian, how much time do you think is necessary to fix CALCITE-35 regression ? Yanjing, I see some discussions/attempts in JIRA/github to review the PRs. Do you think it can still be reviewed and merged before 1.31 ? Viliam (and Julian), thanks for fixing (and merging) CALCITE-5157 Dmitry (and

Re: [DISCUSS] Towards Calcite 1.31.0

I agree that it’s a regression, and caused by my CALCITE-35 change. I’ve assigned the bug to myself. I’m not sure I have time to fix it this week, so we can back out my change if necessary to get the release out on schedule. If someone else can fix it I would be grateful. > On Jun 19, 2022,

Re: [DISCUSS] Towards Calcite 1.31.0

Hello, I have found the following regression while verifying the new release to work with Apache Drill: https://issues.apache.org/jira/browse/CALCITE-5194. This issue appeared after changes for https://issues.apache.org/jira/browse/CALCITE-35. Since it is a regression, I suggest treating it as

Re: [DISCUSS] Towards Calcite 1.31.0

I'll try to work on comments in CALCITE-5157 today On Wed, 15 Jun 2022 at 07:30, Yanjing Wang wrote: > Hi Andrei, > The followings need review process to merge. > https://issues.apache.org/jira/browse/CALCITE-4512 >

Re: [DISCUSS] Towards Calcite 1.31.0

Hi Andrei, The followings need review process to merge. https://issues.apache.org/jira/browse/CALCITE-4512 https://issues.apache.org/jira/browse/CALCITE-5045 https://issues.apache.org/jira/browse/CALCITE-5043 https://issues.apache.org/jira/browse/CALCITE-4987 It would be great if they were fixed

Re: [DISCUSS] Towards Calcite 1.31.0

Hi! It would be good to merge: https://issues.apache.org/jira/browse/CALCITE-5134 https://issues.apache.org/jira/browse/CALCITE-5127 Both of those issues are related to correct execution queries with subqueries. On Tue, Jun 14, 2022 at 6:59 AM Andrei Sereda wrote: > Thanks to all who reviewed

Re: [DISCUSS] Towards Calcite 1.31.0

Thanks to all who reviewed the PRs for 1.31 release. There are about 16 issues remaining tagged for 1.31 (list

Re: [DISCUSS] Towards Calcite 1.31.0

I’m on vacation this week so don’t ask me to review PRs. It looks like we’re on course for an RC this week, and definitely don’t wait for me. Maybe we can get a few more PRs merged before then, and move the rest to 1.32 (or clear the fix version if the person who agreed to fix the bug has not

Re: [DISCUSS] Towards Calcite 1.31.0

Hello, I have created a JIRA filter for 1.31 release.

Re: [DISCUSS] Towards Calcite 1.31.0

Hello, Could we also include https://github.com/apache/calcite/pull/2305 into this release? I have rebased it onto the latest master and fixed all merge conflicts. Kind regards, Volodymyr Vysotskyi On 2022/05/30 17:57:28 Julian Hyde wrote: > Viliam, I marked the Jira case ‘fix in 1.31’ so that

Re: [DISCUSS] Towards Calcite 1.31.0

Viliam, I marked the Jira case ‘fix in 1.31’ so that someone will at least review your PR. > On May 30, 2022, at 7:09 AM, Viliam Durina > wrote: > > Our PR is reasonably simple and as far as I'm aware, it doesn't need more > changes, we'd be glad to find a reviewer and having it merged: >

Re: [DISCUSS] Towards Calcite 1.31.0

Our PR is reasonably simple and as far as I'm aware, it doesn't need more changes, we'd be glad to find a reviewer and having it merged: https://github.com/apache/calcite/pull/2808 Viliam On Fri, 27 May 2022 at 21:49, Julian Hyde wrote: > +1 mid-june release, and thank you to Ruben for sending

Re: [DISCUSS] Towards Calcite 1.31.0

+1 mid-june release, and thank you to Ruben for sending the reminder. Three weeks ago we had a discussion about the fixVersion [1] field and seemed to reach consensus. There were new responsibilities for the release manager, as described here by Ruben: > Before starting the release process for

Re: [DISCUSS] Towards Calcite 1.31.0

+1 for mid-June for the first RC. Benchao Li 于2022年5月26日周四 10:31写道： > +1 for mid-June for the first RC. > Thanks Ruben for driving this, and Andrei for being the RM. > > For me, I have two PRs[1][2] which I think it's good to have them in 1.31.0 > And for other issues which I've not opened pr

Re: [DISCUSS] Towards Calcite 1.31.0

+1 for mid-June for the first RC. Thanks Ruben for driving this, and Andrei for being the RM. For me, I have two PRs[1][2] which I think it's good to have them in 1.31.0 And for other issues which I've not opened pr yet, I think it's reasonable to postpone them to next version. [1]

Re: [DISCUSS] Towards Calcite 1.31.0

> Andrei, are you still available for the task? Yes. I'm happy to be the Release Manager for 1.31 On Wed, May 25, 2022 at 9:15 PM Chunwei Lei wrote: > Thank you for taking care of this, Ruben. > > +1 for mid-June for the first RC. > > > Best, > Chunwei > > > On Wed, May 25, 2022 at 4:26 PM

Re: [DISCUSS] Towards Calcite 1.31.0

Thank you for taking care of this, Ruben. +1 for mid-June for the first RC. Best, Chunwei On Wed, May 25, 2022 at 4:26 PM Ruben Q L wrote: > Hello, > > It has been more than two months since our last release [1], and I think we > should make an effort to continue keeping the rhythm of one

[DISCUSS] Towards Calcite 1.31.0

Hello, It has been more than two months since our last release [1], and I think we should make an effort to continue keeping the rhythm of one release every two months approximately. If I am not mistaken, the next release manager would be Andrei Sereda [2]. Andrei, are you still available for