Re: [QUESTION]: Bug Fix Release

2023-03-09 Thread James Turton
Thanks Julian, I'll definitely discuss this with the others. I wonder if some cases, such as Drill's DATE_DIFF which looks a little quirky and incompatible at this point, may not merit a promotion to being tested upstream. That is, if Drill wants to have an unusual DATE_DIFF then it must

Re: [QUESTION]: Bug Fix Release

2023-03-09 Thread Julian Hyde
James, As we have both discovered, the function sets of other DBMSs are confusing and often contradictory. In some cases, DBMS vendors add functions for compatibility with other DBMSs, we attempt to emulate those clones, and discover differences with the originals. In the past few weeks, Tanner,

Re: [QUESTION]: Bug Fix Release

2023-03-08 Thread James Turton
Much appreciated. I only have so much know-how in this area but CALCITE-5469 looks completely normal to me, just something that we need to accommodate due to Drill having at some point settled on a conflicting definition of DATE_DIFF that seems to resemble Hive and MySQL's DATEDIFFs (no

Re: [QUESTION]: Bug Fix Release

2023-03-08 Thread Tanner Clary
Hello, With regards to the unrelated issue with DATE_DIFF, I authored CALCITE-5469 so perhaps if you want to open a new thread or post a comment on the case itself, I would be happy to take a look. Best, Tanner On Wed, Mar 8, 2023 at 8:42 AM James Turton wrote: > Hi > > All of Drill's

Re: [QUESTION]: Bug Fix Release

2023-03-08 Thread James Turton
Hi All of Drill's DATE_TRUNC unit tests pass when Drill uses calcite-1.34.0-SNAPSHOT (and once we accommodate the new QUALIFY clause). While we do now have an unrelated issue with DATE_DIFF which I believe has resulted from the introduction of a three parameter DATE_DIFF function in

Re: [QUESTION]: Bug Fix Release

2023-03-07 Thread Charles Givre
Will do. Sent from my iPhone > On Mar 6, 2023, at 17:12, Stamatis Zampetakis wrote: > > Hey Charles, > > Please test Drill with the latest calcite-1.34.0-SNAPSHOT [1] and if all is > good on your end I will prepare an RC for vote. > > Best, > Stamatis > > [1] >

Re: [QUESTION]: Bug Fix Release

2023-03-06 Thread Stamatis Zampetakis
Hey Charles, Please test Drill with the latest calcite-1.34.0-SNAPSHOT [1] and if all is good on your end I will prepare an RC for vote. Best, Stamatis [1] https://repository.apache.org/content/groups/snapshots/org/apache/calcite/calcite-core/1.34.0-SNAPSHOT/ On Sun, Mar 5, 2023 at 7:16 PM

Re: [QUESTION]: Bug Fix Release

2023-03-05 Thread Charles Givre
Julian, Now that Drill is on main Calcite instead of the fork, I'll commit that the Drill community will do our best to try Drill with the RC candidates to see if we can catch issues during the release cycle. Thanks, -- C > On Mar 5, 2023, at 12:20 PM, Julian Hyde wrote: > > It was indeed

Re: [QUESTION]: Bug Fix Release

2023-03-05 Thread Julian Hyde
It was indeed a regression, but it didn’t break any of Calcite’s tests and no one spoke up during the release vote. Mistakes are expensive to fix after a release, cheaper during the release vote, and cheapest of all if found by the test suite. > On Mar 5, 2023, at 6:33 AM, Charles Givre

Re: [QUESTION]: Bug Fix Release

2023-03-05 Thread Charles Givre
That would be great! Again I’m only asking because this was a regression. I really do appreciate it. Thanks! Sent from my iPhone > On Mar 4, 2023, at 13:59, Stamatis Zampetakis wrote: > > If we get the 1.34.0 out a bit sooner than usual I guess this will be good > enough for Drill. If

Re: [QUESTION]: Bug Fix Release

2023-03-04 Thread Stamatis Zampetakis
If we get the 1.34.0 out a bit sooner than usual I guess this will be good enough for Drill. If the others agree I can try to prepare an RC during next week. WDYT ? Best, Stamatis On Sat, Mar 4, 2023, 6:13 PM Alessandro Solimando < alessandro.solima...@gmail.com> wrote: > The second option

Re: [QUESTION]: Bug Fix Release

2023-03-04 Thread Alessandro Solimando
The second option Benchao mentions is what Hive currently does as well. Best regards, Alessandro On Sat 4 Mar 2023, 13:19 Benchao Li, wrote: > Hi Charles, > > Thank for reaching out! > > IIRC, the idea of releasing bugfix version has been brought up in the past, > but I couldn't find the

Re: [QUESTION]: Bug Fix Release

2023-03-04 Thread Benchao Li
Hi Charles, Thank for reaching out! IIRC, the idea of releasing bugfix version has been brought up in the past, but I couldn't find the discussion (in Jira and dev ML). I'd like to share my understanding why we chose not to release bug fix versions, please correct me if I'm wrong, - Calcite has

[QUESTION]: Bug Fix Release

2023-03-01 Thread Charles Givre
Hello Calcite Devs, I wanted to thank everyone for the recent release of Calcite 1.33. I am the PMC Chair for Apache Drill and we just released Drill 1.21[0] which is now using the latest version of Calcite instead of our 2-3 year old fork! However, we encountered a small issue with Calcite