[CANCEL] [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-05 Thread Stamatis Zampetakis
The vote for Apache Calcite 1.21.0 release candidate 0 was cancelled due to spurious .xml.xxx files in the binaries Thanks to all who voted. A new release will be tagged as 1.21.0-rc1 and will be available for voting soon. Best, Stamatis

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-05 Thread Danny Chan
> I removed the "[hotfix]" and "[doc]" tags from the commit messages. I > don't think we need to create our own "tag language" in commit > messages. I agree, thanks. Best, Danny Chan 在 2019年9月6日 +0800 PM12:55,dev@calcite.apache.org,写道: > > I removed the "[hotfix]" and "[doc]" tags from the

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-05 Thread Julian Hyde
Darn it. I had already started on this, and put in a couple of hours of work cleaning things up. I've pushed my changes anyway, to my branch https://github.com/julianhyde/calcite/tree/branch-1.21. I also made some copy edits to the release notes. Stamatis can cherry-pick it all into the official

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-05 Thread Danny Chan
Julian, I have merged these PRs. https://github.com/apache/calcite/pull/1435: merged https://github.com/apache/calcite/pull/1438: merged and mark fixed at version 1.21 https://github.com/apache/calcite/pull/1431: merged Best, Danny Chan 在 2019年9月6日 +0800 AM4:35,dev@calcite.apache.org,写道: > >

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-05 Thread Julian Hyde
on-binding) >>>> >>>> On Wed, Sep 4, 2019 at 2:55 AM Julian Hyde wrote: >>>> >>>>> Regarding the 'ps' failures. I've added a suggestion to >>>>> >>>>> >> https://issues.apache.org/jira/browse/CALCITE-2816?focusedComme

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-05 Thread Stamatis Zampetakis
tinue conversation there. Release threads are not a place > for > > > > technical discussion. > > > > > > > > On Tue, Sep 3, 2019 at 3:42 AM Julian Feinauer > > > > wrote: > > > > > > > > > > Thanks Vladimir, > > &g

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-05 Thread Danny Chan
t; which also causes problems with parsing frequently. > > > > > > > > I think we should either fix that or note it somewhere in the how to to > > > ensure that people can reproduce the build, so I think I should keep my -1 > > > (but it's not binding so no

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-04 Thread Julian Hyde
gt; >>> I think we should either fix that or note it somewhere in the how to to >> ensure that people can reproduce the build, so I think I should keep my -1 >> (but it's not binding so not that big of an issue). >>> >>> Julian >>> >>> Vo

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-04 Thread Anton Haidai
e that people can reproduce the build, so I think I should keep my -1 > (but it's not binding so not that big of an issue). > > > > Julian > > > > Von meinem Mobiltelefon gesendet > > > > > > ---- Ursprüngliche Nachricht > > Betreff: Re: [VOT

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-03 Thread Julian Hyde
somewhere in the how to to > ensure that people can reproduce the build, so I think I should keep my -1 > (but it's not binding so not that big of an issue). > > Julian > > Von meinem Mobiltelefon gesendet > > > Ursprüngliche Nachricht ---- > Betreff: Re: [VOTE]

AW: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-03 Thread Julian Feinauer
not binding so not that big of an issue). Julian Von meinem Mobiltelefon gesendet Ursprüngliche Nachricht Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0) Von: Vladimir Sitnikov An: Apache Calcite dev list Cc: It is a "well known&q

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-03 Thread Danny Chan
Thanks, Stamatis, here are the things I have checked: • The commit hash code correct • The src package sha256 code correct • Checked LICENSE and NOTICE • Checked no unexpected binaries I didn’t encounter the problem of Julian Feinauer, so I’m + 1 for the release. Best, Danny Chan 在 2019年9月2日

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-03 Thread Vladimir Sitnikov
It is a "well known" https://issues.apache.org/jira/browse/CALCITE-2816 PsTableFunction fails in Russian locale In other words, "float number parsing is locale-sensitive". Vladimir

AW: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-03 Thread Julian Feinauer
Hi Stamatis, Yes, if it works for you then I'll try to track that down and file a Jira. Julian Von meinem Mobiltelefon gesendet Ursprüngliche Nachricht Betreff: Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0) Von: Stamatis Zampetakis An: dev@calcite.apache.org

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-03 Thread Stamatis Zampetakis
Thanks for raising this Julian. I tested today on MacOS Mojave (10.14.5) and jdk 1.8.0_111 and build (mvnw install) finishes without errors. I guess the problem you raised is related to your local environment. Can you please log a JIRA with more details on what happens? Can you also check if

Re: [VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-02 Thread Julian Feinauer
Hi Stamatis, thank you for your effort! Unfortunately, I think I have to vote -1 (non-binding) as I encountered an issue building the artefacts with the given instruction (see below). But as my vote is non-binding it's up to the more experienced devs to decide how to handle this case

[VOTE] Release apache-calcite-1.21.0 (release candidate 0)

2019-09-02 Thread Stamatis Zampetakis
Hi all, I have created a build for Apache Calcite 1.21.0, release candidate 0. Thanks to everyone who has contributed to this release. This release comes two months after 1.20.0 and brings many bug fixes and new important features among others the following. * Support for implicit casts. *