Re: [calcite] branch master updated: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner

2019-02-28 Thread Michael Mior
Laurent did answer my objection and indicate he's willing to revert. I'm ok with the provided explanation. (Although an unrelated note, things like "Fix checkstyle error" and "Fix grammar errors" should not be part of the final commit message.) -- Michael Mior mm...@apache.org Le mer. 27 févr.

Re: [calcite] branch master updated: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner

2019-02-27 Thread Julian Hyde
Laurent, Michael had started reviewing this and had some objections. Please don’t summarily commit. Julian > On Feb 27, 2019, at 1:07 PM, laur...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > laurent pushed a commit to branch master > in