Re: JDK 8 syntax

Sure, I'll prepare the fix, just wanted to share good news :) Kind regards, Volodymyr Vysotskyi On Tue, Aug 28, 2018 at 8:41 PM Julian Hyde wrote: > Excellent. Can you commit the fix please, Vova? > > > On Aug 28, 2018, at 10:34 AM, Vova Vysotskyi wrote: > > > > Hi all, > > > > Janino issue

Re: JDK 8 syntax

Excellent. Can you commit the fix please, Vova? > On Aug 28, 2018, at 10:34 AM, Vova Vysotskyi wrote: > > Hi all, > > Janino issue with > this "strange" default method was fixed, so now we can revert the temporary > fix made in CALCITE-2261

Re: JDK 8 syntax

Hi all, Janino issue with this "strange" default method was fixed, so now we can revert the temporary fix made in CALCITE-2261 and update Janino version to 3.0.9. Kind regards, Volodymyr

Re: JDK 8 syntax

Patch merged! Welcome to java 8 ! Enrico Il mar 17 apr 2018, 17:09 Enrico Olivelli ha scritto: > Issue > https://issues.apache.org/jira/browse/CALCITE-2261 > > Patch > https://github.com/apache/calcite/pull/667 > > Cheers > Enrico > > > 2018-04-17 16:51 GMT+02:00 Enrico

Re: JDK 8 syntax

Issue https://issues.apache.org/jira/browse/CALCITE-2261 Patch https://github.com/apache/calcite/pull/667 Cheers Enrico 2018-04-17 16:51 GMT+02:00 Enrico Olivelli : > Vova, > I tried to add some "default" methods and all tests are passing (maybe you > already saw this). >

Re: JDK 8 syntax

Vova, I tried to add some "default" methods and all tests are passing (maybe you already saw this). Thank you ! I will be happy to contribute my patch as it is really simple and I have it on my laptop Enrico 2018-04-17 15:49 GMT+02:00 Vova Vysotskyi : > Taking a step to the

Re: JDK 8 syntax

Taking a step to the side of a workaround, the current version of Janino prefers default methods instead of "abstract", so we may declare *SchemaPlus.getSubSchema()* method as default and it will help to choose this method instead of the method from the parent interface :) Kind regards, Volodymyr

Re: JDK 8 syntax

I have tried to add an 'unwrap' method to Schema but then Janino keeps breaking for other similar reasons about method overriding with narrower return types. I guess it will be an hard task to adapt Calcite code. The approach of working on Janino is better. Enrico Il dom 15 apr 2018, 14:43

Re: JDK 8 syntax

Il dom 15 apr 2018, 14:22 Vova Vysotskyi ha scritto: > I have reproduced it in Janino only and created the issue: > https://github.com/janino-compiler/janino/issues/47 Great work Vova, Thank you Enrico > > > > Kind regards, > Volodymyr Vysotskyi > > 2018-04-14 20:15

Re: JDK 8 syntax

I have reproduced it in Janino only and created the issue: https://github.com/janino-compiler/janino/issues/47 Kind regards, Volodymyr Vysotskyi 2018-04-14 20:15 GMT+03:00 Vova Vysotskyi : > Ok, I will try to prepare a test case and will log a bug on Janino soon. > > Kind

Re: JDK 8 syntax

Ok, I will try to prepare a test case and will log a bug on Janino soon. Kind regards, Volodymyr Vysotskyi 2018-04-14 20:02 GMT+03:00 Julian Hyde : > Vova, > > Thanks for doing the research. Your explanation sounds very plausible > (I suspected default methods, too). Can you

Re: JDK 8 syntax

Vova, Thanks for doing the research. Your explanation sounds very plausible (I suspected default methods, too). Can you please log a bug on JANINO? https://github.com/janino-compiler/janino/issues Arno, the project maintainer, has been very good to us over the years. Julian On Sat, Apr 14,

Re: JDK 8 syntax

Il sab 14 apr 2018, 18:20 Enrico Olivelli ha scritto: > > > Il sab 14 apr 2018, 17:39 Vova Vysotskyi ha scritto: > >> Hi all, >> >> I think the reason for this issue is that at the compile stage was assumed >> that *getSubSchema()* method returns *Schema

Re: JDK 8 syntax

Il sab 14 apr 2018, 17:39 Vova Vysotskyi ha scritto: > Hi all, > > I think the reason for this issue is that at the compile stage was assumed > that *getSubSchema()* method returns *Schema *inheritor, but not > *SchemaPlus*. > But the interesting thing is that with Java 8,

Re: JDK 8 syntax

Hi all, I think the reason for this issue is that at the compile stage was assumed that *getSubSchema()* method returns *Schema *inheritor, but not *SchemaPlus*. But the interesting thing is that with Java 8, methods list of *SchemaPlus *interface contains default *getSubSchema()* method. It may

Re: JDK 8 syntax

I’d really appreciate that. Can you please log a JIRA case, and record your observations/progress there. There’s no particular hurry on this one. Julian > On Apr 10, 2018, at 06:32, Enrico Olivelli wrote: > > 2018-04-10 13:48 GMT+02:00 Julian Hyde

Re: JDK 8 syntax

2018-04-10 13:48 GMT+02:00 Julian Hyde : > Yes, that’s it. > > Next step would be to check whether the generated code is the same as > previously, and if so, it is a Janino bug. Then try to create a minimal > test case for Janino. Maybe we can work around by adding an

Re: JDK 8 syntax

This is "the" error (see below). Unfortunately just be upgrading Janino to 3.0.8 the problem still is present. the only 'unwrap' word in the generated code is here ... public org.apache.calcite.linq4j.Enumerable bind(final org.apache.calcite.DataContext root0) { root = root0; final

Re: JDK 8 syntax

Awesome! On Mon, Apr 9, 2018 at 1:29 PM Enrico Olivelli wrote: > Il lun 9 apr 2018, 22:20 Cade Markegard ha > scritto: > > > Not sure if this is related, but it seems like Janino doesn't support > Java8 > > lambdas under "Limitations" in

Re: JDK 8 syntax

Not sure if this is related, but it seems like Janino doesn't support Java8 lambdas under "Limitations" in http://janino-compiler.github.io/janino/ On Mon, Apr 9, 2018 at 12:54 PM Julian Hyde wrote: > I didn’t try. We’re on janino 2.7.6. The 2.x line only goes up to 2.7.8. >

Re: JDK 8 syntax

I didn’t try. We’re on janino 2.7.6. The 2.x line only goes up to 2.7.8. I’m not eager to try upgrading to 3.x (latest release is 3.0.8) especially as they don’t explicitly mention fixing a JDK 8 issue. http://janino-compiler.github.io/janino/changelog.html

Re: JDK 8 syntax

Il lun 9 apr 2018, 21:37 Julian Hyde ha scritto: > Don’t have the error stack, but janino could not compile generated code > because it said an “unwrap” method did not exist. > > There were no lambdas. I think perhaps that version of janino could not > fully understand the

Re: JDK 8 syntax

Don’t have the error stack, but janino could not compile generated code because it said an “unwrap” method did not exist. There were no lambdas. I think perhaps that version of janino could not fully understand the Calcite class files. To reproduce, change 2 lines in core/pom.xml and run “mvn

Re: JDK 8 syntax

Il lun 9 apr 2018, 19:05 Julian Hyde ha scritto: > Has anyone had any luck using JDK 8 syntax (e.g. “->” for lambdas) in > Calcite? > > In core/pom.xml I changed source=1.7 target=1.7 to source=8 target=8 and > it allowed the syntax but it seemed to break any tests that relied