Re: several JavaCC warnings "Choice conflict involving two expansions"

2023-01-28 Thread Alessandro Solimando
Thanks Julian, I have logged CALCITE-5505 to keep this under our radar. Best regards, Alessandro On Sat, 28 Jan 2023 at 00:26, Julian Hyde wrote: > Good catch. Yes, we want to stay on top of these kinds of warnings. > (See broken windows theo

Re: several JavaCC warnings "Choice conflict involving two expansions"

2023-01-27 Thread Julian Hyde
Good catch. Yes, we want to stay on top of these kinds of warnings. (See broken windows theory [1].) Probably introduced by https://issues.apache.org/jira/browse/CALCITE-5450. Probably missing one or two LOOKAHEAD directives in the parser. Can you log a JIRA case please. Julian [1] https://en.wik

Fwd: several JavaCC warnings "Choice conflict involving two expansions"

2023-01-27 Thread Alessandro Solimando
Hello everyone, while checking CI logs I have noticed that we have lots of JavaCC warnings related to ambiguous prefixes in the productions of one of our grammars. They also seem related to time functions, for which I have seen several related developments for BigQuery lately. Have we verified th