>I'm not sure what combination of plugins would be best to do this
Josh, you might have missed, yet there's an option to add DockerHub hook
files to the repository, and DockerHub will execute them at build.
Then no replacements would be required.
What do you think?
Vladimir
I made an initial attempt at replacing the AVATICA_VERSION in the
dockerfiles during a build using the maven-replacer-plugin and the scm
plugin. Unfortunately, I was not able to get it to work correctly. The
commit is here:
Calcite developers and users,
I have just started a vote for sqlline-1.6.0 on the SQLLine dev list. If you
are a SQLLine committer or user, please participate. Here is the thread:
https://groups.google.com/forum/#!topic/sqlline-dev/SWHPzpyBwv0
Francis>We do need the dockerfiles with the correct version numbers
Francis>committed to git, because once we tag a release, docker hub will
build
Francis>the docker images from those dockerfiles and publish them to docker
hub
I see, then replacement the source file + commit might be a way to go
>direct replacement in the target file acceptable
What do you mean by that?
Vladimir
>I mean by direct replacement is that
What is the purpose of those files?
Do you mean end users should build docker files manually?
Do you intend to publish them as a part of Avatica release?
Vladimir
I think using dockerhub's hooks is definitely, an option. Josh, what do
you think? Then we can get rid of the stuff in the pom.xml to validate
the version number in the dockerfiles.
The downside is that anyone building the images on their own machine
would have to pass in the AVATICA_VERSION
On 21/11/2018 8:04 pm, Vladimir Sitnikov wrote:
I mean by direct replacement is that
What is the purpose of those files?
The files are used to build docker images.
Do you mean end users should build docker files manually?
The files should not be built manually. However, if the user wants to,
There are currently 2 Dockerfiles where we need to update the version
numbers:
-
https://github.com/apache/calcite-avatica/blob/master/docker/src/main/dockerhub/Dockerfile
-
https://github.com/apache/calcite-avatica/blob/master/docker/src/main/dockerhub-hypersql/Dockerfile
What I mean by
godfrey he created CALCITE-2690:
---
Summary: Uses ·getDescription· instead of ·toString· when gets
RelNode's digest
Key: CALCITE-2690
URL: https://issues.apache.org/jira/browse/CALCITE-2690
Project:
That makes sense! In Java do people tend to use templates for these
cases or is direct replacement in the target file acceptable?
I am currently looking at the replacement plugin
(https://code.google.com/archive/p/maven-replacer-plugin/) to replace
the `AVATICA_VER` lines in the dockerfiles
Francis>I am not too familiar with maven and its plugins, but from my
understanding
Typical Maven convention is to place the "template" file to
src/main/resources, then maven-resources-plugin would "filter" (==replace)
properties in the file and place the result into target/classes/...
For
Hi Julian,
I decided to reply to this (old) email, because here some facts are noted.
Funnily, Apache Flink released their MATCH_RECOGNIZE Implementation yesterday.
So I recall that you and Zhigiang He did something on this.
I would like to have such a feature in Calcite (as stated in the other
Git hooks run client-side, so there's nothing to do on the server.
Unfortunately, to work on Windows, I believe we would need to write two
versions of the hook.
--
Michael Mior
mm...@apache.org
Le lun. 19 nov. 2018 à 16:21, Julian Hyde a écrit :
> Are we allowed to create hooks in ASF’s git?
Michael>Unfortunately, to work on Windows, I believe we would need to write
two
Michael>versions of the hook.
Why do you think so?
Vladimir
Sounds excellent! Thanks to Julian (and other SQLLine committers) for
continuing to push this forward :)
--
Michael Mior
mm...@apache.org
Le mer. 21 nov. 2018 à 17:12, Julian Hyde a écrit :
> Calcite developers and users,
>
> I have just started a vote for sqlline-1.6.0 on the SQLLine dev
For this release, 99% of the credit is due to Sergey Nuyanzin (also a Calcite
committer). He has contributed countless excellent features.
> On Nov 21, 2018, at 6:02 PM, Michael Mior wrote:
>
> Sounds excellent! Thanks to Julian (and other SQLLine committers) for
> continuing to push this
Quick update: I was able to use docker hub's hooks to set the release
version of the docker images during build time as suggested by Vladimir.
In addition, I was also able to automate the publishing of the Avatica
HSQLDB image (CALCITE1948 [1]).
The trick to publishing the HSQLDB image is
Git for Windows includes a Windows port of bash (git bash), so bash
scripts should work just fine.
We just need to be careful with the commands we use as we need to make
sure they are ones that are also shipped with Git for Windows.
For reference: https://stackoverflow.com/a/18278072/624884
I could be wrong, but my understanding was that on Windows (as on other
platforms), hooks are simply scripts that are executed. Given that we can't
run a bash script on Windows (without making unnecessary assumptions about
the environment), it seems a second script would be needed.
--
Michael
Actually, I think filtering in the version is a good idea. I should have
thought of that one on my own :P. Thanks for the suggestion, Vladimir!
Looks like the Dockerhub stuff is still WIP (at least, that issue is
still open).
I'm not sure what combination of plugins would be best to do this
Sorry, this is an old mail which got sent accidentally again by my mail program.
Please ignore this and excuse this.
Julian
Am 21.11.18, 16:34 schrieb "Julian Feinauer" :
Hi Julian,
I decided to reply to this (old) email, because here some facts are noted.
Funnily, Apache
22 matches
Mail list logo
