Re: The correct source for foodmart test dataset (DB2 testing)

2016-05-13 Thread Julian Hyde
Using OSBI/foodmart-data is a smart idea. AFAIK it's the same data set. Can you post the output from the tests to, say, pastebin? By the way, just checking that you ran with -Dcalcite.test.db=DB2? If you didn't it will have silently run against hsqldb. On Fri, May 13, 2016 at 6:22 AM, Magnus

Re: Planner rule

2016-05-13 Thread Julian Hyde
If you are changing the semantics of the query I’m not sure that a planner rule is the right route. Planner rules need to preserve semantics. However, you will be working with the relational algebra. Probably adding a Filter to the root RelNode of your query. You might find the algebra

Planner rule

2016-05-13 Thread Kiril Menshikov
Hi, How to modify query and add one where condition? I suppose my queries can already contain where statement and might not contain. So as I understand, I should use HepPlanner? Thanks, -Kiril

Re: How to check for SELECT DISTINCT ...?

2016-05-13 Thread Julian Hyde
By the time the query is translated into relational algebra, SELECT DISTINCT will have been converted into an Aggregate with no aggregate functions. So, for instance, select distinct deptno from emp and select deptno from emp group by deptno will be indistinguishable if you look at the

How to check for SELECT DISTINCT ...?

2016-05-13 Thread Tzolov, Christian
Hi there, I am working on a Calcite adapter for a datastore that supports a limited subset of SQL expressions. My goal is to push down the supported expression. This datastore supports "ORDER BY” only if the SELECT DISTINCT expression is used. What would be the best way to check if the

The correct source for foodmart test dataset (DB2 testing)

2016-05-13 Thread Magnus Pierre
Hello, I’ve done the necessary code changes, added the db2 jar to the repository and added a dependency to it in pom.xml. Since I could not find the actual sources for mondrian foodmart used to build the test vm’s for Calcite https://github.com/vlsi/calcite-test-dataset

Re: Avatica error codes

2016-05-13 Thread F21
On 13/05/2016 5:30 PM, Julian Hyde wrote: Avatica’s ErrorResponse currently has the same information as JDBC (String sqlState, int errorCode, String errorMessage). I don’t think it’s wise to add an errorName field, because it would be difficult to propagate it with a JDBC SQLException. If

Limit without order_by badly unparsed

2016-05-13 Thread Emmanuel Bastien
Hello, I would like to open a Jira issue to contribute a very simple fix on how to unparse order_by clause with an empty column list. The context of the problem is the validation of queries with a limit clause but no order_by (e.g. "SELECT c FROM t LIMIT 2"). The problem does not show up at

Re: Avatica error codes

2016-05-13 Thread Julian Hyde
> On May 12, 2016, at 10:49 PM, F21 wrote: > > @Julian: Your commits for CALCITE-1230 looks great! I assume those codes are > going to be exceptions returned by avatica when it's processing the request > before handing off to phoenix or some other processor. Is that